diff mbox

[3/3] hid: logitech-dj: delete unnecessary error messages

Message ID 20180207170800.15015-4-christoph@boehmwalder.at (mailing list archive)
State New, archived
Headers show

Commit Message

Christoph Böhmwalder Feb. 7, 2018, 5:08 p.m. UTC 
Remove some "out of memory" messages that are considered useless.

Signed-off-by: Christoph Böhmwalder <christoph@boehmwalder.at>
---
 drivers/hid/hid-logitech-dj.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

Comments

Marcus Folkesson Feb. 8, 2018, 7:56 a.m. UTC | #1 
Hello Christoph,

On Wed, Feb 07, 2018 at 06:08:00PM +0100, Christoph Böhmwalder wrote:
> Remove some "out of memory" messages that are considered useless.
> 
> Signed-off-by: Christoph Böhmwalder <christoph@boehmwalder.at>
> ---
>  drivers/hid/hid-logitech-dj.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
> index 59c54cb4bc64..ba5239840cda 100644
> --- a/drivers/hid/hid-logitech-dj.c
> +++ b/drivers/hid/hid-logitech-dj.c
> @@ -414,11 +414,8 @@ static void logi_dj_recv_add_djhid_device(struct dj_receiver_dev *djrcv_dev,
>  
>  	dj_dev = kzalloc(sizeof(*dj_dev), GFP_KERNEL);
>  
> -	if (!dj_dev) {
> -		dev_err(&djrcv_hdev->dev, "%s: failed allocating dj_device\n",
> -			__func__);
> +	if (!dj_dev)
>  		goto dj_device_allocate_fail;
> -	}
>  
>  	dj_dev->reports_supported =
>  		get_unaligned_le32(dj_report->report_params
> @@ -1015,11 +1012,9 @@ static int logi_dj_probe(struct hid_device *hdev,
>  	/* Treat interface 2 */
>  
>  	djrcv_dev = kzalloc(sizeof(*djrcv_dev), GFP_KERNEL);
> -	if (!djrcv_dev) {
> -		dev_err(&hdev->dev,
> -			"%s:failed allocating dj_receiver_dev\n", __func__);
> +	if (!djrcv_dev)
>  		return -ENOMEM;
> -	}
> +
>  	djrcv_dev->hdev = hdev;
>  	INIT_WORK(&djrcv_dev->work, delayedwork_callback);
>  	spin_lock_init(&djrcv_dev->lock);
> -- 
> 2.13.6
> 

Thank you, but Markus Elfring already has a submitted a patch for this one.

/Marcus
Christoph Böhmwalder Feb. 8, 2018, 9:06 a.m. UTC | #2 
On Thu, Feb 08, 2018 at 08:56:28AM +0100, Marcus Folkesson wrote:
> 
> Thank you, but Markus Elfring already has a submitted a patch for this one.
> 
> /Marcus

Ah sorry, I must've missed that one.  Feel free to dismiss it then (it's
obviously independent of the other two anyways).

--
Regards,
Christoph
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
index 59c54cb4bc64..ba5239840cda 100644
--- a/drivers/hid/hid-logitech-dj.c
+++ b/drivers/hid/hid-logitech-dj.c
@@ -414,11 +414,8 @@  static void logi_dj_recv_add_djhid_device(struct dj_receiver_dev *djrcv_dev,
 
 	dj_dev = kzalloc(sizeof(*dj_dev), GFP_KERNEL);
 
-	if (!dj_dev) {
-		dev_err(&djrcv_hdev->dev, "%s: failed allocating dj_device\n",
-			__func__);
+	if (!dj_dev)
 		goto dj_device_allocate_fail;
-	}
 
 	dj_dev->reports_supported =
 		get_unaligned_le32(dj_report->report_params
@@ -1015,11 +1012,9 @@  static int logi_dj_probe(struct hid_device *hdev,
 	/* Treat interface 2 */
 
 	djrcv_dev = kzalloc(sizeof(*djrcv_dev), GFP_KERNEL);
-	if (!djrcv_dev) {
-		dev_err(&hdev->dev,
-			"%s:failed allocating dj_receiver_dev\n", __func__);
+	if (!djrcv_dev)
 		return -ENOMEM;
-	}
+
 	djrcv_dev->hdev = hdev;
 	INIT_WORK(&djrcv_dev->work, delayedwork_callback);
 	spin_lock_init(&djrcv_dev->lock);