diff mbox

ocfs2: clean up some unused function declaration

Message ID 5A7D1034.7050807@huawei.com (mailing list archive)
State New, archived
Headers show

Commit Message

piaojun Feb. 9, 2018, 3:06 a.m. UTC 
Clean up some unused function declaration in dlmcommon.h

Signed-off-by: Jun Piao <piaojun@huawei.com>
Reviewed-by: Yiwen Jiang <jiangyiwen@huawei.com>
---
 fs/ocfs2/dlm/dlmcommon.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

Changwei Ge Feb. 9, 2018, 4:30 a.m. UTC | #1 
It looks good to me.

Reviewed-by: Changwei Ge <ge.changwei@h3c.com>

On 2018/2/9 11:09, piaojun wrote:
> Clean up some unused function declaration in dlmcommon.h
> 
> Signed-off-by: Jun Piao <piaojun@huawei.com>
> Reviewed-by: Yiwen Jiang <jiangyiwen@huawei.com>
> ---
>   fs/ocfs2/dlm/dlmcommon.h | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/fs/ocfs2/dlm/dlmcommon.h b/fs/ocfs2/dlm/dlmcommon.h
> index e9f3705..953c200 100644
> --- a/fs/ocfs2/dlm/dlmcommon.h
> +++ b/fs/ocfs2/dlm/dlmcommon.h
> @@ -960,13 +960,10 @@ static inline int dlm_send_proxy_ast(struct dlm_ctxt *dlm,
>   void dlm_print_one_lock_resource(struct dlm_lock_resource *res);
>   void __dlm_print_one_lock_resource(struct dlm_lock_resource *res);
> 
> -u8 dlm_nm_this_node(struct dlm_ctxt *dlm);
>   void dlm_kick_thread(struct dlm_ctxt *dlm, struct dlm_lock_resource *res);
>   void __dlm_dirty_lockres(struct dlm_ctxt *dlm, struct dlm_lock_resource *res);
> 
> 
> -int dlm_nm_init(struct dlm_ctxt *dlm);
> -int dlm_heartbeat_init(struct dlm_ctxt *dlm);
>   void dlm_hb_node_down_cb(struct o2nm_node *node, int idx, void *data);
>   void dlm_hb_node_up_cb(struct o2nm_node *node, int idx, void *data);
>
Alex Chen Feb. 13, 2018, 1:54 a.m. UTC | #2 
Hi Jun,
Looks good to me.

On 2018/2/9 11:06, piaojun wrote:
> Clean up some unused function declaration in dlmcommon.h
> 
> Signed-off-by: Jun Piao <piaojun@huawei.com>
> Reviewed-by: Yiwen Jiang <jiangyiwen@huawei.com>
Reviewed-by: Alex Chen <alex.chen@huawei.com>

> ---
>  fs/ocfs2/dlm/dlmcommon.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/fs/ocfs2/dlm/dlmcommon.h b/fs/ocfs2/dlm/dlmcommon.h
> index e9f3705..953c200 100644
> --- a/fs/ocfs2/dlm/dlmcommon.h
> +++ b/fs/ocfs2/dlm/dlmcommon.h
> @@ -960,13 +960,10 @@ static inline int dlm_send_proxy_ast(struct dlm_ctxt *dlm,
>  void dlm_print_one_lock_resource(struct dlm_lock_resource *res);
>  void __dlm_print_one_lock_resource(struct dlm_lock_resource *res);
> 
> -u8 dlm_nm_this_node(struct dlm_ctxt *dlm);
>  void dlm_kick_thread(struct dlm_ctxt *dlm, struct dlm_lock_resource *res);
>  void __dlm_dirty_lockres(struct dlm_ctxt *dlm, struct dlm_lock_resource *res);
> 
> 
> -int dlm_nm_init(struct dlm_ctxt *dlm);
> -int dlm_heartbeat_init(struct dlm_ctxt *dlm);
>  void dlm_hb_node_down_cb(struct o2nm_node *node, int idx, void *data);
>  void dlm_hb_node_up_cb(struct o2nm_node *node, int idx, void *data);
>
diff mbox

Patch

diff --git a/fs/ocfs2/dlm/dlmcommon.h b/fs/ocfs2/dlm/dlmcommon.h
index e9f3705..953c200 100644
--- a/fs/ocfs2/dlm/dlmcommon.h
+++ b/fs/ocfs2/dlm/dlmcommon.h
@@ -960,13 +960,10 @@  static inline int dlm_send_proxy_ast(struct dlm_ctxt *dlm,
 void dlm_print_one_lock_resource(struct dlm_lock_resource *res);
 void __dlm_print_one_lock_resource(struct dlm_lock_resource *res);

-u8 dlm_nm_this_node(struct dlm_ctxt *dlm);
 void dlm_kick_thread(struct dlm_ctxt *dlm, struct dlm_lock_resource *res);
 void __dlm_dirty_lockres(struct dlm_ctxt *dlm, struct dlm_lock_resource *res);


-int dlm_nm_init(struct dlm_ctxt *dlm);
-int dlm_heartbeat_init(struct dlm_ctxt *dlm);
 void dlm_hb_node_down_cb(struct o2nm_node *node, int idx, void *data);
 void dlm_hb_node_up_cb(struct o2nm_node *node, int idx, void *data);