| Message ID | 20180210153204.12728-1-stefan@agner.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Feb 10, 2018 at 1:32 PM, Stefan Agner <stefan@agner.ch> wrote: > Add Dong Aisheng, Fabio Estevam, Shawn Guo and myself as maintainer > and Sascha as reviewer. > > Signed-off-by: Stefan Agner <stefan@agner.ch> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Am Samstag, den 10.02.2018, 16:32 +0100 schrieb Stefan Agner: > Add Dong Aisheng, Fabio Estevam, Shawn Guo and myself as maintainer > and Sascha as reviewer. > > Signed-off-by: Stefan Agner <stefan@agner.ch> > --- > MAINTAINERS | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 82ad0eabce4f..fb672dfc519d 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -10768,6 +10768,17 @@ L: linux-gpio@vger.kernel.org > S: Supported > F: drivers/pinctrl/pinctrl-at91-pio4.* > > +PIN CONTROLLER - FREESCALE > +M: Dong Aisheng <aisheng.dong@nxp.com> > +M: Fabio Estevam <festevam@gmail.com> > +M: Shawn Guo <shawnguo@kernel.org> > +M: Stefan Agner <stefan@agner.ch> > +R: Sascha Hauer <kernel@pengutronix.de> I'm fine with the patch, but it might make sense to clarify this a bit: the kernel@ address is really the whole Pengutronix kernel team, not just Sascha. Using this address is totally fine if you expect comments on patches, as it gives them a quite wide exposure inside of PTX. Regards, Lucas > +L: linux-gpio@vger.kernel.org > +S: Maintained > +F: drivers/pinctrl/freescale/* > +F: Documentation/devicetree/bindings/pinctrl/fsl,* > + > PIN CONTROLLER - INTEL > M: Mika Westerberg <mika.westerberg@linux.intel.com> > M: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Hi Lucas, On Mon, Feb 12, 2018 at 11:48:22AM +0100, Lucas Stach wrote: > Am Samstag, den 10.02.2018, 16:32 +0100 schrieb Stefan Agner: > > Add Dong Aisheng, Fabio Estevam, Shawn Guo and myself as maintainer > > and Sascha as reviewer. > > > > Signed-off-by: Stefan Agner <stefan@agner.ch> > > --- > > MAINTAINERS | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 82ad0eabce4f..fb672dfc519d 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -10768,6 +10768,17 @@ L: linux-gpio@vger.kernel.org > > S: Supported > > F: drivers/pinctrl/pinctrl-at91-pio4.* > > > > +PIN CONTROLLER - FREESCALE > > +M: Dong Aisheng <aisheng.dong@nxp.com> > > +M: Fabio Estevam <festevam@gmail.com> > > +M: Shawn Guo <shawnguo@kernel.org> > > +M: Stefan Agner <stefan@agner.ch> > > +R: Sascha Hauer <kernel@pengutronix.de> > > I'm fine with the patch, but it might make sense to clarify this a bit: > the kernel@ address is really the whole Pengutronix kernel team, not > just Sascha. Using this address is totally fine if you expect comments > on patches, as it gives them a quite wide exposure inside of PTX. Of the 5 mentions of kernel@pengutronix.de in MAINTAINERS as of v4.16-rc1, three name Sascha, and two name Uwe. Would you like to also clarify those? baruch
Am Montag, den 12.02.2018, 13:22 +0200 schrieb Baruch Siach: > Hi Lucas, > > On Mon, Feb 12, 2018 at 11:48:22AM +0100, Lucas Stach wrote: > > Am Samstag, den 10.02.2018, 16:32 +0100 schrieb Stefan Agner: > > > Add Dong Aisheng, Fabio Estevam, Shawn Guo and myself as > > > maintainer > > > and Sascha as reviewer. > > > > > > Signed-off-by: Stefan Agner <stefan@agner.ch> > > > --- > > > MAINTAINERS | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 82ad0eabce4f..fb672dfc519d 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -10768,6 +10768,17 @@ L: linux-gpio@vger.kernel.org > > > S: Supported > > > F: drivers/pinctrl/pinctrl-at91-pio4.* > > > > > > +PIN CONTROLLER - FREESCALE > > > +M: Dong Aisheng <aisheng.dong@nxp.com> > > > +M: Fabio Estevam <festevam@gmail.com> > > > +M: Shawn Guo <shawnguo@kernel.org> > > > +M: Stefan Agner <stefan@agner.ch> > > > +R: Sascha Hauer <kernel@pengutronix.de> > > > > I'm fine with the patch, but it might make sense to clarify this a > > bit: > > the kernel@ address is really the whole Pengutronix kernel team, > > not > > just Sascha. Using this address is totally fine if you expect > > comments > > on patches, as it gives them a quite wide exposure inside of PTX. > > Of the 5 mentions of kernel@pengutronix.de in MAINTAINERS as of > v4.16-rc1, > three name Sascha, and two name Uwe. Would you like to also clarify > those? I think it fine to keep the names of the individual people where they maintain stuff, as this is usually bound to a single person (where kernel@ address is only used for the exposure benefits), but I think it makes less sense for the reviewer role. Regards, Lucas
On 12.02.2018 12:34, Lucas Stach wrote: > Am Montag, den 12.02.2018, 13:22 +0200 schrieb Baruch Siach: >> Hi Lucas, >> >> On Mon, Feb 12, 2018 at 11:48:22AM +0100, Lucas Stach wrote: >> > Am Samstag, den 10.02.2018, 16:32 +0100 schrieb Stefan Agner: >> > > Add Dong Aisheng, Fabio Estevam, Shawn Guo and myself as >> > > maintainer >> > > and Sascha as reviewer. >> > > >> > > Signed-off-by: Stefan Agner <stefan@agner.ch> >> > > --- >> > > MAINTAINERS | 11 +++++++++++ >> > > 1 file changed, 11 insertions(+) >> > > >> > > diff --git a/MAINTAINERS b/MAINTAINERS >> > > index 82ad0eabce4f..fb672dfc519d 100644 >> > > --- a/MAINTAINERS >> > > +++ b/MAINTAINERS >> > > @@ -10768,6 +10768,17 @@ L: linux-gpio@vger.kernel.org >> > > S: Supported >> > > F: drivers/pinctrl/pinctrl-at91-pio4.* >> > > >> > > +PIN CONTROLLER - FREESCALE >> > > +M: Dong Aisheng <aisheng.dong@nxp.com> >> > > +M: Fabio Estevam <festevam@gmail.com> >> > > +M: Shawn Guo <shawnguo@kernel.org> >> > > +M: Stefan Agner <stefan@agner.ch> >> > > +R: Sascha Hauer <kernel@pengutronix.de> >> > >> > I'm fine with the patch, but it might make sense to clarify this a >> > bit: >> > the kernel@ address is really the whole Pengutronix kernel team, >> > not >> > just Sascha. Using this address is totally fine if you expect >> > comments >> > on patches, as it gives them a quite wide exposure inside of PTX. >> >> Of the 5 mentions of kernel@pengutronix.de in MAINTAINERS as of >> v4.16-rc1, >> three name Sascha, and two name Uwe. Would you like to also clarify >> those? > > I think it fine to keep the names of the individual people where they > maintain stuff, as this is usually bound to a single person (where > kernel@ address is only used for the exposure benefits), but I think it > makes less sense for the reviewer role. Sounds reasonable, I will send a v2 with: R: Pengutronix Kernel Team <kernel@pengutronix.de> -- Stefan > > Regards, > Lucas
diff --git a/MAINTAINERS b/MAINTAINERS index 82ad0eabce4f..fb672dfc519d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10768,6 +10768,17 @@ L: linux-gpio@vger.kernel.org S: Supported F: drivers/pinctrl/pinctrl-at91-pio4.* +PIN CONTROLLER - FREESCALE +M: Dong Aisheng <aisheng.dong@nxp.com> +M: Fabio Estevam <festevam@gmail.com> +M: Shawn Guo <shawnguo@kernel.org> +M: Stefan Agner <stefan@agner.ch> +R: Sascha Hauer <kernel@pengutronix.de> +L: linux-gpio@vger.kernel.org +S: Maintained +F: drivers/pinctrl/freescale/* +F: Documentation/devicetree/bindings/pinctrl/fsl,* + PIN CONTROLLER - INTEL M: Mika Westerberg <mika.westerberg@linux.intel.com> M: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Add Dong Aisheng, Fabio Estevam, Shawn Guo and myself as maintainer and Sascha as reviewer. Signed-off-by: Stefan Agner <stefan@agner.ch> --- MAINTAINERS | 11 +++++++++++ 1 file changed, 11 insertions(+)