| Message ID | 1518189456-2873-4-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Geert, On 09/02/18 16:17, Geert Uytterhoeven wrote: > Allow the instantation of generic dynamic sysbus devices again, without > the need to create a new device-specific vfio type. > > This is a partial revert of commit 6f2062b9758ebc64 ("hw/arm/virt: > Allow only supported dynamic sysbus devices"). > > Not-Yet-Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > hw/arm/virt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index b334c82edae9fb1f..fa83784fc08ed076 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -1596,6 +1596,7 @@ static void virt_machine_class_init(ObjectClass *oc, void *data) > mc->max_cpus = 255; > machine_class_allow_dynamic_sysbus_dev(mc, TYPE_VFIO_CALXEDA_XGMAC); > machine_class_allow_dynamic_sysbus_dev(mc, TYPE_VFIO_AMD_XGBE); > + machine_class_allow_dynamic_sysbus_dev(mc, TYPE_SYS_BUS_DEVICE); Couldn't you limit that to TYPE_VFIO_PLATFORM instead? Thanks Eric > mc->block_default_type = IF_VIRTIO; > mc->no_cdrom = 1; > mc->pci_allow_0_address = true; >
Hi Eric, On Wed, Feb 14, 2018 at 11:37 AM, Auger Eric <eric.auger@redhat.com> wrote: > On 09/02/18 16:17, Geert Uytterhoeven wrote: >> Allow the instantation of generic dynamic sysbus devices again, without >> the need to create a new device-specific vfio type. >> >> This is a partial revert of commit 6f2062b9758ebc64 ("hw/arm/virt: >> Allow only supported dynamic sysbus devices"). >> >> Not-Yet-Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> >> --- >> hw/arm/virt.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/arm/virt.c b/hw/arm/virt.c >> index b334c82edae9fb1f..fa83784fc08ed076 100644 >> --- a/hw/arm/virt.c >> +++ b/hw/arm/virt.c >> @@ -1596,6 +1596,7 @@ static void virt_machine_class_init(ObjectClass *oc, void *data) >> mc->max_cpus = 255; >> machine_class_allow_dynamic_sysbus_dev(mc, TYPE_VFIO_CALXEDA_XGMAC); >> machine_class_allow_dynamic_sysbus_dev(mc, TYPE_VFIO_AMD_XGBE); >> + machine_class_allow_dynamic_sysbus_dev(mc, TYPE_SYS_BUS_DEVICE); > Couldn't you limit that to TYPE_VFIO_PLATFORM instead? Yep, that works. Thanks! Gr{oetje,eeting}s, Geert
diff --git a/hw/arm/virt.c b/hw/arm/virt.c index b334c82edae9fb1f..fa83784fc08ed076 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -1596,6 +1596,7 @@ static void virt_machine_class_init(ObjectClass *oc, void *data) mc->max_cpus = 255; machine_class_allow_dynamic_sysbus_dev(mc, TYPE_VFIO_CALXEDA_XGMAC); machine_class_allow_dynamic_sysbus_dev(mc, TYPE_VFIO_AMD_XGBE); + machine_class_allow_dynamic_sysbus_dev(mc, TYPE_SYS_BUS_DEVICE); mc->block_default_type = IF_VIRTIO; mc->no_cdrom = 1; mc->pci_allow_0_address = true;
Allow the instantation of generic dynamic sysbus devices again, without the need to create a new device-specific vfio type. This is a partial revert of commit 6f2062b9758ebc64 ("hw/arm/virt: Allow only supported dynamic sysbus devices"). Not-Yet-Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- hw/arm/virt.c | 1 + 1 file changed, 1 insertion(+)