| Message ID | 1516911037-18292-1-git-send-email-aford173@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jan 25, 2018 at 2:10 PM, Adam Ford <aford173@gmail.com> wrote: > The pinmuxing was missing for I2C1 which was causing intermittent issues > with the PMIC which is connected to I2C1. The bootloader did not quite > configure the I2C1 either, so when running at 2.6MHz, it was generating > errors at time. > > This correctly sets the I2C1 pinmuxing so it can operate at 2.6MHz > > Fixes: 687c27676151 ("ARM: dts: Add minimal support for LogicPD Torpedo > DM3730 devkit") > > Signed-off-by: Adam Ford <aford173@gmail.com> > Tony, In the past, you've asked me not to post directly to stable@kernel.org, but I am not sure how to get these changes back ported to 4.4 and 4.9 to fix some stability issues with the I2C since the bootloader didn't do it quite right. Is there any chance you can apply these, so I can request stable to apply them to 4.4 and 4.9? thanks adam > diff --git a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi > index 6d89736..cf22b35 100644 > --- a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi > +++ b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi > @@ -104,6 +104,8 @@ > }; > > &i2c1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_pins>; > clock-frequency = <2600000>; > > twl: twl@48 { > @@ -211,6 +213,12 @@ > OMAP3_CORE1_IOPAD(0x21b8, PIN_INPUT | MUX_MODE0) /* hsusb0_data7.hsusb0_data7 */ > >; > }; > + i2c1_pins: pinmux_i2c1_pins { > + pinctrl-single,pins = < > + OMAP3_CORE1_IOPAD(0x21ba, PIN_INPUT | MUX_MODE0) /* i2c1_scl.i2c1_scl */ > + OMAP3_CORE1_IOPAD(0x21bc, PIN_INPUT | MUX_MODE0) /* i2c1_sda.i2c1_sda */ > + >; > + }; > }; > > &uart2 { > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Adam Ford <aford173@gmail.com> [180214 13:28]: > On Thu, Jan 25, 2018 at 2:10 PM, Adam Ford <aford173@gmail.com> wrote: > > The pinmuxing was missing for I2C1 which was causing intermittent issues > > with the PMIC which is connected to I2C1. The bootloader did not quite > > configure the I2C1 either, so when running at 2.6MHz, it was generating > > errors at time. > > > > This correctly sets the I2C1 pinmuxing so it can operate at 2.6MHz > > > > Fixes: 687c27676151 ("ARM: dts: Add minimal support for LogicPD Torpedo > > DM3730 devkit") ... > In the past, you've asked me not to post directly to > stable@kernel.org, but I am not sure how to get these changes back > ported to 4.4 and 4.9 to fix some stability issues with the I2C since > the bootloader didn't do it quite right. Is there any chance you can > apply these, so I can request stable to apply them to 4.4 and 4.9? Yeah those are the stable rules. In general I usually wait until -rc1 before I touch anything except for critical fixes. And then I apply pending fixes. And then I start looking at patches for the next merge window. And at about -rc6 I again really make an effort to stop touching any of the trees except for critical fixes. So patience please :) So I'm finally applying both your i2c fixes into omap-for-v4.16/fixes, then will probably send a pull request on Thursday for those. And then it will be a little while before it hits the mainline tree depending when arm-soc tree changes get merged. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi index 6d89736..cf22b35 100644 --- a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi +++ b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi @@ -104,6 +104,8 @@ }; &i2c1 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c1_pins>; clock-frequency = <2600000>; twl: twl@48 { @@ -211,6 +213,12 @@ OMAP3_CORE1_IOPAD(0x21b8, PIN_INPUT | MUX_MODE0) /* hsusb0_data7.hsusb0_data7 */ >; }; + i2c1_pins: pinmux_i2c1_pins { + pinctrl-single,pins = < + OMAP3_CORE1_IOPAD(0x21ba, PIN_INPUT | MUX_MODE0) /* i2c1_scl.i2c1_scl */ + OMAP3_CORE1_IOPAD(0x21bc, PIN_INPUT | MUX_MODE0) /* i2c1_sda.i2c1_sda */ + >; + }; }; &uart2 {
The pinmuxing was missing for I2C1 which was causing intermittent issues with the PMIC which is connected to I2C1. The bootloader did not quite configure the I2C1 either, so when running at 2.6MHz, it was generating errors at time. This correctly sets the I2C1 pinmuxing so it can operate at 2.6MHz Fixes: 687c27676151 ("ARM: dts: Add minimal support for LogicPD Torpedo DM3730 devkit") Signed-off-by: Adam Ford <aford173@gmail.com>