Message ID | 20180206233642.14591-1-colin.king@canonical.com (mailing list archive) |
---|---|
State | Accepted |
Delegated to: | Herbert Xu |
Headers | show |
On Tue, Feb 06, 2018 at 11:36:42PM +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Functions qat_rsa_set_n, qat_rsa_set_e and qat_rsa_set_n are local to > the source and do not need to be in global scope, so make them static. > > Cleans up sparse warnings: > drivers/crypto/qat/qat_common/qat_asym_algs.c:972:5: warning: symbol > 'qat_rsa_set_n' was not declared. Should it be static? > drivers/crypto/qat/qat_common/qat_asym_algs.c:1003:5: warning: symbol > 'qat_rsa_set_e' was not declared. Should it be static? > drivers/crypto/qat/qat_common/qat_asym_algs.c:1027:5: warning: symbol > 'qat_rsa_set_d' was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Patch applied. Thanks.
diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c b/drivers/crypto/qat/qat_common/qat_asym_algs.c index 13c52d6bf630..320e7854b4ee 100644 --- a/drivers/crypto/qat/qat_common/qat_asym_algs.c +++ b/drivers/crypto/qat/qat_common/qat_asym_algs.c @@ -969,7 +969,8 @@ static int qat_rsa_dec(struct akcipher_request *req) return ret; } -int qat_rsa_set_n(struct qat_rsa_ctx *ctx, const char *value, size_t vlen) +static int qat_rsa_set_n(struct qat_rsa_ctx *ctx, const char *value, + size_t vlen) { struct qat_crypto_instance *inst = ctx->inst; struct device *dev = &GET_DEV(inst->accel_dev); @@ -1000,7 +1001,8 @@ int qat_rsa_set_n(struct qat_rsa_ctx *ctx, const char *value, size_t vlen) return ret; } -int qat_rsa_set_e(struct qat_rsa_ctx *ctx, const char *value, size_t vlen) +static int qat_rsa_set_e(struct qat_rsa_ctx *ctx, const char *value, + size_t vlen) { struct qat_crypto_instance *inst = ctx->inst; struct device *dev = &GET_DEV(inst->accel_dev); @@ -1024,7 +1026,8 @@ int qat_rsa_set_e(struct qat_rsa_ctx *ctx, const char *value, size_t vlen) return 0; } -int qat_rsa_set_d(struct qat_rsa_ctx *ctx, const char *value, size_t vlen) +static int qat_rsa_set_d(struct qat_rsa_ctx *ctx, const char *value, + size_t vlen) { struct qat_crypto_instance *inst = ctx->inst; struct device *dev = &GET_DEV(inst->accel_dev);