| Message ID | 20180221105738.6690-1-tvrtko.ursulin@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Quoting Tvrtko Ursulin (2018-02-21 10:57:38) > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Apollolake machine in the shards cannot bring the CPU0 back online so > skip the test on all Broxtons for now. > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > --- > tests/perf_pmu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c > index 0beb91976102..b6debf523201 100644 > --- a/tests/perf_pmu.c > +++ b/tests/perf_pmu.c > @@ -966,6 +966,7 @@ static void cpu_hotplug(int gem_fd) > int fd, ret; > int cur = 0; > > + igt_require(IS_BROXTON(intel_get_drm_devid(gem_fd))); > igt_require(cpu0_hotplug_support()); I would plonk it in cpu0_hotplug_support() with a one-liner explanation? Acked-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c index 0beb91976102..b6debf523201 100644 --- a/tests/perf_pmu.c +++ b/tests/perf_pmu.c @@ -966,6 +966,7 @@ static void cpu_hotplug(int gem_fd) int fd, ret; int cur = 0; + igt_require(IS_BROXTON(intel_get_drm_devid(gem_fd))); igt_require(cpu0_hotplug_support()); fd = open_pmu(I915_PMU_ENGINE_BUSY(I915_ENGINE_CLASS_RENDER, 0));