| Message ID | 20180210092702.4393-1-marcus.folkesson@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/10/2018 01:27 AM, Marcus Folkesson wrote: > Licence text is specifying "GPLv2" but the MODULE_LICENSE is set to "GPLv2 > or later". > > See include/linux/module.h: > "GPL" [GNU Public License v2 or later] > "GPL v2" [GNU Public License v2] > > When on it, add SPDX identifier tag. > > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/watchdog/coh901327_wdt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/watchdog/coh901327_wdt.c b/drivers/watchdog/coh901327_wdt.c > index 5d8eb9a30879..7b71e0a3e6cc 100644 > --- a/drivers/watchdog/coh901327_wdt.c > +++ b/drivers/watchdog/coh901327_wdt.c > @@ -1,8 +1,8 @@ > +// SPDX-License-Identifier: GPL-2.0 > /* > * coh901327_wdt.c > * > * Copyright (C) 2008-2009 ST-Ericsson AB > - * License terms: GNU General Public License (GPL) version 2 > * Watchdog driver for the ST-Ericsson AB COH 901 327 IP core > * Author: Linus Walleij <linus.walleij@stericsson.com> > */ > @@ -420,5 +420,5 @@ MODULE_DESCRIPTION("COH 901 327 Watchdog"); > module_param(margin, uint, 0); > MODULE_PARM_DESC(margin, "Watchdog margin in seconds (default 60s)"); > > -MODULE_LICENSE("GPL"); > +MODULE_LICENSE("GPL v2"); > MODULE_ALIAS("platform:coh901327-watchdog"); >
On Sat, Feb 10, 2018 at 10:27 AM, Marcus Folkesson <marcus.folkesson@gmail.com> wrote: > Licence text is specifying "GPLv2" but the MODULE_LICENSE is set to "GPLv2 > or later". > > See include/linux/module.h: > "GPL" [GNU Public License v2 or later] > "GPL v2" [GNU Public License v2] > > When on it, add SPDX identifier tag. > > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/drivers/watchdog/coh901327_wdt.c b/drivers/watchdog/coh901327_wdt.c index 5d8eb9a30879..7b71e0a3e6cc 100644 --- a/drivers/watchdog/coh901327_wdt.c +++ b/drivers/watchdog/coh901327_wdt.c @@ -1,8 +1,8 @@ +// SPDX-License-Identifier: GPL-2.0 /* * coh901327_wdt.c * * Copyright (C) 2008-2009 ST-Ericsson AB - * License terms: GNU General Public License (GPL) version 2 * Watchdog driver for the ST-Ericsson AB COH 901 327 IP core * Author: Linus Walleij <linus.walleij@stericsson.com> */ @@ -420,5 +420,5 @@ MODULE_DESCRIPTION("COH 901 327 Watchdog"); module_param(margin, uint, 0); MODULE_PARM_DESC(margin, "Watchdog margin in seconds (default 60s)"); -MODULE_LICENSE("GPL"); +MODULE_LICENSE("GPL v2"); MODULE_ALIAS("platform:coh901327-watchdog");
Licence text is specifying "GPLv2" but the MODULE_LICENSE is set to "GPLv2 or later". See include/linux/module.h: "GPL" [GNU Public License v2 or later] "GPL v2" [GNU Public License v2] When on it, add SPDX identifier tag. Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> --- drivers/watchdog/coh901327_wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)