| Message ID | 20180226144943.9835-1-andrew.smirnov@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Feb 26, 2018 at 11:49 AM, Andrey Smirnov <andrew.smirnov@gmail.com> wrote: > With MFD and watchdog drivers for RAVE SP device support added by > 538ee27290fa ("mfd: Add driver for RAVE Supervisory Processor") and > c3bb33345721 ("watchdog: Add RAVE SP watchdog driver") add > corresponding DT node for RDU2. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Chris Healy <cphealy@gmail.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: devicetree@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
On Mon, Feb 26, 2018 at 06:49:41AM -0800, Andrey Smirnov wrote: > With MFD and watchdog drivers for RAVE SP device support added by > 538ee27290fa ("mfd: Add driver for RAVE Supervisory Processor") and > c3bb33345721 ("watchdog: Add RAVE SP watchdog driver") add > corresponding DT node for RDU2. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Chris Healy <cphealy@gmail.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: devicetree@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > --- > arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi > index 72f52fcecee1..460931089509 100644 > --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi > @@ -305,6 +305,17 @@ > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_uart4>; > status = "okay"; > + > + rave-sp { > + compatible = "zii,rave-sp-rdu2"; > + current-speed = <1000000>; > + status = "okay"; The okay status is to flip the state of devices that are initially disabled. I think it's unnecessary for the case here. > + > + watchdog { > + compatible = "zii,rave-sp-watchdog"; > + status = "okay"; Ditto Shawn > + }; > + }; > }; > > &ecspi1 { > -- > 2.14.3 >
On Tue, Feb 27, 2018 at 10:31 PM, Shawn Guo <shawnguo@kernel.org> wrote: > On Mon, Feb 26, 2018 at 06:49:41AM -0800, Andrey Smirnov wrote: >> With MFD and watchdog drivers for RAVE SP device support added by >> 538ee27290fa ("mfd: Add driver for RAVE Supervisory Processor") and >> c3bb33345721 ("watchdog: Add RAVE SP watchdog driver") add >> corresponding DT node for RDU2. >> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: Mark Rutland <mark.rutland@arm.com> >> Cc: Shawn Guo <shawnguo@kernel.org> >> Cc: Fabio Estevam <fabio.estevam@nxp.com> >> Cc: Guenter Roeck <linux@roeck-us.net> >> Cc: Chris Healy <cphealy@gmail.com> >> Cc: Lucas Stach <l.stach@pengutronix.de> >> Cc: devicetree@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> >> --- >> arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi >> index 72f52fcecee1..460931089509 100644 >> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi >> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi >> @@ -305,6 +305,17 @@ >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_uart4>; >> status = "okay"; >> + >> + rave-sp { >> + compatible = "zii,rave-sp-rdu2"; >> + current-speed = <1000000>; >> + status = "okay"; > > The okay status is to flip the state of devices that are initially > disabled. I think it's unnecessary for the case here. Good point, will respin v2 without that bit shortly. Thanks, Andrey Smirnov
diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi index 72f52fcecee1..460931089509 100644 --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi @@ -305,6 +305,17 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart4>; status = "okay"; + + rave-sp { + compatible = "zii,rave-sp-rdu2"; + current-speed = <1000000>; + status = "okay"; + + watchdog { + compatible = "zii,rave-sp-watchdog"; + status = "okay"; + }; + }; }; &ecspi1 {
With MFD and watchdog drivers for RAVE SP device support added by 538ee27290fa ("mfd: Add driver for RAVE Supervisory Processor") and c3bb33345721 ("watchdog: Add RAVE SP watchdog driver") add corresponding DT node for RDU2. Cc: Rob Herring <robh+dt@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Fabio Estevam <fabio.estevam@nxp.com> Cc: Guenter Roeck <linux@roeck-us.net> Cc: Chris Healy <cphealy@gmail.com> Cc: Lucas Stach <l.stach@pengutronix.de> Cc: devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> --- arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+)