[v10,23/28] qmp: add query-sev-launch-measure command

Commit Message

Brijesh Singh Feb. 28, 2018, 9:10 p.m. UTC

The command can be used by libvirt to retrieve the measurement of SEV guest.
This measurement is a signature of the memory contents that was encrypted
through the LAUNCH_UPDATE_DATA.

Cc: "Daniel P. Berrangé" <[e-mail]>
Cc: "Dr. David Alan Gilbert" <[e-mail]>
Cc: Markus Armbruster <[e-mail]>
Signed-off-by: Brijesh Singh <[e-mail]>
---
 monitor.c             |  7 +++++++
 qapi-schema.json      | 29 +++++++++++++++++++++++++++++
 target/i386/monitor.c | 17 +++++++++++++++++
 3 files changed, 53 insertions(+)

Comments

Eric Blake March 1, 2018, 8:11 p.m. UTC | #1

On 02/28/2018 03:10 PM, Brijesh Singh wrote:
> The command can be used by libvirt to retrieve the measurement of SEV guest.
> This measurement is a signature of the memory contents that was encrypted
> through the LAUNCH_UPDATE_DATA.
> 
> Cc: "Daniel P. Berrangé" <[e-mail]>
> Cc: "Dr. David Alan Gilbert" <[e-mail]>
> Cc: Markus Armbruster <[e-mail]>
> Signed-off-by: Brijesh Singh <[e-mail]>
> ---
>   monitor.c             |  7 +++++++
>   qapi-schema.json      | 29 +++++++++++++++++++++++++++++

Again, will need a rebase once the pending QAPI pull lands.

>   target/i386/monitor.c | 17 +++++++++++++++++
>   3 files changed, 53 insertions(+)
> 

Reviewed-by: Eric Blake <[e-mail]>

Patch

diff --git a/monitor.c b/monitor.c
index 356d550aaf2d..d0ebd5906d9d 100644
--- a/monitor.c
+++ b/monitor.c
@@ -984,6 +984,7 @@  static void qmp_unregister_commands_hack(void)
 #ifndef TARGET_I386
     qmp_unregister_command(&qmp_commands, "rtc-reset-reinjection");
     qmp_unregister_command(&qmp_commands, "query-sev");
+    qmp_unregister_command(&qmp_commands, "query-sev-launch-measure");
 #endif
 #ifndef TARGET_S390X
     qmp_unregister_command(&qmp_commands, "dump-skeys");
@@ -4164,6 +4165,12 @@  SevInfo *qmp_query_sev(Error **errp)
     error_setg(errp, QERR_FEATURE_DISABLED, "query-sev");
     return NULL;
 }
+
+SevLaunchMeasureInfo *qmp_query_sev_launch_measure(Error **errp)
+{
+    error_setg(errp, QERR_FEATURE_DISABLED, "query-sev-launch-measure");
+    return NULL;
+}
 #endif
 
 #ifndef TARGET_S390X
diff --git a/qapi-schema.json b/qapi-schema.json
index 467a06460ead..facf2138df6b 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3250,3 +3250,32 @@ 
 #
 ##
 { 'command': 'query-sev', 'returns': 'SevInfo' }
+
+##
+# @SevLaunchMeasureInfo:
+#
+# SEV Guest Launch measurement information
+#
+# @data: the measurement value encoded in base64
+#
+# Since: 2.12
+#
+##
+{ 'struct': 'SevLaunchMeasureInfo', 'data': {'data': 'str'} }
+
+##
+# @query-sev-launch-measure:
+#
+# Query the SEV guest launch information.
+#
+# Returns: The @SevLaunchMeasureInfo for the guest
+#
+# Since: 2.12
+#
+# Example:
+#
+# -> { "execute": "query-sev-launch-measure" }
+# <- { "return": { "data": "4l8LXeNlSPUDlXPJG5966/8%YZ" } }
+#
+##
+{ 'command': 'query-sev-launch-measure', 'returns': 'SevLaunchMeasureInfo' }
diff --git a/target/i386/monitor.c b/target/i386/monitor.c
index 64d459f80f0c..577d50eebaaa 100644
--- a/target/i386/monitor.c
+++ b/target/i386/monitor.c
@@ -720,3 +720,20 @@  void hmp_info_sev(Monitor *mon, const QDict *qdict)
         monitor_printf(mon, "SEV is not enabled\n");
     }
 }
+
+SevLaunchMeasureInfo *qmp_query_sev_launch_measure(Error **errp)
+{
+    char *data;
+    SevLaunchMeasureInfo *info;
+
+    data = sev_get_launch_measurement();
+    if (!data) {
+        error_setg(errp, "Measurement is not available");
+        return NULL;
+    }
+
+    info = g_malloc0(sizeof(*info));
+    info->data = data;
+
+    return info;
+}