| Message ID | 1519941800-27710-3-git-send-email-me@tobin.cc (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Mar 02, 2018 at 09:03:20AM +1100, Tobin C. Harding wrote: > Sometimes files may be created by using output from printk. As the scan > traverses the directory tree we should parse each path name and check if > it is leaking an address. > > Add check for leaking address on each path name. > > Suggested-by: Tycho Andersen <tycho@tycho.ws> Acked-by: Tycho Andersen <tycho@tycho.ws> > Signed-off-by: Tobin C. Harding <me@tobin.cc> > --- > scripts/leaking_addresses.pl | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl > index 65a65aa64d26..a550c9bc34f5 100755 > --- a/scripts/leaking_addresses.pl > +++ b/scripts/leaking_addresses.pl > @@ -463,6 +463,16 @@ sub parse_file > close $fh; > } > > +# Checks if the actual path name is leaking a kernel address. > +sub check_path_for_leaks > +{ > + my ($path) = @_; > + > + if (may_leak_address($path)) { > + printf("Path name may contain address: $path\n"); > + } > +} > + > # Recursively walk directory tree. > sub walk > { > @@ -484,6 +494,8 @@ sub walk > > next if (skip($path)); > > + check_path_for_leaks($path); > + > if (-d $path) { > push @dirs, $path; > next; > -- > 2.7.4 >
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl index 65a65aa64d26..a550c9bc34f5 100755 --- a/scripts/leaking_addresses.pl +++ b/scripts/leaking_addresses.pl @@ -463,6 +463,16 @@ sub parse_file close $fh; } +# Checks if the actual path name is leaking a kernel address. +sub check_path_for_leaks +{ + my ($path) = @_; + + if (may_leak_address($path)) { + printf("Path name may contain address: $path\n"); + } +} + # Recursively walk directory tree. sub walk { @@ -484,6 +494,8 @@ sub walk next if (skip($path)); + check_path_for_leaks($path); + if (-d $path) { push @dirs, $path; next;
Sometimes files may be created by using output from printk. As the scan traverses the directory tree we should parse each path name and check if it is leaking an address. Add check for leaking address on each path name. Suggested-by: Tycho Andersen <tycho@tycho.ws> Signed-off-by: Tobin C. Harding <me@tobin.cc> --- scripts/leaking_addresses.pl | 12 ++++++++++++ 1 file changed, 12 insertions(+)