| Message ID | 44ee5bd5053d579dc6c46b21e2ef8f6acf70e4ce.1520660422.git.gustavo@embeddedor.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Mar 10, 2018 at 7:27 AM, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote: > Move this enum to rtc-s5m.c once it is meaningless to others drivers [1]. > > [1] https://marc.info/?l=linux-rtc&m=152060068925948&w=2 Instead of external link (which might or might not work soon) you can just put "Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>". Anyway: Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
On Sat, 10 Mar 2018, Gustavo A. R. Silva wrote: > Move this enum to rtc-s5m.c once it is meaningless to others drivers [1]. > > [1] https://marc.info/?l=linux-rtc&m=152060068925948&w=2 > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/rtc/rtc-s5m.c | 11 +++++++++++ > include/linux/mfd/samsung/rtc.h | 11 ----------- I don't think this will conflict with anything (unless some major works are carried out within the next few weeks - in which case I'll need a pull-request, but for now ...) Acked-by: Lee Jones <lee.jones@linaro.org>
On 03/11/2018 11:39 AM, Krzysztof Kozlowski wrote: > On Sat, Mar 10, 2018 at 7:27 AM, Gustavo A. R. Silva > <gustavo@embeddedor.com> wrote: >> Move this enum to rtc-s5m.c once it is meaningless to others drivers [1]. >> >> [1] https://marc.info/?l=linux-rtc&m=152060068925948&w=2 > > Instead of external link (which might or might not work soon) you can > just put "Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>". > I got it. I'll do that next time. > Anyway: > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > Thanks for reviewing it. -- Gustavo
diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 6deae10..4c363de 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -38,6 +38,17 @@ */ #define UDR_READ_RETRY_CNT 5 +enum { + RTC_SEC = 0, + RTC_MIN, + RTC_HOUR, + RTC_WEEKDAY, + RTC_DATE, + RTC_MONTH, + RTC_YEAR1, + RTC_YEAR2, +}; + /* * Registers used by the driver which are different between chipsets. * diff --git a/include/linux/mfd/samsung/rtc.h b/include/linux/mfd/samsung/rtc.h index 48c3c5b..9ed2871 100644 --- a/include/linux/mfd/samsung/rtc.h +++ b/include/linux/mfd/samsung/rtc.h @@ -141,15 +141,4 @@ enum s2mps_rtc_reg { #define WTSR_ENABLE_SHIFT 6 #define WTSR_ENABLE_MASK (1 << WTSR_ENABLE_SHIFT) -enum { - RTC_SEC = 0, - RTC_MIN, - RTC_HOUR, - RTC_WEEKDAY, - RTC_DATE, - RTC_MONTH, - RTC_YEAR1, - RTC_YEAR2, -}; - #endif /* __LINUX_MFD_SEC_RTC_H */
Move this enum to rtc-s5m.c once it is meaningless to others drivers [1]. [1] https://marc.info/?l=linux-rtc&m=152060068925948&w=2 Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/rtc/rtc-s5m.c | 11 +++++++++++ include/linux/mfd/samsung/rtc.h | 11 ----------- 2 files changed, 11 insertions(+), 11 deletions(-)