diff mbox

regulator: fix platform_no_drv_owner.cocci warnings

Message ID 20180318203832.GA74597@lkp-hsx03.lkp.intel.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

kernel test robot March 18, 2018, 8:38 p.m. UTC 
From: Fengguang Wu <fengguang.wu@intel.com>

drivers/regulator/qcom_rpmh-regulator.c:1104:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes: 835fda5b6c24 ("regulator: add QCOM RPMh regulator driver")
CC: David Collins <collinsd@codeaurora.org>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 qcom_rpmh-regulator.c |    1 -
 1 file changed, 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Collins March 19, 2018, 9:47 p.m. UTC | #1 
On 03/18/2018 01:38 PM, kbuild test robot wrote:
> From: Fengguang Wu <fengguang.wu@intel.com>
> 
> drivers/regulator/qcom_rpmh-regulator.c:1104:3-8: 
> No need to set .owner here. The core will do it.

Thanks for pointing this out.

> --- a/drivers/regulator/qcom_rpmh-regulator.c
> +++ b/drivers/regulator/qcom_rpmh-regulator.c
> @@ -1101,7 +1101,6 @@ static struct platform_driver rpmh_regul
>  	.driver		= {
>  		.name		= "qcom-rpmh-regulator",
>  		.of_match_table	= rpmh_regulator_match_table,
> -		.owner		= THIS_MODULE,
>  	},
>  	.probe		= rpmh_regulator_probe,
>  	.remove		= rpmh_regulator_remove,

I'll make this modification in [1] if I end up sending out a second
version of the patch.

Take care,
David

[1]: https://lkml.org/lkml/2018/3/16/1430
diff mbox

Patch

--- a/drivers/regulator/qcom_rpmh-regulator.c
+++ b/drivers/regulator/qcom_rpmh-regulator.c
@@ -1101,7 +1101,6 @@  static struct platform_driver rpmh_regul
 	.driver		= {
 		.name		= "qcom-rpmh-regulator",
 		.of_match_table	= rpmh_regulator_match_table,
-		.owner		= THIS_MODULE,
 	},
 	.probe		= rpmh_regulator_probe,
 	.remove		= rpmh_regulator_remove,