| Message ID | 01ddf0ac8962feb63e8871a2c2c3498c763f649b.1518166039.git.viresh.kumar@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 09-02-18, 14:28, Viresh Kumar wrote: > The "cooling-min-level" and "cooling-max-level" properties are not > parsed by any part of the kernel currently and the max cooling state of > gpio-fan cooling device is found by referring to the > "gpio-fan,speed-map" instead. > > Remove the unused properties from the gpio-fan node. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > arch/arm/boot/dts/gemini-dlink-dns-313.dts | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm/boot/dts/gemini-dlink-dns-313.dts b/arch/arm/boot/dts/gemini-dlink-dns-313.dts > index 08568ce24d06..727d16eb02d9 100644 > --- a/arch/arm/boot/dts/gemini-dlink-dns-313.dts > +++ b/arch/arm/boot/dts/gemini-dlink-dns-313.dts > @@ -78,8 +78,6 @@ > gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>, > <&gpio0 12 GPIO_ACTIVE_HIGH>; > gpio-fan,speed-map = <0 0>, <3000 1>, <6000 2>; > - cooling-min-level = <0>; > - cooling-max-level = <2>; > #cooling-cells = <2>; > }; > @Linus: Can you please pick this one for 4.17 ?
On 12-03-18, 10:05, Viresh Kumar wrote: > On 09-02-18, 14:28, Viresh Kumar wrote: > > The "cooling-min-level" and "cooling-max-level" properties are not > > parsed by any part of the kernel currently and the max cooling state of > > gpio-fan cooling device is found by referring to the > > "gpio-fan,speed-map" instead. > > > > Remove the unused properties from the gpio-fan node. > > > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > --- > > arch/arm/boot/dts/gemini-dlink-dns-313.dts | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/gemini-dlink-dns-313.dts b/arch/arm/boot/dts/gemini-dlink-dns-313.dts > > index 08568ce24d06..727d16eb02d9 100644 > > --- a/arch/arm/boot/dts/gemini-dlink-dns-313.dts > > +++ b/arch/arm/boot/dts/gemini-dlink-dns-313.dts > > @@ -78,8 +78,6 @@ > > gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>, > > <&gpio0 12 GPIO_ACTIVE_HIGH>; > > gpio-fan,speed-map = <0 0>, <3000 1>, <6000 2>; > > - cooling-min-level = <0>; > > - cooling-max-level = <2>; > > #cooling-cells = <2>; > > }; > > > > @Linus: Can you please pick this one for 4.17 ? @Arnd/Olof: Can you please pick this one up as well ?
On Fri, Feb 9, 2018 at 9:58 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote: > The "cooling-min-level" and "cooling-max-level" properties are not > parsed by any part of the kernel currently and the max cooling state of > gpio-fan cooling device is found by referring to the > "gpio-fan,speed-map" instead. > > Remove the unused properties from the gpio-fan node. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Acked-by: Linus Walleij <linus.walleij@linaro.org> I can queue it next week (different machine hosting the git tree) but it is also OK if the ARM SoC maintainers want to pick it directly for the ARM SoC DTS branch. Yours, Linus Walleij
On Tue, Mar 20, 2018 at 4:10 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Fri, Feb 9, 2018 at 9:58 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote: > >> The "cooling-min-level" and "cooling-max-level" properties are not >> parsed by any part of the kernel currently and the max cooling state of >> gpio-fan cooling device is found by referring to the >> "gpio-fan,speed-map" instead. >> >> Remove the unused properties from the gpio-fan node. >> >> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > I can queue it next week (different machine hosting the git tree) > but it is also OK if the ARM SoC maintainers want to pick it > directly for the ARM SoC DTS branch. I've picked it up directly now, as we're about to run out of time before the merge window. Arnd
On Tue, Mar 27, 2018 at 2:26 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Tue, Mar 20, 2018 at 4:10 AM, Linus Walleij <linus.walleij@linaro.org> wrote: >> On Fri, Feb 9, 2018 at 9:58 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote: >> >>> The "cooling-min-level" and "cooling-max-level" properties are not >>> parsed by any part of the kernel currently and the max cooling state of >>> gpio-fan cooling device is found by referring to the >>> "gpio-fan,speed-map" instead. >>> >>> Remove the unused properties from the gpio-fan node. >>> >>> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> >> >> Acked-by: Linus Walleij <linus.walleij@linaro.org> >> >> I can queue it next week (different machine hosting the git tree) >> but it is also OK if the ARM SoC maintainers want to pick it >> directly for the ARM SoC DTS branch. > > I've picked it up directly now, as we're about to run out of time > before the merge window. Thanks, I was just about to queue it and send a pull request but now I don't need to :) Yours, Linus Walleij
diff --git a/arch/arm/boot/dts/gemini-dlink-dns-313.dts b/arch/arm/boot/dts/gemini-dlink-dns-313.dts index 08568ce24d06..727d16eb02d9 100644 --- a/arch/arm/boot/dts/gemini-dlink-dns-313.dts +++ b/arch/arm/boot/dts/gemini-dlink-dns-313.dts @@ -78,8 +78,6 @@ gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>, <&gpio0 12 GPIO_ACTIVE_HIGH>; gpio-fan,speed-map = <0 0>, <3000 1>, <6000 2>; - cooling-min-level = <0>; - cooling-max-level = <2>; #cooling-cells = <2>; };
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of gpio-fan cooling device is found by referring to the "gpio-fan,speed-map" instead. Remove the unused properties from the gpio-fan node. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- arch/arm/boot/dts/gemini-dlink-dns-313.dts | 2 -- 1 file changed, 2 deletions(-)