Message ID | cacb081b-619f-413e-0ebf-38f8e8af3d25@jp.fujitsu.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On 2018年03月20日 14:47, Misono, Tomohiro wrote: > > Signed-off-by: Tomohiro Misono <misono.tomohiro@jp.fujitsu.com> Reviewed-by: Qu Wenruo <wqu@suse.com> BTW this reminds me that, btrfs-progs is still using BTRFS_CRC32_SIZE macro which the original comment is for. It may be a good time to clean it up in btrfs-progs. Thanks, Qu > --- > fs/btrfs/ctree.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h > index da308774b8a4..8f59cb20dd4c 100644 > --- a/fs/btrfs/ctree.h > +++ b/fs/btrfs/ctree.h > @@ -86,9 +86,9 @@ struct btrfs_ordered_sum; > */ > #define BTRFS_LINK_MAX 65535U > > +/* four bytes for CRC32 */ > static const int btrfs_csum_sizes[] = { 4 }; > > -/* four bytes for CRC32 */ > #define BTRFS_EMPTY_DIR_SIZE 0 > > /* ioprio of readahead is set to idle */ >
On Tue, Mar 20, 2018 at 04:50:32PM +0800, Qu Wenruo wrote: > > > On 2018年03月20日 14:47, Misono, Tomohiro wrote: > > > > Signed-off-by: Tomohiro Misono <misono.tomohiro@jp.fujitsu.com> > > Reviewed-by: Qu Wenruo <wqu@suse.com> Added to next, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2018/03/20 17:50, Qu Wenruo wrote: > > > On 2018年03月20日 14:47, Misono, Tomohiro wrote: >> >> Signed-off-by: Tomohiro Misono <misono.tomohiro@jp.fujitsu.com> > > Reviewed-by: Qu Wenruo <wqu@suse.com> > > BTW this reminds me that, btrfs-progs is still using BTRFS_CRC32_SIZE > macro which the original comment is for. > > It may be a good time to clean it up in btrfs-progs. > > Thanks, > Qu Thanks for the suggestion, I will send a cleanup patch. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index da308774b8a4..8f59cb20dd4c 100644 --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h @@ -86,9 +86,9 @@ struct btrfs_ordered_sum; */ #define BTRFS_LINK_MAX 65535U +/* four bytes for CRC32 */ static const int btrfs_csum_sizes[] = { 4 }; -/* four bytes for CRC32 */ #define BTRFS_EMPTY_DIR_SIZE 0 /* ioprio of readahead is set to idle */
Signed-off-by: Tomohiro Misono <misono.tomohiro@jp.fujitsu.com> --- fs/btrfs/ctree.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)