| Message ID | 20180319133310.4251-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Colin, On 03/19/2018 09:33 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Trivial fix to spelling mistake in rdb_warn message text > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/block/rbd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c > index 1e03b04819c8..7b97240ff15e 100644 > --- a/drivers/block/rbd.c > +++ b/drivers/block/rbd.c > @@ -3887,7 +3887,7 @@ static void rbd_reregister_watch(struct work_struct *work) > > ret = rbd_dev_refresh(rbd_dev); > if (ret) > - rbd_warn(rbd_dev, "reregisteration refresh failed: %d", ret); > + rbd_warn(rbd_dev, "re-registration refresh failed: %d", ret); Hmmm, I am not sure is that a spelling mistake, because the function name is rbd_reregister_watch(). Thanx Yang > } > > /* -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 20/03/18 10:35, Dongsheng Yang wrote: > Hi Colin, > > On 03/19/2018 09:33 PM, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> Trivial fix to spelling mistake in rdb_warn message text >> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> --- >> drivers/block/rbd.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c >> index 1e03b04819c8..7b97240ff15e 100644 >> --- a/drivers/block/rbd.c >> +++ b/drivers/block/rbd.c >> @@ -3887,7 +3887,7 @@ static void rbd_reregister_watch(struct >> work_struct *work) >> ret = rbd_dev_refresh(rbd_dev); >> if (ret) >> - rbd_warn(rbd_dev, "reregisteration refresh failed: %d", ret); >> + rbd_warn(rbd_dev, "re-registrationrefresh failed: %d", ret); > > Hmmm, I am not sure is that a spelling mistake, because the function > name is rbd_reregister_watch(). OK, well reregisteration should be reregistration then. Colin > > Thanx > Yang >> } >> /* > > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Mar 20, 2018 at 11:39 AM, Colin Ian King <colin.king@canonical.com> wrote: > On 20/03/18 10:35, Dongsheng Yang wrote: >> Hi Colin, >> >> On 03/19/2018 09:33 PM, Colin King wrote: >>> From: Colin Ian King <colin.king@canonical.com> >>> >>> Trivial fix to spelling mistake in rdb_warn message text >>> >>> Signed-off-by: Colin Ian King <colin.king@canonical.com> >>> --- >>> drivers/block/rbd.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c >>> index 1e03b04819c8..7b97240ff15e 100644 >>> --- a/drivers/block/rbd.c >>> +++ b/drivers/block/rbd.c >>> @@ -3887,7 +3887,7 @@ static void rbd_reregister_watch(struct >>> work_struct *work) >>> ret = rbd_dev_refresh(rbd_dev); >>> if (ret) >>> - rbd_warn(rbd_dev, "reregisteration refresh failed: %d", ret); >>> + rbd_warn(rbd_dev, "re-registrationrefresh failed: %d", ret); >> >> Hmmm, I am not sure is that a spelling mistake, because the function >> name is rbd_reregister_watch(). > > OK, well reregisteration should be reregistration then. I went ahead and applied the change to "reregistration". Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index 1e03b04819c8..7b97240ff15e 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -3887,7 +3887,7 @@ static void rbd_reregister_watch(struct work_struct *work) ret = rbd_dev_refresh(rbd_dev); if (ret) - rbd_warn(rbd_dev, "reregisteration refresh failed: %d", ret); + rbd_warn(rbd_dev, "re-registration refresh failed: %d", ret); } /*