| Message ID | 1521518336-5467-5-git-send-email-sricharan@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Quoting Sricharan R (2018-03-19 20:58:47) > Reviewed-by: Abhishek Sahu <absahu@codeaurora.org> That is an odd place for a reviewed-by tag. > Adds missing memory, reserved-memory nodes. > > Signed-off-by: Sricharan R <sricharan@codeaurora.org> > --- > arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi | 28 +++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi b/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi > index e413b21e..ad0fbc9 100644 > --- a/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi > @@ -20,6 +20,34 @@ > model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK01.1"; > compatible = "qcom,ipq4019"; > > + memory { > + device_type = "memory"; > + reg = <0x80000000 0x10000000>; /* 256MB */ > + }; > + > + reserved-memory { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + rsvd1@87000000 { > + /* Reserved for other subsystem */ > + reg = <0x87000000 0x500000>; > + no-map; > + }; > + > + wifi_dump@87500000 { > + reg = <0x87500000 0x600000>; > + no-map; > + }; > + > + rsvd2@87B00000 { Lowercase hex please. > + /* Reserved for other subsystem */ > + reg = <0x87B00000 0x500000>; > + no-map; > + }; > + };
Hi Stephen, On 2018-03-20 13:03, Stephen Boyd wrote: > Quoting Sricharan R (2018-03-19 20:58:47) >> Reviewed-by: Abhishek Sahu <absahu@codeaurora.org> > > That is an odd place for a reviewed-by tag. > oops, by mistake. will fix. >> Adds missing memory, reserved-memory nodes. >> >> Signed-off-by: Sricharan R <sricharan@codeaurora.org> >> --- >> arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi | 28 >> +++++++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> >> diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi >> b/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi >> index e413b21e..ad0fbc9 100644 >> --- a/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi >> +++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi >> @@ -20,6 +20,34 @@ >> model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK01.1"; >> compatible = "qcom,ipq4019"; >> >> + memory { >> + device_type = "memory"; >> + reg = <0x80000000 0x10000000>; /* 256MB */ >> + }; >> + >> + reserved-memory { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + >> + rsvd1@87000000 { >> + /* Reserved for other subsystem */ >> + reg = <0x87000000 0x500000>; >> + no-map; >> + }; >> + >> + wifi_dump@87500000 { >> + reg = <0x87500000 0x600000>; >> + no-map; >> + }; >> + >> + rsvd2@87B00000 { > > Lowercase hex please. ok. Regards, Sricharan
On Tue, Mar 20, 2018 at 09:28:47AM +0530, Sricharan R wrote: > Reviewed-by: Abhishek Sahu <absahu@codeaurora.org> > Adds missing memory, reserved-memory nodes. > > Signed-off-by: Sricharan R <sricharan@codeaurora.org> > --- > arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi | 28 +++++++++++++++++++++++++++ Q: Does mainline Linux even boot on the DK? A: No, it doesn't. Please add the missing basic board support before hacking random stuff into the DTS. Thanks, Richard
On 2018-03-20 20:01, Richard Cochran wrote: > On Tue, Mar 20, 2018 at 09:28:47AM +0530, Sricharan R wrote: >> Reviewed-by: Abhishek Sahu <absahu@codeaurora.org> >> Adds missing memory, reserved-memory nodes. >> >> Signed-off-by: Sricharan R <sricharan@codeaurora.org> >> --- >> arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi | 28 >> +++++++++++++++++++++++++++ > > Q: Does mainline Linux even boot on the DK? > > A: No, it doesn't. Yes, i saw that it was booting out of mainline. Both DK01 and DK04 boards boots out of mainline. cat /proc/version Linux version 4.16.0-rc6 (srichara@srichara-linux) (gcc version 6.3.1 20170109 (Linaro GCC 6.3-2017.02)) #1677 SMP PREEMPT Wed Mar 21 12:58:14 IST 2018 If it does not boot for you, then can you check if your bootloader is passing this bootarg ? bootargs=console=ttyMSM0,115200n8 This is the only one required from bootloader to boot. That said, there should have been a default 'chosen' node in DTS for the serial console atleast which is not there today. I will add this in my v4 along with other changes. Regards, Sricharan > > Please add the missing basic board support before hacking random stuff > into the DTS. >
On Wed, Mar 21, 2018 at 02:40:43PM +0530, sricharan@codeaurora.org wrote: > Yes, i saw that it was booting out of mainline. > Both DK01 and DK04 boards boots out of mainline. Well, that is good news. Which kernel config did you use? Thanks, Richard
On 2018-03-21 20:37, Richard Cochran wrote: > On Wed, Mar 21, 2018 at 02:40:43PM +0530, sricharan@codeaurora.org > wrote: >> Yes, i saw that it was booting out of mainline. >> Both DK01 and DK04 boards boots out of mainline. > > Well, that is good news. > > Which kernel config did you use? qcom_defconfig. Meanwhile i just posted a v4 (CCed you), is it possible that i can have test feedback ? . That will be great. Regards, Sricharan
On Thu, Mar 22, 2018 at 06:35:48PM +0530, sricharan@codeaurora.org wrote: > Meanwhile i just posted a v4 (CCed you), is it possible that > i can have test feedback ? . That will be great. I don't have any DK in hand, but I do have a custom design most similar to the DK7. I'll gladly try to boot it with your series. Just to be clear: You are running pure mainline with absolutely no out-of-tree patches or other modifications, right? Thanks, Richard
On 2018-03-23 03:02, Richard Cochran wrote: > On Thu, Mar 22, 2018 at 06:35:48PM +0530, sricharan@codeaurora.org > wrote: >> Meanwhile i just posted a v4 (CCed you), is it possible that >> i can have test feedback ? . That will be great. > > I don't have any DK in hand, but I do have a custom design most > similar to the DK7. I'll gladly try to boot it with your series. > > Just to be clear: You are running pure mainline with absolutely no > out-of-tree patches or other modifications, right? Yes, mainline (4.16-rc6), plus my patches, pushed it here as well [1] Btw, posted v5 to fix a minor thing that i missed earlier. [1] https://github.com/sricharanaz/kernel/tree/ipq_test Regards, Sricharan
On Tue, Mar 20, 2018 at 07:31:31AM -0700, Richard Cochran wrote: > On Tue, Mar 20, 2018 at 09:28:47AM +0530, Sricharan R wrote: > > Reviewed-by: Abhishek Sahu <absahu@codeaurora.org> > > Adds missing memory, reserved-memory nodes. > > > > Signed-off-by: Sricharan R <sricharan@codeaurora.org> > > --- > > arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi | 28 +++++++++++++++++++++++++++ > > Q: Does mainline Linux even boot on the DK? > > A: No, it doesn't. If you aren't actually testing/validating this specific board, how can you make a statement like this? Unless you have tested these specifically on this board, I'd appreciate not getting false information about what is or is not working. > > Please add the missing basic board support before hacking random stuff > into the DTS. Feel free to send your own contributions where you are adding the things that are important to you. Regards, Andy Gross
On Thu, Mar 29, 2018 at 09:37:15AM -0500, Andy Gross wrote: > > If you aren't actually testing/validating this specific board, how can you make > a statement like this? Unless you have tested these specifically on this board, > I'd appreciate not getting false information about what is or is not working. I tested qualcomm's 4.4 kernel from codeaurora, and *it* doesn't boot on the ipq4019. I apologize for making a misleading statement. I assumed that the ipq4019 DTSs were merged in not booting from the beginning. Sorry, Richard
On Thu, Mar 29, 2018 at 09:37:15AM -0500, Andy Gross wrote: > > Feel free to send your own contributions where you are adding the things that > are important to you. You can count on it. I am really happy that ipq4019 at least boots mainline. BTW is there any hope of getting a working mainline DTS for the ipq8062, ideally for the ap145_100 board? Thanks, Richard
On 2018-03-29 22:07, Richard Cochran wrote: > On Thu, Mar 29, 2018 at 09:37:15AM -0500, Andy Gross wrote: >> >> Feel free to send your own contributions where you are adding the >> things that >> are important to you. > > You can count on it. I am really happy that ipq4019 at least boots > mainline. > > BTW is there any hope of getting a working mainline DTS for the > ipq8062, ideally for the ap145_100 board? Yes, i will post another series for ipq806[2/4] updates and the corresponding boards after this. Regards, Sricharan
On Mon, Apr 02, 2018 at 03:28:47PM +0530, sricharan@codeaurora.org wrote: > Yes, i will post another series for ipq806[2/4] updates and the > corresponding > boards after this. I tried mainline on the ap148 using qcom_defconfig and the qcom-ipq8064-ap148.dtb, and it doesn't boot FYI. Thanks, Richard
On 2018-04-06 10:25, Richard Cochran wrote: > On Mon, Apr 02, 2018 at 03:28:47PM +0530, sricharan@codeaurora.org > wrote: >> Yes, i will post another series for ipq806[2/4] updates and the >> corresponding >> boards after this. > > I tried mainline on the ap148 using qcom_defconfig and the > qcom-ipq8064-ap148.dtb, and it doesn't boot FYI. > I tried booting mainline built with qcom_defconfig on ap148 and did boot. Not sure if your bootloader's bootarg is this, 'console=ttyMSM0,115200n8' ? root@(none):/# cat /proc/version Linux version 4.16.0 (srichara@srichara-linux) (gcc version 6.3.1 20170109 (Linaro GCC 6.3-2017.02)) #1691 SMP PREEMPT Fri Apr 6 15:30:45 IST 2018 root@(none):/# Regards, Sricharan
On Fri, Apr 06, 2018 at 06:35:49PM +0530, sricharan@codeaurora.org wrote: > I tried booting mainline built with qcom_defconfig on ap148 and > did boot. Not sure if your bootloader's bootarg is this, > 'console=ttyMSM0,115200n8' ? Yes, I think so. I'll double check it. Do you have any out-of-tree patches or special jumper settings? Thanks, Richard
On 2018-04-06 20:43, Richard Cochran wrote: > On Fri, Apr 06, 2018 at 06:35:49PM +0530, sricharan@codeaurora.org > wrote: >> I tried booting mainline built with qcom_defconfig on ap148 and >> did boot. Not sure if your bootloader's bootarg is this, >> 'console=ttyMSM0,115200n8' ? > > Yes, I think so. I'll double check it. > > Do you have any out-of-tree patches or special jumper settings? No out of tree patches or special jumper settings. I am booting the mainline kernel, ap148.dtb + ramfs. Regards, Sricharan
diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi b/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi index e413b21e..ad0fbc9 100644 --- a/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi +++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi @@ -20,6 +20,34 @@ model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK01.1"; compatible = "qcom,ipq4019"; + memory { + device_type = "memory"; + reg = <0x80000000 0x10000000>; /* 256MB */ + }; + + reserved-memory { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + rsvd1@87000000 { + /* Reserved for other subsystem */ + reg = <0x87000000 0x500000>; + no-map; + }; + + wifi_dump@87500000 { + reg = <0x87500000 0x600000>; + no-map; + }; + + rsvd2@87B00000 { + /* Reserved for other subsystem */ + reg = <0x87B00000 0x500000>; + no-map; + }; + }; + soc { rng@22000 { status = "ok";