| Message ID | 20180323182537.30784-1-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Reviewed-by: Shashank Sharma <shashank.sharma@intel.com> Regards Shashank On 3/23/2018 11:55 PM, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Since we may attempt to reconfigure SCDC when the sink has already been > disconnected we probably shouldn't scare the user with errors in dmesg > that are 100% expected in that case. Just leave it up to the caller > whether to print an error message or not, and just output debug > messages from the helper itself. > > Cc: Shashank Sharma <shashank.sharma@intel.com> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/drm_scdc_helper.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c > index 657ea5ab6c3f..870e25f1f788 100644 > --- a/drivers/gpu/drm/drm_scdc_helper.c > +++ b/drivers/gpu/drm/drm_scdc_helper.c > @@ -141,7 +141,7 @@ bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter) > > ret = drm_scdc_readb(adapter, SCDC_SCRAMBLER_STATUS, &status); > if (ret < 0) { > - DRM_ERROR("Failed to read scrambling status: %d\n", ret); > + DRM_DEBUG_KMS("Failed to read scrambling status: %d\n", ret); > return false; > } > > @@ -168,7 +168,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) > > ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); > if (ret < 0) { > - DRM_ERROR("Failed to read TMDS config: %d\n", ret); > + DRM_DEBUG_KMS("Failed to read TMDS config: %d\n", ret); > return false; > } > > @@ -179,7 +179,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) > > ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config); > if (ret < 0) { > - DRM_ERROR("Failed to enable scrambling: %d\n", ret); > + DRM_DEBUG_KMS("Failed to enable scrambling: %d\n", ret); > return false; > } > > @@ -223,7 +223,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) > > ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); > if (ret < 0) { > - DRM_ERROR("Failed to read TMDS config: %d\n", ret); > + DRM_DEBUG_KMS("Failed to read TMDS config: %d\n", ret); > return false; > } > > @@ -234,7 +234,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) > > ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config); > if (ret < 0) { > - DRM_ERROR("Failed to set TMDS clock ratio: %d\n", ret); > + DRM_DEBUG_KMS("Failed to set TMDS clock ratio: %d\n", ret); > return false; > } >
On Fri, Mar 23, 2018 at 11:53:47PM -0000, Patchwork wrote: > == Series Details == > > Series: drm/scdc-helper: Convert errors into debug messages > URL : https://patchwork.freedesktop.org/series/40591/ > State : failure > > == Summary == > > ---- Possible new issues: > > Test kms_chv_cursor_fail: > Subgroup pipe-c-128x128-top-edge: > pass -> FAIL (shard-apl) Unrelated cursor crc fail (kms_chv_cursor_fail:1617) DEBUG: Checking CRCs: [0] [1] CRC mismatch at index 0: 0x4f96bc87 != 0x70b9fd52 > > ---- Known issues: > > Test kms_cursor_crc: > Subgroup cursor-256x256-suspend: > pass -> INCOMPLETE (shard-hsw) fdo#103375 > Test kms_flip: > Subgroup 2x-plain-flip-fb-recreate-interruptible: > fail -> PASS (shard-hsw) fdo#100368 +3 > Subgroup modeset-vs-vblank-race-interruptible: > pass -> FAIL (shard-hsw) fdo#103060 > Test kms_sysfs_edid_timing: > warn -> PASS (shard-apl) fdo#100047 > > fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375 > fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368 > fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060 > fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047 > > shard-apl total:3484 pass:1820 dwarn:1 dfail:0 fail:8 skip:1655 time:12986s > shard-hsw total:3450 pass:1753 dwarn:1 dfail:0 fail:3 skip:1691 time:11281s > shard-snb total:3484 pass:1363 dwarn:1 dfail:0 fail:3 skip:2117 time:7010s > Blacklisted hosts: > shard-kbl total:3484 pass:1945 dwarn:1 dfail:1 fail:9 skip:1528 time:9848s > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8481/shards.html
On Sat, Mar 24, 2018 at 08:35:43AM +0530, Sharma, Shashank wrote: > Reviewed-by: Shashank Sharma <shashank.sharma@intel.com> Thanks. Pushed to drm-misc-next. > > Regards > Shashank > On 3/23/2018 11:55 PM, Ville Syrjala wrote: > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > Since we may attempt to reconfigure SCDC when the sink has already been > > disconnected we probably shouldn't scare the user with errors in dmesg > > that are 100% expected in that case. Just leave it up to the caller > > whether to print an error message or not, and just output debug > > messages from the helper itself. > > > > Cc: Shashank Sharma <shashank.sharma@intel.com> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > --- > > drivers/gpu/drm/drm_scdc_helper.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c > > index 657ea5ab6c3f..870e25f1f788 100644 > > --- a/drivers/gpu/drm/drm_scdc_helper.c > > +++ b/drivers/gpu/drm/drm_scdc_helper.c > > @@ -141,7 +141,7 @@ bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter) > > > > ret = drm_scdc_readb(adapter, SCDC_SCRAMBLER_STATUS, &status); > > if (ret < 0) { > > - DRM_ERROR("Failed to read scrambling status: %d\n", ret); > > + DRM_DEBUG_KMS("Failed to read scrambling status: %d\n", ret); > > return false; > > } > > > > @@ -168,7 +168,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) > > > > ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); > > if (ret < 0) { > > - DRM_ERROR("Failed to read TMDS config: %d\n", ret); > > + DRM_DEBUG_KMS("Failed to read TMDS config: %d\n", ret); > > return false; > > } > > > > @@ -179,7 +179,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) > > > > ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config); > > if (ret < 0) { > > - DRM_ERROR("Failed to enable scrambling: %d\n", ret); > > + DRM_DEBUG_KMS("Failed to enable scrambling: %d\n", ret); > > return false; > > } > > > > @@ -223,7 +223,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) > > > > ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); > > if (ret < 0) { > > - DRM_ERROR("Failed to read TMDS config: %d\n", ret); > > + DRM_DEBUG_KMS("Failed to read TMDS config: %d\n", ret); > > return false; > > } > > > > @@ -234,7 +234,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) > > > > ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config); > > if (ret < 0) { > > - DRM_ERROR("Failed to set TMDS clock ratio: %d\n", ret); > > + DRM_DEBUG_KMS("Failed to set TMDS clock ratio: %d\n", ret); > > return false; > > } > >
diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c index 657ea5ab6c3f..870e25f1f788 100644 --- a/drivers/gpu/drm/drm_scdc_helper.c +++ b/drivers/gpu/drm/drm_scdc_helper.c @@ -141,7 +141,7 @@ bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter) ret = drm_scdc_readb(adapter, SCDC_SCRAMBLER_STATUS, &status); if (ret < 0) { - DRM_ERROR("Failed to read scrambling status: %d\n", ret); + DRM_DEBUG_KMS("Failed to read scrambling status: %d\n", ret); return false; } @@ -168,7 +168,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); if (ret < 0) { - DRM_ERROR("Failed to read TMDS config: %d\n", ret); + DRM_DEBUG_KMS("Failed to read TMDS config: %d\n", ret); return false; } @@ -179,7 +179,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config); if (ret < 0) { - DRM_ERROR("Failed to enable scrambling: %d\n", ret); + DRM_DEBUG_KMS("Failed to enable scrambling: %d\n", ret); return false; } @@ -223,7 +223,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); if (ret < 0) { - DRM_ERROR("Failed to read TMDS config: %d\n", ret); + DRM_DEBUG_KMS("Failed to read TMDS config: %d\n", ret); return false; } @@ -234,7 +234,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config); if (ret < 0) { - DRM_ERROR("Failed to set TMDS clock ratio: %d\n", ret); + DRM_DEBUG_KMS("Failed to set TMDS clock ratio: %d\n", ret); return false; }