diff mbox

[3/3] drm: make drm_core_check_feature() bool that it is

Message ID 20180327204722.31246-3-jani.nikula@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jani Nikula March 27, 2018, 8:47 p.m. UTC 
Bool is the more appropriate return type here, use it.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 include/drm/drmP.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Chris Wilson March 27, 2018, 8:59 p.m. UTC | #1 
Quoting Jani Nikula (2018-03-27 21:47:22)
> Bool is the more appropriate return type here, use it.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

All 3,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
Jani Nikula March 28, 2018, 6:36 a.m. UTC | #2 
On Tue, 27 Mar 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2018-03-27 21:47:22)
>> Bool is the more appropriate return type here, use it.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> All 3,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Thanks, all pushed to drm-misc-next.

BR,
Jani.
diff mbox

Patch

diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index b5d52a3d7d19..f5099c12c6a6 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -115,9 +115,9 @@  static inline bool drm_drv_uses_atomic_modeset(struct drm_device *dev)
 #define DRM_SWITCH_POWER_CHANGING 2
 #define DRM_SWITCH_POWER_DYNAMIC_OFF 3
 
-static inline int drm_core_check_feature(struct drm_device *dev, int feature)
+static inline bool drm_core_check_feature(struct drm_device *dev, int feature)
 {
-	return ((dev->driver->driver_features & feature) ? 1 : 0);
+	return dev->driver->driver_features & feature;
 }
 
 /* returns true if currently okay to sleep */