| Message ID | c8a655bc-ae35-2d4d-2b0f-2fd4535a9070@jp.fujitsu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 29.03.2018 11:22, Misono Tomohiro wrote: > "fi usage" shows the warning "RAID5/6 numbers will be incorrect" when > running without root privilege even if raid5/6 is not used. What > happens is it cannot get the per device profile usage info, so change > the message more appropriately. > > Reviewed-by: Qu Wenruo <wqu@suse.com> > Signed-off-by: Tomohiro Misono <misono.tomohiro@jp.fujitsu.com> > --- > cmds-fi-usage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cmds-fi-usage.c b/cmds-fi-usage.c > index de7ad668..f2307fe0 100644 > --- a/cmds-fi-usage.c > +++ b/cmds-fi-usage.c > @@ -629,7 +629,7 @@ int load_chunk_and_device_info(int fd, struct chunk_info **chunkinfo, > ret = load_chunk_info(fd, chunkinfo, chunkcount); > if (ret == -EPERM) { > warning( > -"cannot read detailed chunk info, RAID5/6 numbers will be incorrect, run as root"); > +"cannot read detailed chunk info. per device usage will not be shown, run as root"); ^^^ nit: New sentences must start with a capital letter :) > } else if (ret) { > return ret; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/cmds-fi-usage.c b/cmds-fi-usage.c index de7ad668..f2307fe0 100644 --- a/cmds-fi-usage.c +++ b/cmds-fi-usage.c @@ -629,7 +629,7 @@ int load_chunk_and_device_info(int fd, struct chunk_info **chunkinfo, ret = load_chunk_info(fd, chunkinfo, chunkcount); if (ret == -EPERM) { warning( -"cannot read detailed chunk info, RAID5/6 numbers will be incorrect, run as root"); +"cannot read detailed chunk info. per device usage will not be shown, run as root"); } else if (ret) { return ret; }