diff mbox

[v2,1/2] dt-bindings: arm: omap: dmm: Document new compatible for DRA7xx family

Message ID 20180322134206.22857-2-peter.ujfalusi@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Peter Ujfalusi March 22, 2018, 1:42 p.m. UTC
From: Tomi Valkeinen <tomi.valkeinen@ti.com>

Define unique compatible string for the DMM in DRA7xx family.

The new compatible can be used to apply DRA7xx specific workarounds for
ERRATAs, like i878 (MPU Lockup with concurrent DMM and EMIF accesses)

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 Documentation/devicetree/bindings/arm/omap/dmm.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Peter Ujfalusi March 23, 2018, 8:31 a.m. UTC | #1
On 2018-03-22 15:42, Peter Ujfalusi wrote:
> From: Tomi Valkeinen <tomi.valkeinen@ti.com>
> 
> Define unique compatible string for the DMM in DRA7xx family.
> 
> The new compatible can be used to apply DRA7xx specific workarounds for
> ERRATAs, like i878 (MPU Lockup with concurrent DMM and EMIF accesses)
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

I have failed to add:
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> ---
>  Documentation/devicetree/bindings/arm/omap/dmm.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/omap/dmm.txt b/Documentation/devicetree/bindings/arm/omap/dmm.txt
> index 8bd6d0a238a8..bbbe7cdba30c 100644
> --- a/Documentation/devicetree/bindings/arm/omap/dmm.txt
> +++ b/Documentation/devicetree/bindings/arm/omap/dmm.txt
> @@ -8,7 +8,8 @@ translation for initiators which need contiguous dma bus addresses.
>  
>  Required properties:
>  - compatible:	Should contain "ti,omap4-dmm" for OMAP4 family
> -		Should contain "ti,omap5-dmm" for OMAP5 and DRA7x family
> +		Should contain "ti,omap5-dmm" for OMAP5 family
> +		Should contain "ti,dra7-dmm" for DRA7xx family
>  - reg:		Contains DMM register address range (base address and length)
>  - interrupts:	Should contain an interrupt-specifier for DMM_IRQ.
>  - ti,hwmods:	Name of the hwmod associated to DMM, which is typically "dmm"
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Rob Herring (Arm) March 26, 2018, 10:24 p.m. UTC | #2
On Thu, Mar 22, 2018 at 03:42:05PM +0200, Peter Ujfalusi wrote:
> From: Tomi Valkeinen <tomi.valkeinen@ti.com>
> 
> Define unique compatible string for the DMM in DRA7xx family.
> 
> The new compatible can be used to apply DRA7xx specific workarounds for
> ERRATAs, like i878 (MPU Lockup with concurrent DMM and EMIF accesses)
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
>  Documentation/devicetree/bindings/arm/omap/dmm.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Rob Herring <robh@kernel.org>
Laurent Pinchart April 3, 2018, 8:44 p.m. UTC | #3
Hi Peter,

Thank you for the patch.

On Thursday, 22 March 2018 15:42:05 EEST Peter Ujfalusi wrote:
> From: Tomi Valkeinen <tomi.valkeinen@ti.com>
> 
> Define unique compatible string for the DMM in DRA7xx family.
> 
> The new compatible can be used to apply DRA7xx specific workarounds for
> ERRATAs, like i878 (MPU Lockup with concurrent DMM and EMIF accesses)
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  Documentation/devicetree/bindings/arm/omap/dmm.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/omap/dmm.txt
> b/Documentation/devicetree/bindings/arm/omap/dmm.txt index
> 8bd6d0a238a8..bbbe7cdba30c 100644
> --- a/Documentation/devicetree/bindings/arm/omap/dmm.txt
> +++ b/Documentation/devicetree/bindings/arm/omap/dmm.txt
> @@ -8,7 +8,8 @@ translation for initiators which need contiguous dma bus
> addresses.
> 
>  Required properties:
>  - compatible:	Should contain "ti,omap4-dmm" for OMAP4 family
> -		Should contain "ti,omap5-dmm" for OMAP5 and DRA7x family
> +		Should contain "ti,omap5-dmm" for OMAP5 family
> +		Should contain "ti,dra7-dmm" for DRA7xx family
>  - reg:		Contains DMM register address range (base address and length)
>  - interrupts:	Should contain an interrupt-specifier for DMM_IRQ.
>  - ti,hwmods:	Name of the hwmod associated to DMM, which is typically "dmm"
Laurent Pinchart April 3, 2018, 8:48 p.m. UTC | #4
Hi Peter,

On Friday, 23 March 2018 10:31:53 EEST Peter Ujfalusi wrote:
> On 2018-03-22 15:42, Peter Ujfalusi wrote:
> > From: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > 
> > Define unique compatible string for the DMM in DRA7xx family.
> > 
> > The new compatible can be used to apply DRA7xx specific workarounds for
> > ERRATAs, like i878 (MPU Lockup with concurrent DMM and EMIF accesses)
> > 
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> 
> I have failed to add:
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

That's not mandatory. The SoB line only serves to notify that you adhere to 
the developer's certificate of origin as documented in Documentation/process/
submitting-patches.rst. If you haven't modified this patch, and if you intend 
to get it picked from the mailing list (as opposed to getting it pulled from 
your tree), you don't need to add your SoB.

> > ---
> > 
> >  Documentation/devicetree/bindings/arm/omap/dmm.txt | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/omap/dmm.txt
> > b/Documentation/devicetree/bindings/arm/omap/dmm.txt index
> > 8bd6d0a238a8..bbbe7cdba30c 100644
> > --- a/Documentation/devicetree/bindings/arm/omap/dmm.txt
> > +++ b/Documentation/devicetree/bindings/arm/omap/dmm.txt
> > @@ -8,7 +8,8 @@ translation for initiators which need contiguous dma bus
> > addresses.> 
> >  Required properties:
> >  - compatible:	Should contain "ti,omap4-dmm" for OMAP4 family
> > 
> > -		Should contain "ti,omap5-dmm" for OMAP5 and DRA7x family
> > +		Should contain "ti,omap5-dmm" for OMAP5 family
> > +		Should contain "ti,dra7-dmm" for DRA7xx family
> > 
> >  - reg:		Contains DMM register address range (base address and length)
> >  - interrupts:	Should contain an interrupt-specifier for DMM_IRQ.
> >  - ti,hwmods:	Name of the hwmod associated to DMM, which is typically
> >  "dmm"
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/arm/omap/dmm.txt b/Documentation/devicetree/bindings/arm/omap/dmm.txt
index 8bd6d0a238a8..bbbe7cdba30c 100644
--- a/Documentation/devicetree/bindings/arm/omap/dmm.txt
+++ b/Documentation/devicetree/bindings/arm/omap/dmm.txt
@@ -8,7 +8,8 @@  translation for initiators which need contiguous dma bus addresses.
 
 Required properties:
 - compatible:	Should contain "ti,omap4-dmm" for OMAP4 family
-		Should contain "ti,omap5-dmm" for OMAP5 and DRA7x family
+		Should contain "ti,omap5-dmm" for OMAP5 family
+		Should contain "ti,dra7-dmm" for DRA7xx family
 - reg:		Contains DMM register address range (base address and length)
 - interrupts:	Should contain an interrupt-specifier for DMM_IRQ.
 - ti,hwmods:	Name of the hwmod associated to DMM, which is typically "dmm"