| Message ID | 12b6d82335f9b0ef03345d5ce51049f2c2bb9a2f.1522949748.git.mchehab@s-opensource.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Mauro, Thank you for the patch. On Thursday, 5 April 2018 20:54:03 EEST Mauro Carvalho Chehab wrote: > The isp_xclk_init_data const data isn't used anywere. > > drivers/media/platform/omap3isp/isp.c:294:35: warning: ‘isp_xclk_init_data’ > defined but not used [-Wunused-const-variable=] static const struct > clk_init_data isp_xclk_init_data = { > ^~~~~~~~~~~~~~~~~~ I believe you, no need for a compiler warning message to prove this :-) > Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> I really wonder why my compiler has never warned me. The problem has been there from the start :-/ You should add a fixes tag: Fixes: 9b28ee3c9122 ("[media] omap3isp: Use the common clock framework") Apart from that, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> I think Sakari is planning a pull request for the omap3isp driver so I'll let him handle this patch. > --- > drivers/media/platform/omap3isp/isp.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c > b/drivers/media/platform/omap3isp/isp.c index 2a11a709aa4f..9e4b5fb8a8b5 > 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -291,13 +291,6 @@ static const struct clk_ops isp_xclk_ops = { > > static const char *isp_xclk_parent_name = "cam_mclk"; > > -static const struct clk_init_data isp_xclk_init_data = { > - .name = "cam_xclk", > - .ops = &isp_xclk_ops, > - .parent_names = &isp_xclk_parent_name, > - .num_parents = 1, > -}; > - > static struct clk *isp_xclk_src_get(struct of_phandle_args *clkspec, void > *data) { > unsigned int idx = clkspec->args[0];
diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 2a11a709aa4f..9e4b5fb8a8b5 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -291,13 +291,6 @@ static const struct clk_ops isp_xclk_ops = { static const char *isp_xclk_parent_name = "cam_mclk"; -static const struct clk_init_data isp_xclk_init_data = { - .name = "cam_xclk", - .ops = &isp_xclk_ops, - .parent_names = &isp_xclk_parent_name, - .num_parents = 1, -}; - static struct clk *isp_xclk_src_get(struct of_phandle_args *clkspec, void *data) { unsigned int idx = clkspec->args[0];
The isp_xclk_init_data const data isn't used anywere. drivers/media/platform/omap3isp/isp.c:294:35: warning: ‘isp_xclk_init_data’ defined but not used [-Wunused-const-variable=] static const struct clk_init_data isp_xclk_init_data = { ^~~~~~~~~~~~~~~~~~ Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> --- drivers/media/platform/omap3isp/isp.c | 7 ------- 1 file changed, 7 deletions(-)