diff mbox

[libdrm,v2,21/23] meson: build exynos by default

Message ID 20180404153818.26179-21-eric.engestrom@imgtec.com (mailing list archive)
State New, archived
Headers show

Commit Message

Eric Engestrom April 4, 2018, 3:38 p.m. UTC
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dylan Baker April 4, 2018, 9:10 p.m. UTC | #1
For exynos and omap, are they in active use anymore? I'm pretty sure that
development of omap (the hardware) stopped, and others have told me exynos has
stopped too. I also don't think there's any open source consumer, since there is
no mesa driver for either of these.

Dylan

Quoting Eric Engestrom (2018-04-04 08:38:16)
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index 24688535a329ac530c10..7b26977a9e84290fdd37 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -76,7 +76,7 @@ foreach d : [
>    ['nouveau', true, true],
>    ['vmwgfx', false, true],
>    ['omap', true, true],
> -  ['exynos', false, false],
> +  ['exynos', false, true],
>    ['freedreno', true, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
>    ['tegra', true, false],
>    ['vc4', false, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
> -- 
> Cheers,
>   Eric
>
Eric Engestrom April 5, 2018, 9:48 a.m. UTC | #2
On Wednesday, 2018-04-04 14:10:33 -0700, Dylan Baker wrote:
> For exynos and omap, are they in active use anymore? I'm pretty sure that
> development of omap (the hardware) stopped, and others have told me exynos has
> stopped too. I also don't think there's any open source consumer, since there is
> no mesa driver for either of these.

Happy to drop these enablement patches; I just like to have everything
possible built by default, but if these are dead I'm fine with leaving
them disabled by default.

> 
> Dylan
> 
> Quoting Eric Engestrom (2018-04-04 08:38:16)
> > Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> > ---
> >  meson.build | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meson.build b/meson.build
> > index 24688535a329ac530c10..7b26977a9e84290fdd37 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -76,7 +76,7 @@ foreach d : [
> >    ['nouveau', true, true],
> >    ['vmwgfx', false, true],
> >    ['omap', true, true],
> > -  ['exynos', false, false],
> > +  ['exynos', false, true],
> >    ['freedreno', true, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
> >    ['tegra', true, false],
> >    ['vc4', false, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
> > -- 
> > Cheers,
> >   Eric
> >
Dylan Baker April 5, 2018, 8:39 p.m. UTC | #3
Quoting Eric Engestrom (2018-04-05 02:48:50)
> On Wednesday, 2018-04-04 14:10:33 -0700, Dylan Baker wrote:
> > For exynos and omap, are they in active use anymore? I'm pretty sure that
> > development of omap (the hardware) stopped, and others have told me exynos has
> > stopped too. I also don't think there's any open source consumer, since there is
> > no mesa driver for either of these.
> 
> Happy to drop these enablement patches; I just like to have everything
> possible built by default, but if these are dead I'm fine with leaving
> them disabled by default.
> 

Yeah, I just don't know what the right thing is, it just seems like a bad idea
to enable something by default that never really got anywhere.

Dylan
diff mbox

Patch

diff --git a/meson.build b/meson.build
index 24688535a329ac530c10..7b26977a9e84290fdd37 100644
--- a/meson.build
+++ b/meson.build
@@ -76,7 +76,7 @@  foreach d : [
   ['nouveau', true, true],
   ['vmwgfx', false, true],
   ['omap', true, true],
-  ['exynos', false, false],
+  ['exynos', false, true],
   ['freedreno', true, ['arm', 'aarch64'].contains(host_machine.cpu_family())],
   ['tegra', true, false],
   ['vc4', false, ['arm', 'aarch64'].contains(host_machine.cpu_family())],