| Message ID | 1522946544-11524-1-git-send-email-gaurav.k.singh@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 2018-04-05 at 22:12 +0530, Gaurav K Singh wrote: > On Apollolake, with stress test warm reboot, audio card > was not getting enumerated after reboot. This was a > spurious issue happening on Apollolake. HW codec and > HD audio controller link was going out of sync for which > there was a fix in i915 driver but was not getting invoked > for BXT. Extending this fix to BXT as well. > > Tested on apollolake chromebook by stress test warm reboot > with 2500 iterations. > > Bspec: 21829 > R-B stands. Btw, it would be easier to spot this patch and pick this up for merging if you did not send this as a reply. I guess that's okay this time? Also, a minor nitpick, "drm/i915/audio" would have been a more appropriate prefix for the patch subject. > Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com> > Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> > --- > drivers/gpu/drm/i915/intel_audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c > index 709d6ca68074..656f6c931341 100644 > --- a/drivers/gpu/drm/i915/intel_audio.c > +++ b/drivers/gpu/drm/i915/intel_audio.c > @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev, > struct drm_i915_private *dev_priv = kdev_to_i915(kdev); > u32 tmp; > > - if (!IS_GEN9_BC(dev_priv)) > + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) > return; > > i915_audio_component_get_power(kdev);
On Thu, 05 Apr 2018, "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com> wrote: > On Thu, 2018-04-05 at 22:12 +0530, Gaurav K Singh wrote: >> On Apollolake, with stress test warm reboot, audio card >> was not getting enumerated after reboot. This was a >> spurious issue happening on Apollolake. HW codec and >> HD audio controller link was going out of sync for which >> there was a fix in i915 driver but was not getting invoked >> for BXT. Extending this fix to BXT as well. >> >> Tested on apollolake chromebook by stress test warm reboot >> with 2500 iterations. >> >> Bspec: 21829 >> > > R-B stands. > > Btw, it would be easier to spot this patch and pick this up for merging > if you did not send this as a reply. I guess that's okay this time? > Also, a minor nitpick, "drm/i915/audio" would have been a more > appropriate prefix for the patch subject. Thanks for the patch and review, pushed to dinq, with the patch title amended. Immediately after pushing I realized that this should have been Cc: stable. Joonas, after v4.17-rc1 is out and you've rebased drm-intel-fixes on it, please cherry-pick this one with Cc: stable added. Thanks, Jani. > > > >> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com> >> Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> >> --- >> drivers/gpu/drm/i915/intel_audio.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c >> index 709d6ca68074..656f6c931341 100644 >> --- a/drivers/gpu/drm/i915/intel_audio.c >> +++ b/drivers/gpu/drm/i915/intel_audio.c >> @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev, >> struct drm_i915_private *dev_priv = kdev_to_i915(kdev); >> u32 tmp; >> >> - if (!IS_GEN9_BC(dev_priv)) >> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) >> return; >> >> i915_audio_component_get_power(kdev);
diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 709d6ca68074..656f6c931341 100644 --- a/drivers/gpu/drm/i915/intel_audio.c +++ b/drivers/gpu/drm/i915/intel_audio.c @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev, struct drm_i915_private *dev_priv = kdev_to_i915(kdev); u32 tmp; - if (!IS_GEN9_BC(dev_priv)) + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) return; i915_audio_component_get_power(kdev);