| Message ID | 20180406075222.7358-1-jthumshirn@suse.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Fri, 2018-04-06 at 09:52 +0200, Johannes Thumshirn wrote: > The host byte has to be shifted by 16 not 6. > > Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> > --- > drivers/scsi/qla2xxx/qla_isr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c > index 89f93ebd819d..49d67e1d571f 100644 > --- a/drivers/scsi/qla2xxx/qla_isr.c > +++ b/drivers/scsi/qla2xxx/qla_isr.c > @@ -2368,7 +2368,7 @@ qla25xx_process_bidir_status_iocb(scsi_qla_host_t *vha, void *pkt, > bsg_job->reply_len = sizeof(struct fc_bsg_reply); > /* Always return DID_OK, bsg will send the vendor specific response > * in this case only */ > - sp->done(sp, DID_OK << 6); > + sp->done(sp, DID_OK << 16); > > } Please mention in the description of this patch that this patch does not change any functionality because DID_OK == 0. Anyway: Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
On Fri, 2018-04-06 at 09:52 +0200, Johannes Thumshirn wrote: > The host byte has to be shifted by 16 not 6. > > Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> > --- > drivers/scsi/qla2xxx/qla_isr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c > index 89f93ebd819d..49d67e1d571f 100644 > --- a/drivers/scsi/qla2xxx/qla_isr.c > +++ b/drivers/scsi/qla2xxx/qla_isr.c > @@ -2368,7 +2368,7 @@ qla25xx_process_bidir_status_iocb(scsi_qla_host_t *vha, void *pkt, > bsg_job->reply_len = sizeof(struct fc_bsg_reply); > /* Always return DID_OK, bsg will send the vendor specific response > * in this case only */ > - sp->done(sp, DID_OK << 6); > + sp->done(sp, DID_OK << 16); > > } Hello Johannes, Had you noticed the following statements? I think the "<< 1" should be removed from these statements. $ git grep 'SAM_STAT.*<< 1' drivers/scsi/qla2xxx/qla_isr.c: cmd->result |= SAM_STAT_CHECK_CONDITION << 1; drivers/scsi/qla2xxx/qla_isr.c: cmd->result |= SAM_STAT_CHECK_CONDITION << 1; drivers/scsi/qla2xxx/qla_isr.c: cmd->result |= SAM_STAT_CHECK_CONDITION << 1; Thanks, Bart.
On Fri, Apr 06, 2018 at 03:01:20PM +0000, Bart Van Assche wrote: > Please mention in the description of this patch that this patch does not > change any functionality because DID_OK == 0. Anyway: > > Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com> I'll do. Thanks for the review.
On Fri, Apr 06, 2018 at 03:33:30PM +0000, Bart Van Assche wrote: > On Fri, 2018-04-06 at 09:52 +0200, Johannes Thumshirn wrote: > > The host byte has to be shifted by 16 not 6. > > > > Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> > > --- > > drivers/scsi/qla2xxx/qla_isr.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c > > index 89f93ebd819d..49d67e1d571f 100644 > > --- a/drivers/scsi/qla2xxx/qla_isr.c > > +++ b/drivers/scsi/qla2xxx/qla_isr.c > > @@ -2368,7 +2368,7 @@ qla25xx_process_bidir_status_iocb(scsi_qla_host_t *vha, void *pkt, > > bsg_job->reply_len = sizeof(struct fc_bsg_reply); > > /* Always return DID_OK, bsg will send the vendor specific response > > * in this case only */ > > - sp->done(sp, DID_OK << 6); > > + sp->done(sp, DID_OK << 16); > > > > } > > Hello Johannes, > > Had you noticed the following statements? I think the "<< 1" should be removed > from these statements. > > $ git grep 'SAM_STAT.*<< 1' > drivers/scsi/qla2xxx/qla_isr.c: cmd->result |= SAM_STAT_CHECK_CONDITION << 1; > drivers/scsi/qla2xxx/qla_isr.c: cmd->result |= SAM_STAT_CHECK_CONDITION << 1; > drivers/scsi/qla2xxx/qla_isr.c: cmd->result |= SAM_STAT_CHECK_CONDITION << 1; Thanks for the heads up, but this will be a separate patch. Byte, Johannes
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index 89f93ebd819d..49d67e1d571f 100644 --- a/drivers/scsi/qla2xxx/qla_isr.c +++ b/drivers/scsi/qla2xxx/qla_isr.c @@ -2368,7 +2368,7 @@ qla25xx_process_bidir_status_iocb(scsi_qla_host_t *vha, void *pkt, bsg_job->reply_len = sizeof(struct fc_bsg_reply); /* Always return DID_OK, bsg will send the vendor specific response * in this case only */ - sp->done(sp, DID_OK << 6); + sp->done(sp, DID_OK << 16); }
The host byte has to be shifted by 16 not 6. Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> --- drivers/scsi/qla2xxx/qla_isr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)