| Message ID | c318fd1c9f79995c6c2e4e82ca99ff494b2afb7b.1523028795.git.mchehab@s-opensource.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Mauro, Thank you for the patch. On Friday, 6 April 2018 18:33:20 EEST Mauro Carvalho Chehab wrote: > The dependency of DRM_OMAP = n can be relaxed for just > compilation test. > > This allows building the omap3isp driver with allyesconfig > on ARM. omapfb has nothing to do with omap3isp. I assume you meant omap_vout. There's a reason why both DRM_OMAP and FB_OMAP2 can't be compiled at the same time, they export identical symbols. I believe you will end up with link failures if you do so. > Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> > --- > drivers/video/fbdev/omap2/omapfb/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/omap2/omapfb/Kconfig > b/drivers/video/fbdev/omap2/omapfb/Kconfig index e6226aeed17e..e42794a5e26c > 100644 > --- a/drivers/video/fbdev/omap2/omapfb/Kconfig > +++ b/drivers/video/fbdev/omap2/omapfb/Kconfig > @@ -4,7 +4,7 @@ config OMAP2_VRFB > menuconfig FB_OMAP2 > tristate "OMAP2+ frame buffer support" > depends on FB > - depends on DRM_OMAP = n > + depends on DRM_OMAP = n || COMPILE_TEST > > select FB_OMAP2_DSS > select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3
Em Sat, 07 Apr 2018 14:46:56 +0300 Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu: > Hi Mauro, > > Thank you for the patch. > > On Friday, 6 April 2018 18:33:20 EEST Mauro Carvalho Chehab wrote: > > The dependency of DRM_OMAP = n can be relaxed for just > > compilation test. > > > > This allows building the omap3isp driver with allyesconfig > > on ARM. > > omapfb has nothing to do with omap3isp. I assume you meant omap_vout. > > There's a reason why both DRM_OMAP and FB_OMAP2 can't be compiled at the same > time, they export identical symbols. I believe you will end up with link > failures if you do so. Ah, OK. I'll just drop this patch. Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/fbdev/omap2/omapfb/Kconfig b/drivers/video/fbdev/omap2/omapfb/Kconfig index e6226aeed17e..e42794a5e26c 100644 --- a/drivers/video/fbdev/omap2/omapfb/Kconfig +++ b/drivers/video/fbdev/omap2/omapfb/Kconfig @@ -4,7 +4,7 @@ config OMAP2_VRFB menuconfig FB_OMAP2 tristate "OMAP2+ frame buffer support" depends on FB - depends on DRM_OMAP = n + depends on DRM_OMAP = n || COMPILE_TEST select FB_OMAP2_DSS select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3
The dependency of DRM_OMAP = n can be relaxed for just compilation test. This allows building the omap3isp driver with allyesconfig on ARM. Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> --- drivers/video/fbdev/omap2/omapfb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)