diff mbox

[1/3] media: si2165: Remove owner assignment from i2c_driver

Message ID 1521900094-25876-1-git-send-email-festevam@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fabio Estevam March 24, 2018, 2:01 p.m. UTC 
From: Fabio Estevam <fabio.estevam@nxp.com>

Structure i2c_driver does not need to set the owner field, as this will
be populated by the driver core.

Generated by scripts/coccinelle/api/platform_no_drv_owner.cocci.

Cc: Matthias Schwarzott <zzam@gentoo.org>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 drivers/media/dvb-frontends/si2165.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Matthias Schwarzott April 8, 2018, 11:15 a.m. UTC | #1 
Thank you for sending this patch.

Am 24.03.2018 um 15:01 schrieb Fabio Estevam:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Structure i2c_driver does not need to set the owner field, as this will
> be populated by the driver core.
> 
> Generated by scripts/coccinelle/api/platform_no_drv_owner.cocci.
> 
> Cc: Matthias Schwarzott <zzam@gentoo.org>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  drivers/media/dvb-frontends/si2165.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/media/dvb-frontends/si2165.c
> index 2dd336f..d132e3c 100644
> --- a/drivers/media/dvb-frontends/si2165.c
> +++ b/drivers/media/dvb-frontends/si2165.c
> @@ -1299,7 +1299,6 @@ MODULE_DEVICE_TABLE(i2c, si2165_id_table);
>  
>  static struct i2c_driver si2165_driver = {
>  	.driver = {
> -		.owner	= THIS_MODULE,
>  		.name	= "si2165",
>  	},
>  	.probe		= si2165_probe,
> 

The change is fine.

Reviewed-by: Matthias Schwarzott <zzam@gentoo.org>
diff mbox

Patch

diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/media/dvb-frontends/si2165.c
index 2dd336f..d132e3c 100644
--- a/drivers/media/dvb-frontends/si2165.c
+++ b/drivers/media/dvb-frontends/si2165.c
@@ -1299,7 +1299,6 @@  MODULE_DEVICE_TABLE(i2c, si2165_id_table);
 
 static struct i2c_driver si2165_driver = {
 	.driver = {
-		.owner	= THIS_MODULE,
 		.name	= "si2165",
 	},
 	.probe		= si2165_probe,