| Message ID | 20180417100128.23011-3-nsekhar@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 04/17/2018 05:01 AM, Sekhar Nori wrote: > Add unit name for memory node to squash the W=1 warning: > > arch/arm/boot/dts/da850-lcdk.dtb: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name > > Signed-off-by: Sekhar Nori <nsekhar@ti.com> > --- > arch/arm/boot/dts/da850-lcdk.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts > index a1f4d6d5a569..e80839bb071b 100644 > --- a/arch/arm/boot/dts/da850-lcdk.dts > +++ b/arch/arm/boot/dts/da850-lcdk.dts > @@ -21,7 +21,7 @@ > stdout-path = "serial2:115200n8"; > }; > > - memory { > + memory@c0000000 { > device_type = "memory"; Should we drop `device_type = "memory";` since it is now specified in da850.dtsi? > reg = <0xc0000000 0x08000000>; I wouldn't mind a comment that says that this is 128MiB. The number is too big for me to do the hex in my head. :-) > }; >
On Tuesday 17 April 2018 10:25 PM, David Lechner wrote: > On 04/17/2018 05:01 AM, Sekhar Nori wrote: >> Add unit name for memory node to squash the W=1 warning: >> >> arch/arm/boot/dts/da850-lcdk.dtb: Warning (unit_address_vs_reg): >> /memory: node has a reg or ranges property, but no unit name >> >> Signed-off-by: Sekhar Nori <nsekhar@ti.com> >> --- >> arch/arm/boot/dts/da850-lcdk.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/da850-lcdk.dts >> b/arch/arm/boot/dts/da850-lcdk.dts >> index a1f4d6d5a569..e80839bb071b 100644 >> --- a/arch/arm/boot/dts/da850-lcdk.dts >> +++ b/arch/arm/boot/dts/da850-lcdk.dts >> @@ -21,7 +21,7 @@ >> stdout-path = "serial2:115200n8"; >> }; >> - memory { >> + memory@c0000000 { >> device_type = "memory"; > > Should we drop `device_type = "memory";` since it is now specified > in da850.dtsi? It was specified in skeleton.dtsi too, but good point. I will drop. > >> reg = <0xc0000000 0x08000000>; > > I wouldn't mind a comment that says that this is 128MiB. The number > is too big for me to do the hex in my head. :-) Sure :) Thanks, Sekhar
diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts index a1f4d6d5a569..e80839bb071b 100644 --- a/arch/arm/boot/dts/da850-lcdk.dts +++ b/arch/arm/boot/dts/da850-lcdk.dts @@ -21,7 +21,7 @@ stdout-path = "serial2:115200n8"; }; - memory { + memory@c0000000 { device_type = "memory"; reg = <0xc0000000 0x08000000>; };
Add unit name for memory node to squash the W=1 warning: arch/arm/boot/dts/da850-lcdk.dtb: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name Signed-off-by: Sekhar Nori <nsekhar@ti.com> --- arch/arm/boot/dts/da850-lcdk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)