| Message ID | 1523949504-6428-1-git-send-email-gaurav.k.singh@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 17 Apr 2018, Gaurav K Singh <gaurav.k.singh@intel.com> wrote: > On Geminilake, sometimes audio card is not getting > detected after reboot. This is a spurious issue happening on > Geminilake. HW codec and HD audio controller link was going > out of sync for which there was a fix in i915 driver but > was not getting invoked for GLK. Extending this fix to GLK as well. > > Tested by Du,Wenkai on GLK board. > > Bspec: 21829 > > v2: Instead of checking GEN9_BC, BXT and GLK macros, use IS_GEN9 macro > > Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com> > Reviewed-by: Jani Nikula <jani.nikula@intel.com> That Reviewed-by is jumping to conclusions I'm afraid. Giving review comments does not mean Reviewed-by. Only explicit Reviewed-by reply does. I can only say that this is the right approach *if* glk is to be covered here, but I have no data to actually say if that's the right thing to do. BR, Jani. > --- > drivers/gpu/drm/i915/intel_audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c > index 656f6c931341..3ea566f99450 100644 > --- a/drivers/gpu/drm/i915/intel_audio.c > +++ b/drivers/gpu/drm/i915/intel_audio.c > @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev, > struct drm_i915_private *dev_priv = kdev_to_i915(kdev); > u32 tmp; > > - if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) > + if (!IS_GEN9(dev_priv)) > return; > > i915_audio_component_get_power(kdev);
On 17/04/18 11:00, Patchwork wrote: > == Series Details == > > Series: drm/i915/audio: Fix audio detection issue on GLK (rev2) > URL : https://patchwork.freedesktop.org/series/41334/ > State : failure > > == Summary == > > = CI Bug Log - changes from CI_DRM_4058 -> Patchwork_8701 = > > == Summary - FAILURE == > > Serious unknown changes coming with Patchwork_8701 absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_8701, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > External URL: https://patchwork.freedesktop.org/api/1.0/series/41334/revisions/2/mbox/ > > == Possible new issues == > > Here are the unknown changes that may have been introduced in Patchwork_8701: > > === IGT changes === > > ==== Possible regressions ==== > > igt@gem_exec_suspend@basic-s3: > fi-ivb-3520m: PASS -> DMESG-WARN https://bugs.freedesktop.org/show_bug.cgi?id=106084 I re-queued the testing to get the shards. > > > ==== Warnings ==== > > igt@prime_vgem@basic-fence-flip: > fi-cnl-y3: SKIP -> PASS > > > == Known issues == > > Here are the changes found in Patchwork_8701 that come from known issues: > > === IGT changes === > > ==== Possible fixes ==== > > igt@debugfs_test@read_all_entries: > fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS > > igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b: > fi-bxt-dsi: INCOMPLETE (fdo#103927) -> PASS > > > fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713 > fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927 > > > == Participating hosts (35 -> 33) == > > Additional (1): fi-glk-1 > Missing (3): fi-ilk-m540 fi-cnl-psr fi-skl-6700hq > > > == Build changes == > > * Linux: CI_DRM_4058 -> Patchwork_8701 > > CI_DRM_4058: 241d827c86078c4709c00251d22ea8f7554e3e36 @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_4432: 8b77704db49167f7ebfd1c470d9c129d3b862cb6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_8701: 55226f577b074d07d717a4894646ead57dfd4cf2 @ git://anongit.freedesktop.org/gfx-ci/linux > piglit_4432: 93b35926a150e318439d2505901288594b3548f5 @ git://anongit.freedesktop.org/piglit > > > == Linux commits == > > 55226f577b07 drm/i915/audio: Fix audio detection issue on GLK > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8701/issues.html > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx >
On 4/17/2018 12:18 AM, Gaurav K Singh wrote: > On Geminilake, sometimes audio card is not getting > detected after reboot. This is a spurious issue happening on > Geminilake. HW codec and HD audio controller link was going > out of sync for which there was a fix in i915 driver but > was not getting invoked for GLK. Extending this fix to GLK as well. > > Tested by Du,Wenkai on GLK board. > > Bspec: 21829 > > v2: Instead of checking GEN9_BC, BXT and GLK macros, use IS_GEN9 macro > > Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com> > Reviewed-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Abhay Kumar <abhay.Kumar@intel.com> > --- > drivers/gpu/drm/i915/intel_audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c > index 656f6c931341..3ea566f99450 100644 > --- a/drivers/gpu/drm/i915/intel_audio.c > +++ b/drivers/gpu/drm/i915/intel_audio.c > @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev, > struct drm_i915_private *dev_priv = kdev_to_i915(kdev); > u32 tmp; > > - if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) > + if (!IS_GEN9(dev_priv)) > return; > > i915_audio_component_get_power(kdev);
diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 656f6c931341..3ea566f99450 100644 --- a/drivers/gpu/drm/i915/intel_audio.c +++ b/drivers/gpu/drm/i915/intel_audio.c @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev, struct drm_i915_private *dev_priv = kdev_to_i915(kdev); u32 tmp; - if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) + if (!IS_GEN9(dev_priv)) return; i915_audio_component_get_power(kdev);