| Message ID | 20180417144305.GA31337@jordon-HP-15-Notebook-PC (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Apr 17, 2018 at 08:13:06PM +0530, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler. For > now, this is just documenting that the function returns > a VM_FAULT value rather than an errno. Once all instances > are converted, vm_fault_t will become a distinct type. > > Reference id -> 1c8f422059ae ("mm: change return type to > vm_fault_t") > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> Subject should mention "videobuf"; videobuf is not part of V4L2 core (albeit the directory structure would certainly seem to suggest that). With that, Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
On Wed, Apr 18, 2018 at 2:38 PM, Sakari Ailus <sakari.ailus@iki.fi> wrote: > On Tue, Apr 17, 2018 at 08:13:06PM +0530, Souptick Joarder wrote: >> Use new return type vm_fault_t for fault handler. For >> now, this is just documenting that the function returns >> a VM_FAULT value rather than an errno. Once all instances >> are converted, vm_fault_t will become a distinct type. >> >> Reference id -> 1c8f422059ae ("mm: change return type to >> vm_fault_t") >> >> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > > Subject should mention "videobuf"; videobuf is not part of V4L2 core > (albeit the directory structure would certainly seem to suggest that). With > that, > > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> Thanks. I will update the subject and send v2.
diff --git a/drivers/media/v4l2-core/videobuf-dma-sg.c b/drivers/media/v4l2-core/videobuf-dma-sg.c index f412429..54257ea 100644 --- a/drivers/media/v4l2-core/videobuf-dma-sg.c +++ b/drivers/media/v4l2-core/videobuf-dma-sg.c @@ -435,7 +435,7 @@ static void videobuf_vm_close(struct vm_area_struct *vma) * now ...). Bounce buffers don't work very well for the data rates * video capture has. */ -static int videobuf_vm_fault(struct vm_fault *vmf) +static vm_fault_t videobuf_vm_fault(struct vm_fault *vmf) { struct vm_area_struct *vma = vmf->vma; struct page *page;
Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type. Reference id -> 1c8f422059ae ("mm: change return type to vm_fault_t") Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> --- drivers/media/v4l2-core/videobuf-dma-sg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.1