diff mbox

drm/i915/selftests: Don't use -ETIMEDOUT from inside a test

Message ID 20180417143204.10704-1-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Chris Wilson April 17, 2018, 2:32 p.m. UTC
-ETIMEDOUT is reserved in the selftests for use by igt_timeout, and the
errno is magically handled by the test runner to break from inside the
test loop without propagating back to userspace as a failure. So convert
the -ETIMEDOUT from wait_var_event_timeout() into another errno.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Joonas Lahtinen April 18, 2018, 9:11 a.m. UTC | #1
Quoting Chris Wilson (2018-04-17 17:32:04)
> -ETIMEDOUT is reserved in the selftests for use by igt_timeout, and the
> errno is magically handled by the test runner to break from inside the
> test loop without propagating back to userspace as a failure. So convert
> the -ETIMEDOUT from wait_var_event_timeout() into another errno.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c b/drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c
index 46580026c7fc..0a12e81a45dd 100644
--- a/drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c
+++ b/drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c
@@ -416,6 +416,7 @@  static int igt_wakeup(void *arg)
 		if (err) {
 			pr_err("Timed out waiting for %d remaining waiters\n",
 			       atomic_read(&done));
+			err = -ENXIO; /* -ETIMEDOUT is reserved */
 			break;
 		}