diff mbox

[2/2] drm/i915: Only build INTEL_GTT on 32-bit x86

Message ID 20180420195931.19470-2-ajax@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Adam Jackson April 20, 2018, 7:59 p.m. UTC
The i810 was attached to Pentium III motherboards, no 64-bit CPU is ever
going to have one.

Signed-off-by: Adam Jackson <ajax@redhat.com>
---
 drivers/gpu/drm/i915/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

kernel test robot April 23, 2018, 8:31 a.m. UTC | #1
Hi Adam,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v4.17-rc2 next-20180423]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Adam-Jackson/agp-intel-gtt-Drop-the-code-for-gen-1/20180423-090757
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-s4-04231106 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/gpu/drm/i915/i915_gem_execbuffer.o: In function `i915_gem_chipset_flush':
>> drivers/gpu/drm/i915/i915_drv.h:3522: undefined reference to `intel_gtt_chipset_flush'
>> drivers/gpu/drm/i915/i915_drv.h:3522: undefined reference to `intel_gtt_chipset_flush'
   drivers/gpu/drm/i915/i915_gem_gtt.o: In function `i915_gmch_probe':
>> drivers/gpu/drm/i915/i915_gem_gtt.c:3432: undefined reference to `intel_gmch_probe'
>> drivers/gpu/drm/i915/i915_gem_gtt.c:3438: undefined reference to `intel_gtt_get'
   drivers/gpu/drm/i915/i915_gem_gtt.o: In function `i915_ggtt_enable_hw':
>> drivers/gpu/drm/i915/i915_gem_gtt.c:3569: undefined reference to `intel_enable_gtt'
   drivers/gpu/drm/i915/i915_gem_gtt.o: In function `gmch_ggtt_invalidate':
>> drivers/gpu/drm/i915/i915_gem_gtt.c:127: undefined reference to `intel_gtt_chipset_flush'
   drivers/gpu/drm/i915/i915_gem_gtt.o: In function `i915_gmch_remove':
>> drivers/gpu/drm/i915/i915_gem_gtt.c:3423: undefined reference to `intel_gmch_remove'
   drivers/gpu/drm/i915/i915_gem_gtt.o: In function `i915_ggtt_clear_range':
>> drivers/gpu/drm/i915/i915_gem_gtt.c:2641: undefined reference to `intel_gtt_clear_range'
   drivers/gpu/drm/i915/i915_gem_gtt.o: In function `i915_ggtt_insert_entries':
>> drivers/gpu/drm/i915/i915_gem_gtt.c:2634: undefined reference to `intel_gtt_insert_sg_entries'
   drivers/gpu/drm/i915/i915_gem_gtt.o: In function `i915_ggtt_insert_page':
>> drivers/gpu/drm/i915/i915_gem_gtt.c:2623: undefined reference to `intel_gtt_insert_page'
   drivers/gpu/drm/i915/i915_gem.o: In function `i915_gem_chipset_flush':
>> drivers/gpu/drm/i915/i915_drv.h:3522: undefined reference to `intel_gtt_chipset_flush'
>> drivers/gpu/drm/i915/i915_drv.h:3522: undefined reference to `intel_gtt_chipset_flush'

vim +3522 drivers/gpu/drm/i915/i915_drv.h

7125397b Chris Wilson 2017-12-06  3516  
0260c420 Ben Widawsky 2014-03-22  3517  /* belongs in i915_gem_gtt.h */
c033666a Chris Wilson 2016-05-06  3518  static inline void i915_gem_chipset_flush(struct drm_i915_private *dev_priv)
e76e9aeb Ben Widawsky 2012-11-04  3519  {
600f4368 Chris Wilson 2016-08-18  3520  	wmb();
c033666a Chris Wilson 2016-05-06  3521  	if (INTEL_GEN(dev_priv) < 6)
e76e9aeb Ben Widawsky 2012-11-04 @3522  		intel_gtt_chipset_flush();
e76e9aeb Ben Widawsky 2012-11-04  3523  }
246cbfb5 Ben Widawsky 2013-12-06  3524  

:::::: The code at line 3522 was first introduced by commit
:::::: e76e9aebcdbfebae8f4cd147e3c0f800d36e97f3 drm/i915: Stop using AGP layer for GEN6+

:::::: TO: Ben Widawsky <ben@bwidawsk.net>
:::::: CC: Daniel Vetter <daniel.vetter@ffwll.ch>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
index dfd95889f4b7..0f2a98c9d5af 100644
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
@@ -2,7 +2,7 @@  config DRM_I915
 	tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics"
 	depends on DRM
 	depends on X86 && PCI
-	select INTEL_GTT
+	select INTEL_GTT if X86_32
 	select INTERVAL_TREE
 	# we need shmfs for the swappable backing store, and in particular
 	# the shmem_readpage() which depends upon tmpfs