| Message ID | 1522335300-13467-2-git-send-email-manivannan.sadhasivam@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 29 March 2018 at 16:55, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > Some of the camera subsystems like camss in Qualcommm MSM chipsets > require pixel clock support in camera sensor drivers. So, this commit > adds a default pixel clock rate of 96MHz to OV5640 camera sensor driver. > > According to the datasheet, 96MHz can be used as a pixel clock rate for > most of the modes. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Tested-by: Loic Poulain <loic.poulain@linaro.org> It works for me on Dragonboard 410c + D3 camera mezzanine (ov5640) . Any comments on this change? Regards, Loic
On Tue, Apr 24, 2018 at 11:01:18AM +0200, Loic Poulain wrote: > On 29 March 2018 at 16:55, Manivannan Sadhasivam > <manivannan.sadhasivam@linaro.org> wrote: > > Some of the camera subsystems like camss in Qualcommm MSM chipsets > > require pixel clock support in camera sensor drivers. So, this commit > > adds a default pixel clock rate of 96MHz to OV5640 camera sensor driver. > > > > According to the datasheet, 96MHz can be used as a pixel clock rate for > > most of the modes. > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > Tested-by: Loic Poulain <loic.poulain@linaro.org> > > It works for me on Dragonboard 410c + D3 camera mezzanine (ov5640) . > > Any comments on this change? <URL:https://patchwork.linuxtv.org/project/linux-media/list/?submitter=Maxime+Ripard&state=*&q=ov5640> There's also another set that adds PIXEL_CLOCK (as well as LINK_FREQ) support to the driver, that seems more complete than this patch but requires a rebase on Maxime's patches: <URL:https://patchwork.linuxtv.org/project/linux-media/list/?submitter=7218&state=*&q=ov5640>
Hi Sakari, >> Any comments on this change? > > <URL:https://patchwork.linuxtv.org/project/linux-media/list/?submitter=Maxime+Ripard&state=*&q=ov5640> > > There's also another set that adds PIXEL_CLOCK (as well as LINK_FREQ) > support to the driver, that seems more complete than this patch but > requires a rebase on Maxime's patches: > > <URL:https://patchwork.linuxtv.org/project/linux-media/list/?submitter=7218&state=*&q=ov5640> Thanks, I've just see this patch series. Indeed, patch will need a rework/rebase. Regards, Loic
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index 39a2269..7152c84 100644 --- a/drivers/media/i2c/ov5640.c +++ b/drivers/media/i2c/ov5640.c @@ -162,6 +162,7 @@ struct ov5640_ctrls { struct v4l2_ctrl *auto_gain; struct v4l2_ctrl *gain; }; + struct v4l2_ctrl *pixel_clock; struct v4l2_ctrl *brightness; struct v4l2_ctrl *saturation; struct v4l2_ctrl *contrast; @@ -2009,6 +2010,9 @@ static int ov5640_init_controls(struct ov5640_dev *sensor) ctrls->gain = v4l2_ctrl_new_std(hdl, ops, V4L2_CID_GAIN, 0, 1023, 1, 0); + /* Pixel clock (default of 96MHz) */ + ctrls->pixel_clock = v4l2_ctrl_new_std(hdl, ops, V4L2_CID_PIXEL_RATE, + 1, INT_MAX, 1, 96000000); ctrls->saturation = v4l2_ctrl_new_std(hdl, ops, V4L2_CID_SATURATION, 0, 255, 1, 64); ctrls->hue = v4l2_ctrl_new_std(hdl, ops, V4L2_CID_HUE,
Some of the camera subsystems like camss in Qualcommm MSM chipsets require pixel clock support in camera sensor drivers. So, this commit adds a default pixel clock rate of 96MHz to OV5640 camera sensor driver. According to the datasheet, 96MHz can be used as a pixel clock rate for most of the modes. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- drivers/media/i2c/ov5640.c | 4 ++++ 1 file changed, 4 insertions(+)