diff mbox

media: davinci: don't override the error code

Message ID f58d196d5d71450efab15afe01661923a3a7e28f.1524482537.git.mchehab@s-opensource.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mauro Carvalho Chehab April 23, 2018, 11:22 a.m. UTC 
As warned by Coverity:
	CID 1415211 (#1 of 1): Unused value (UNUSED_VALUE)assigned_value:
	Assigning value -22 to ret here, but that stored value is
	overwritten before it can be used.

On all cases where the there's a goto 'unlock_out' or 'streamof',
ret was filled with a non-sero value. It toesn't make sense to override
such error code with a videobuf_streamoff() error.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
 drivers/media/platform/davinci/vpfe_capture.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sakari Ailus April 24, 2018, 10:08 a.m. UTC | #1 
On Mon, Apr 23, 2018 at 07:22:19AM -0400, Mauro Carvalho Chehab wrote:
> As warned by Coverity:
> 	CID 1415211 (#1 of 1): Unused value (UNUSED_VALUE)assigned_value:
> 	Assigning value -22 to ret here, but that stored value is
> 	overwritten before it can be used.
> 
> On all cases where the there's a goto 'unlock_out' or 'streamof',
> ret was filled with a non-sero value. It toesn't make sense to override
> such error code with a videobuf_streamoff() error.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
diff mbox

Patch

diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c
index 6f44abf7fa31..8613358ed245 100644
--- a/drivers/media/platform/davinci/vpfe_capture.c
+++ b/drivers/media/platform/davinci/vpfe_capture.c
@@ -1509,7 +1509,7 @@  static int vpfe_streamon(struct file *file, void *priv,
 unlock_out:
 	mutex_unlock(&vpfe_dev->lock);
 streamoff:
-	ret = videobuf_streamoff(&vpfe_dev->buffer_queue);
+	videobuf_streamoff(&vpfe_dev->buffer_queue);
 	return ret;
 }