| Message ID | 20180415145237.789-1-hch@lst.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Johannes, can you take a look at this? You are one of the few persons who cared about SMP passthrough in the recent past. On Sun, Apr 15, 2018 at 04:52:37PM +0200, Christoph Hellwig wrote: > All three instance of ->smp_handler deal with highmem backed requests > just fine. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > drivers/scsi/scsi_transport_sas.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c > index 08acbabfae07..a22baf206071 100644 > --- a/drivers/scsi/scsi_transport_sas.c > +++ b/drivers/scsi/scsi_transport_sas.c > @@ -223,10 +223,6 @@ static int sas_bsg_initialize(struct Scsi_Host *shost, struct sas_rphy *rphy) > to_sas_host_attrs(shost)->q = q; > } > > - /* > - * by default assume old behaviour and bounce for any highmem page > - */ > - blk_queue_bounce_limit(q, BLK_BOUNCE_HIGH); > blk_queue_flag_set(QUEUE_FLAG_BIDI, q); > return 0; > } > -- > 2.17.0 ---end quoted text---
On Fri, Apr 27, 2018 at 07:24:18AM +0200, Christoph Hellwig wrote: > Johannes, > > can you take a look at this? You are one of the few persons who cared > about SMP passthrough in the recent past. I'm sitting at the airport currently, but as soon as I'm back in the office I'll have a look. Johannes
On Sun, Apr 15, 2018 at 04:52:37PM +0200, Christoph Hellwig wrote: > All three instance of ->smp_handler deal with highmem backed requests > just fine. That's my conclusion as well. Looks good, Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Christoph, > All three instance of ->smp_handler deal with highmem backed requests > just fine. Applied to 4.18/scsi-queue. Thanks!
diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c index 08acbabfae07..a22baf206071 100644 --- a/drivers/scsi/scsi_transport_sas.c +++ b/drivers/scsi/scsi_transport_sas.c @@ -223,10 +223,6 @@ static int sas_bsg_initialize(struct Scsi_Host *shost, struct sas_rphy *rphy) to_sas_host_attrs(shost)->q = q; } - /* - * by default assume old behaviour and bounce for any highmem page - */ - blk_queue_bounce_limit(q, BLK_BOUNCE_HIGH); blk_queue_flag_set(QUEUE_FLAG_BIDI, q); return 0; }
All three instance of ->smp_handler deal with highmem backed requests just fine. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/scsi/scsi_transport_sas.c | 4 ---- 1 file changed, 4 deletions(-)