diff mbox

[V2] ARM: dts: da850-evm: add WP and CD to MMC

Message ID 20180427022409.13105-1-aford173@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Adam Ford April 27, 2018, 2:24 a.m. UTC
The legacy mode uses the write protect and card detect but DT
has not.  This patch enables the pinmuxing and detection for
WP and CD.

Signed-off-by: Adam Ford <aford173@gmail.com>
---

V2:  Rebase on davinci master and remove GPIO pinmuxing

 arch/arm/boot/dts/da850-evm.dts | 2 ++
 1 file changed, 2 insertions(+)

Comments

Sekhar Nori May 1, 2018, 11:03 a.m. UTC | #1
On Friday 27 April 2018 07:54 AM, Adam Ford wrote:
> The legacy mode uses the write protect and card detect but DT
> has not.  This patch enables the pinmuxing and detection for
> WP and CD.

patch description should be readable without reference to headline. So
"MMC" should appear somewhere in the description too. Also, you are not
doing pinmuxing anymore. I think the reference to that should be dropped
or refer to the fact that this happening through gpio-ranges property.

> 
> Signed-off-by: Adam Ford <aford173@gmail.com>

Thanks,
Sekhar
diff mbox

Patch

diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
index 4c59dab3362e..a56d43d53ba1 100644
--- a/arch/arm/boot/dts/da850-evm.dts
+++ b/arch/arm/boot/dts/da850-evm.dts
@@ -107,6 +107,8 @@ 
 			status = "okay";
 			pinctrl-names = "default";
 			pinctrl-0 = <&mmc0_pins>;
+			cd-gpios = <&gpio 64 GPIO_ACTIVE_LOW>;
+			wp-gpios = <&gpio 65 GPIO_ACTIVE_HIGH>;
 		};
 		spi1: spi@30e000 {
 			status = "okay";