diff mbox

ARM: dts: logicpd-som-lv: Enable Touchscreen controller

Message ID 1522252295-17512-1-git-send-email-aford173@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Adam Ford March 28, 2018, 3:51 p.m. UTC 
The OMAP35 and DM3730 SOM-LV contains a TSC2004 touch screen
controller connected to I2C3. This patch adds support for this
controller.

Signed-off-by: Adam Ford <aford173@gmail.com>

Comments

Tony Lindgren May 1, 2018, 3:06 p.m. UTC | #1 
* Adam Ford <aford173@gmail.com> [180328 08:53]:
> The OMAP35 and DM3730 SOM-LV contains a TSC2004 touch screen
> controller connected to I2C3. This patch adds support for this
> controller.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>

Thanks applying into omap-for-v4.18/dt.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Adam Ford May 5, 2018, 1:25 a.m. UTC | #2 
On Tue, May 1, 2018 at 10:06 AM, Tony Lindgren <tony@atomide.com> wrote:
> * Adam Ford <aford173@gmail.com> [180328 08:53]:
>> The OMAP35 and DM3730 SOM-LV contains a TSC2004 touch screen
>> controller connected to I2C3. This patch adds support for this
>> controller.
>>
>> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> Thanks applying into omap-for-v4.18/dt.

I looked at 4.18/dt, but I am not sure it was applied correctly.  It
appears to be on i2c2 in the git repo, but it should be i2c3 according
to the patch.

adam
>
> Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren May 5, 2018, 7:40 p.m. UTC | #3 
* Adam Ford <aford173@gmail.com> [180505 01:27]:
> On Tue, May 1, 2018 at 10:06 AM, Tony Lindgren <tony@atomide.com> wrote:
> > * Adam Ford <aford173@gmail.com> [180328 08:53]:
> >> The OMAP35 and DM3730 SOM-LV contains a TSC2004 touch screen
> >> controller connected to I2C3. This patch adds support for this
> >> controller.
> >>
> >> Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > Thanks applying into omap-for-v4.18/dt.
> 
> I looked at 4.18/dt, but I am not sure it was applied correctly.  It
> appears to be on i2c2 in the git repo, but it should be i2c3 according
> to the patch.

Oops sorry about that. I remember one patch applied with fuzz.. I need
to stop applying fuzz patches unless I can test it myself.

Can you please send a fix on top of the branch above?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Adam Ford May 5, 2018, 11:42 p.m. UTC | #4 
On Sat, May 5, 2018 at 2:40 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Adam Ford <aford173@gmail.com> [180505 01:27]:
>> On Tue, May 1, 2018 at 10:06 AM, Tony Lindgren <tony@atomide.com> wrote:
>> > * Adam Ford <aford173@gmail.com> [180328 08:53]:
>> >> The OMAP35 and DM3730 SOM-LV contains a TSC2004 touch screen
>> >> controller connected to I2C3. This patch adds support for this
>> >> controller.
>> >>
>> >> Signed-off-by: Adam Ford <aford173@gmail.com>
>> >
>> > Thanks applying into omap-for-v4.18/dt.
>>
>> I looked at 4.18/dt, but I am not sure it was applied correctly.  It
>> appears to be on i2c2 in the git repo, but it should be i2c3 according
>> to the patch.
>
> Oops sorry about that. I remember one patch applied with fuzz.. I need
> to stop applying fuzz patches unless I can test it myself.
>
> Can you please send a fix on top of the branch above?

Do you want a patch that undoes the existing one and moves it, or are
you going to undo the patch and I'll patch it again once pulled?

adam
>
> Regards,
>
> Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren May 6, 2018, 4:52 p.m. UTC | #5 
* Adam Ford <aford173@gmail.com> [180505 23:44]:
> On Sat, May 5, 2018 at 2:40 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Adam Ford <aford173@gmail.com> [180505 01:27]:
> >> On Tue, May 1, 2018 at 10:06 AM, Tony Lindgren <tony@atomide.com> wrote:
> >> > * Adam Ford <aford173@gmail.com> [180328 08:53]:
> >> >> The OMAP35 and DM3730 SOM-LV contains a TSC2004 touch screen
> >> >> controller connected to I2C3. This patch adds support for this
> >> >> controller.
> >> >>
> >> >> Signed-off-by: Adam Ford <aford173@gmail.com>
> >> >
> >> > Thanks applying into omap-for-v4.18/dt.
> >>
> >> I looked at 4.18/dt, but I am not sure it was applied correctly.  It
> >> appears to be on i2c2 in the git repo, but it should be i2c3 according
> >> to the patch.
> >
> > Oops sorry about that. I remember one patch applied with fuzz.. I need
> > to stop applying fuzz patches unless I can test it myself.
> >
> > Can you please send a fix on top of the branch above?
> 
> Do you want a patch that undoes the existing one and moves it, or are
> you going to undo the patch and I'll patch it again once pulled?

I'd prefer just a fix against omap-for-v4.18/dt since I already
pushed it out and it's not a bug fix.

Thanks,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/logicpd-som-lv.dtsi b/arch/arm/boot/dts/logicpd-som-lv.dtsi
index a30ee9f..624f817 100644
--- a/arch/arm/boot/dts/logicpd-som-lv.dtsi
+++ b/arch/arm/boot/dts/logicpd-som-lv.dtsi
@@ -93,6 +93,25 @@ 
 
 &i2c3 {
 	clock-frequency = <400000>;
+
+	touchscreen: tsc2004@48 {
+		compatible = "ti,tsc2004";
+		reg = <0x48>;
+		vio-supply = <&vaux1>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&tsc2004_pins>;
+		interrupts-extended = <&gpio5 25 IRQ_TYPE_EDGE_RISING>; /* gpio 153 */
+
+		touchscreen-fuzz-x = <4>;
+		touchscreen-fuzz-y = <7>;
+		touchscreen-fuzz-pressure = <2>;
+		touchscreen-size-x = <4096>;
+		touchscreen-size-y = <4096>;
+		touchscreen-max-pressure = <2048>;
+
+		ti,x-plate-ohms = <280>;
+		ti,esd-recovery-timeout-ms = <8000>;
+	};
 };
 
 &mmc3 {
@@ -197,6 +216,12 @@ 
 			OMAP3_CORE1_IOPAD(0x21bc, PIN_INPUT | MUX_MODE0)        /* i2c1_sda.i2c1_sda */
 		>;
 	};
+
+	tsc2004_pins: pinmux_tsc2004_pins {
+		pinctrl-single,pins = <
+			OMAP3_CORE1_IOPAD(0x2186, PIN_INPUT | MUX_MODE4)	/* mcbsp4_dr.gpio_153 */
+		>;
+	};
 };
 
 &omap3_pmx_wkup {