| Message ID | 20180405115239.17370-1-peter.ujfalusi@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2018-04-05 14:52, Peter Ujfalusi wrote: > The board uses 26MHz oscillator for the twl4030 HFCLK. > This way we will not depend on the bootloader to configure the > CFG_BOOT:HFCLK_FREQ > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > --- > Hi, > > there might be other boards (all omap3 boards with twl4030?) which uses the same > setup, but I only have schematics for beagle-xm. > > In order for the driver to actually use the clock the > [PATCH] mfd: twl-core: Fix clock initialization > need to be applied. W/o the twl-core patch the clock is just ignored. > > Regards, > Peter > > arch/arm/boot/dts/omap3-beagle-xm.dts | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts > index 0349fcc9dc26..d80587de0bbf 100644 > --- a/arch/arm/boot/dts/omap3-beagle-xm.dts > +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts > @@ -30,6 +30,13 @@ > ethernet = ðernet; > }; > > + /* fixed 26MHz oscillator */ > + hfclk_26m: oscillator { > + #clock-cells = <0>; > + compatible = "fixed-clock"; > + clock-frequency = <26000000>; > + }; > + > leds { > compatible = "gpio-leds"; > > @@ -274,6 +281,9 @@ > interrupts = <7>; /* SYS_NIRQ cascaded to intc */ > interrupt-parent = <&intc>; > > + clocks = <&hfclk_26m>; > + clock-names = "fck"; I wonder if we should rename this to hfclk... The DT documentation does not mention it and afaik it is not specified in DT files either. After all it is the HFCLK clock for the twl4030. I'm fine keeping it as 'fck' but it looks a bit weird. > + > twl_audio: audio { > compatible = "ti,twl4030-audio"; > codec { > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 2018-04-05 16:15, Peter Ujfalusi wrote: > > > On 2018-04-05 14:52, Peter Ujfalusi wrote: >> The board uses 26MHz oscillator for the twl4030 HFCLK. >> This way we will not depend on the bootloader to configure the >> CFG_BOOT:HFCLK_FREQ >> >> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> >> --- >> Hi, >> >> there might be other boards (all omap3 boards with twl4030?) which uses the same >> setup, but I only have schematics for beagle-xm. >> >> In order for the driver to actually use the clock the >> [PATCH] mfd: twl-core: Fix clock initialization >> need to be applied. W/o the twl-core patch the clock is just ignored. >> >> Regards, >> Peter >> >> arch/arm/boot/dts/omap3-beagle-xm.dts | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts >> index 0349fcc9dc26..d80587de0bbf 100644 >> --- a/arch/arm/boot/dts/omap3-beagle-xm.dts >> +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts >> @@ -30,6 +30,13 @@ >> ethernet = ðernet; >> }; >> >> + /* fixed 26MHz oscillator */ >> + hfclk_26m: oscillator { >> + #clock-cells = <0>; >> + compatible = "fixed-clock"; >> + clock-frequency = <26000000>; >> + }; >> + >> leds { >> compatible = "gpio-leds"; >> >> @@ -274,6 +281,9 @@ >> interrupts = <7>; /* SYS_NIRQ cascaded to intc */ >> interrupt-parent = <&intc>; >> >> + clocks = <&hfclk_26m>; >> + clock-names = "fck"; > > I wonder if we should rename this to hfclk... > The DT documentation does not mention it and afaik it is not specified > in DT files either. > > After all it is the HFCLK clock for the twl4030. We should not as it would break compatibility with stable kernels where the code expects 'fck' and not hfclk. > > I'm fine keeping it as 'fck' but it looks a bit weird. > >> + >> twl_audio: audio { >> compatible = "ti,twl4030-audio"; >> codec { >> > > - Péter > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
* Peter Ujfalusi <peter.ujfalusi@ti.com> [180406 07:01]: > > > On 2018-04-05 16:15, Peter Ujfalusi wrote: > > > > > > On 2018-04-05 14:52, Peter Ujfalusi wrote: > >> The board uses 26MHz oscillator for the twl4030 HFCLK. > >> This way we will not depend on the bootloader to configure the > >> CFG_BOOT:HFCLK_FREQ > >> > >> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > >> --- > >> Hi, > >> > >> there might be other boards (all omap3 boards with twl4030?) which uses the same > >> setup, but I only have schematics for beagle-xm. > >> > >> In order for the driver to actually use the clock the > >> [PATCH] mfd: twl-core: Fix clock initialization > >> need to be applied. W/o the twl-core patch the clock is just ignored. > >> > >> Regards, > >> Peter > >> > >> arch/arm/boot/dts/omap3-beagle-xm.dts | 10 ++++++++++ > >> 1 file changed, 10 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts > >> index 0349fcc9dc26..d80587de0bbf 100644 > >> --- a/arch/arm/boot/dts/omap3-beagle-xm.dts > >> +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts > >> @@ -30,6 +30,13 @@ > >> ethernet = ðernet; > >> }; > >> > >> + /* fixed 26MHz oscillator */ > >> + hfclk_26m: oscillator { > >> + #clock-cells = <0>; > >> + compatible = "fixed-clock"; > >> + clock-frequency = <26000000>; > >> + }; > >> + > >> leds { > >> compatible = "gpio-leds"; > >> > >> @@ -274,6 +281,9 @@ > >> interrupts = <7>; /* SYS_NIRQ cascaded to intc */ > >> interrupt-parent = <&intc>; > >> > >> + clocks = <&hfclk_26m>; > >> + clock-names = "fck"; > > > > I wonder if we should rename this to hfclk... > > The DT documentation does not mention it and afaik it is not specified > > in DT files either. > > > > After all it is the HFCLK clock for the twl4030. > > We should not as it would break compatibility with stable kernels where > the code expects 'fck' and not hfclk. OK applying into omap-for-v4.18/dt thanks. Tony
On Thu, Apr 5, 2018 at 6:52 AM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote: > The board uses 26MHz oscillator for the twl4030 HFCLK. > This way we will not depend on the bootloader to configure the > CFG_BOOT:HFCLK_FREQ > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > --- > Hi, > > there might be other boards (all omap3 boards with twl4030?) which uses the same > setup, but I only have schematics for beagle-xm. > I know I am late coming into this, but we have twl4030_omap3.dtsi for the items common to omap3. Can we put the clock reference in that file? It seems like it would be cleaner than having a dozen boards or so boards having the exact same copy of the same stuff. SHould something change in the future, I would think it would make maintenance easier too. Just my two cents. adam > In order for the driver to actually use the clock the > [PATCH] mfd: twl-core: Fix clock initialization > need to be applied. W/o the twl-core patch the clock is just ignored. > > Regards, > Peter > > arch/arm/boot/dts/omap3-beagle-xm.dts | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts > index 0349fcc9dc26..d80587de0bbf 100644 > --- a/arch/arm/boot/dts/omap3-beagle-xm.dts > +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts > @@ -30,6 +30,13 @@ > ethernet = ðernet; > }; > > + /* fixed 26MHz oscillator */ > + hfclk_26m: oscillator { > + #clock-cells = <0>; > + compatible = "fixed-clock"; > + clock-frequency = <26000000>; > + }; > + > leds { > compatible = "gpio-leds"; > > @@ -274,6 +281,9 @@ > interrupts = <7>; /* SYS_NIRQ cascaded to intc */ > interrupt-parent = <&intc>; > > + clocks = <&hfclk_26m>; > + clock-names = "fck"; > + > twl_audio: audio { > compatible = "ti,twl4030-audio"; > codec { > -- > Peter > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
* Adam Ford <aford173@gmail.com> [180501 15:32]: > On Thu, Apr 5, 2018 at 6:52 AM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote: > > The board uses 26MHz oscillator for the twl4030 HFCLK. > > This way we will not depend on the bootloader to configure the > > CFG_BOOT:HFCLK_FREQ > > > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > > --- > > Hi, > > > > there might be other boards (all omap3 boards with twl4030?) which uses the same > > setup, but I only have schematics for beagle-xm. > > > > I know I am late coming into this, but we have twl4030_omap3.dtsi for > the items common to omap3. Can we put the clock reference in that > file? > > It seems like it would be cleaner than having a dozen boards or so > boards having the exact same copy of the same stuff. SHould something > change in the future, I would think it would make > maintenance easier too. Just my two cents. Well we don't know if it's a 26MiHz clock on all of them. Some use 38MiHz at least. Sure the board can override it but let's first fix up each board then later on add the common node. Regards, Tony
diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts index 0349fcc9dc26..d80587de0bbf 100644 --- a/arch/arm/boot/dts/omap3-beagle-xm.dts +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts @@ -30,6 +30,13 @@ ethernet = ðernet; }; + /* fixed 26MHz oscillator */ + hfclk_26m: oscillator { + #clock-cells = <0>; + compatible = "fixed-clock"; + clock-frequency = <26000000>; + }; + leds { compatible = "gpio-leds"; @@ -274,6 +281,9 @@ interrupts = <7>; /* SYS_NIRQ cascaded to intc */ interrupt-parent = <&intc>; + clocks = <&hfclk_26m>; + clock-names = "fck"; + twl_audio: audio { compatible = "ti,twl4030-audio"; codec {
The board uses 26MHz oscillator for the twl4030 HFCLK. This way we will not depend on the bootloader to configure the CFG_BOOT:HFCLK_FREQ Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> --- Hi, there might be other boards (all omap3 boards with twl4030?) which uses the same setup, but I only have schematics for beagle-xm. In order for the driver to actually use the clock the [PATCH] mfd: twl-core: Fix clock initialization need to be applied. W/o the twl-core patch the clock is just ignored. Regards, Peter arch/arm/boot/dts/omap3-beagle-xm.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)