diff mbox

drm/i915/firmware: Correct URL for firmware

Message ID 1525129168-529-1-git-send-email-anusha.srivatsa@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Srivatsa, Anusha April 30, 2018, 10:59 p.m. UTC
Replace 01.org URL with upstream linux-firmware repo URL.
We no longer release firmware to 01.org.
linux-firmware.git is the ultimate place to find
the i915 firmwares.

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
 drivers/gpu/drm/i915/intel_uc_fw.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rodrigo Vivi May 1, 2018, 12:36 a.m. UTC | #1
On Mon, Apr 30, 2018 at 03:59:28PM -0700, Anusha Srivatsa wrote:
> Replace 01.org URL with upstream linux-firmware repo URL.
> We no longer release firmware to 01.org.
> linux-firmware.git is the ultimate place to find
> the i915 firmwares.
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_uc_fw.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_uc_fw.h b/drivers/gpu/drm/i915/intel_uc_fw.h
> index dc33b12..87910aa 100644
> --- a/drivers/gpu/drm/i915/intel_uc_fw.h
> +++ b/drivers/gpu/drm/i915/intel_uc_fw.h
> @@ -30,7 +30,7 @@ struct drm_i915_private;
>  struct i915_vma;
>  
>  /* Home of GuC, HuC and DMC firmwares */
> -#define INTEL_UC_FIRMWARE_URL "https://01.org/linuxgraphics/downloads/firmware"
> +#define INTEL_UC_FIRMWARE_URL "https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/i915"

this or drm-firmware where we release first before our pull requests are accepted on linux-firmware.git?

Either way

Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

just let me know what you want to do...

>  
>  enum intel_uc_fw_status {
>  	INTEL_UC_FIRMWARE_FAIL = -1,
> -- 
> 2.7.4
>
Srivatsa, Anusha May 1, 2018, 4:59 p.m. UTC | #2
>-----Original Message-----
>From: Vivi, Rodrigo
>Sent: Monday, April 30, 2018 5:36 PM
>To: Srivatsa, Anusha <anusha.srivatsa@intel.com>
>Cc: intel-gfx@lists.freedesktop.org
>Subject: Re: [PATCH] drm/i915/firmware: Correct URL for firmware
>
>On Mon, Apr 30, 2018 at 03:59:28PM -0700, Anusha Srivatsa wrote:
>> Replace 01.org URL with upstream linux-firmware repo URL.
>> We no longer release firmware to 01.org.
>> linux-firmware.git is the ultimate place to find the i915 firmwares.
>>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_uc_fw.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_uc_fw.h
>> b/drivers/gpu/drm/i915/intel_uc_fw.h
>> index dc33b12..87910aa 100644
>> --- a/drivers/gpu/drm/i915/intel_uc_fw.h
>> +++ b/drivers/gpu/drm/i915/intel_uc_fw.h
>> @@ -30,7 +30,7 @@ struct drm_i915_private;  struct i915_vma;
>>
>>  /* Home of GuC, HuC and DMC firmwares */ -#define
>> INTEL_UC_FIRMWARE_URL
>"https://01.org/linuxgraphics/downloads/firmware"
>> +#define INTEL_UC_FIRMWARE_URL
>"https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-
>firmware.git/tree/i915"
>
>this or drm-firmware where we release first before our pull requests are accepted
>on linux-firmware.git?

Linux-firmware .git should be where users should refer to. Drm-firmware might have blobs that might fail in the CI runs and not make it to the upstream repo at all.....

>Either way
>
>Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Thanks for the ack. 
>just let me know what you want to do...
I think that we need to have linux-firmware repo here.... But let me know if you feel otherwise.

Regards,
Anusha 
>>
>>  enum intel_uc_fw_status {
>>  	INTEL_UC_FIRMWARE_FAIL = -1,
>> --
>> 2.7.4
>>
Rodrigo Vivi May 2, 2018, 8:41 p.m. UTC | #3
On Tue, May 01, 2018 at 09:59:10AM -0700, Srivatsa, Anusha wrote:
> 
> 
> >-----Original Message-----
> >From: Vivi, Rodrigo
> >Sent: Monday, April 30, 2018 5:36 PM
> >To: Srivatsa, Anusha <anusha.srivatsa@intel.com>
> >Cc: intel-gfx@lists.freedesktop.org
> >Subject: Re: [PATCH] drm/i915/firmware: Correct URL for firmware
> >
> >On Mon, Apr 30, 2018 at 03:59:28PM -0700, Anusha Srivatsa wrote:
> >> Replace 01.org URL with upstream linux-firmware repo URL.
> >> We no longer release firmware to 01.org.
> >> linux-firmware.git is the ultimate place to find the i915 firmwares.
> >>
> >> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> >> ---
> >>  drivers/gpu/drm/i915/intel_uc_fw.h | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/intel_uc_fw.h
> >> b/drivers/gpu/drm/i915/intel_uc_fw.h
> >> index dc33b12..87910aa 100644
> >> --- a/drivers/gpu/drm/i915/intel_uc_fw.h
> >> +++ b/drivers/gpu/drm/i915/intel_uc_fw.h
> >> @@ -30,7 +30,7 @@ struct drm_i915_private;  struct i915_vma;
> >>
> >>  /* Home of GuC, HuC and DMC firmwares */ -#define
> >> INTEL_UC_FIRMWARE_URL
> >"https://01.org/linuxgraphics/downloads/firmware"
> >> +#define INTEL_UC_FIRMWARE_URL
> >"https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-
> >firmware.git/tree/i915"
> >
> >this or drm-firmware where we release first before our pull requests are accepted
> >on linux-firmware.git?
> 
> Linux-firmware .git should be where users should refer to. Drm-firmware might have blobs that might fail in the CI runs and not make it to the upstream repo at all.....

Makes total sense.

> 
> >Either way
> >
> >Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> 
> Thanks for the ack. 
> >just let me know what you want to do...
> I think that we need to have linux-firmware repo here.... But let me know if you feel otherwise.

pushed, thanks.

> 
> Regards,
> Anusha 
> >>
> >>  enum intel_uc_fw_status {
> >>  	INTEL_UC_FIRMWARE_FAIL = -1,
> >> --
> >> 2.7.4
> >>
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_uc_fw.h b/drivers/gpu/drm/i915/intel_uc_fw.h
index dc33b12..87910aa 100644
--- a/drivers/gpu/drm/i915/intel_uc_fw.h
+++ b/drivers/gpu/drm/i915/intel_uc_fw.h
@@ -30,7 +30,7 @@  struct drm_i915_private;
 struct i915_vma;
 
 /* Home of GuC, HuC and DMC firmwares */
-#define INTEL_UC_FIRMWARE_URL "https://01.org/linuxgraphics/downloads/firmware"
+#define INTEL_UC_FIRMWARE_URL "https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/i915"
 
 enum intel_uc_fw_status {
 	INTEL_UC_FIRMWARE_FAIL = -1,