| Message ID | 20180503164009.14395-2-boris.brezillon@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, May 03, 2018 at 06:40:04PM +0200, Boris Brezillon wrote: > of_node_put(panel) is not called when of_drm_find_panel(panel) returns > NULL, thus leaking the reference we hold on panel. > > Fixes: 9be7d864cf07 ("drm/tegra: Implement panel support") > Cc: <stable@vger.kernel.org> > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> > --- > drivers/gpu/drm/tegra/output.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) I'm not sure this warrants a backport, it's a very minor reference leak so doesn't really have an impact on system stability or functionality. Since this patch is unrelated from the rest of the series, do you mind if I pick this up into the drm/tegra tree? Thierry
On Fri, May 04, 2018 at 11:50:16AM +0200, Thierry Reding wrote: > On Thu, May 03, 2018 at 06:40:04PM +0200, Boris Brezillon wrote: > > of_node_put(panel) is not called when of_drm_find_panel(panel) returns > > NULL, thus leaking the reference we hold on panel. > > > > Fixes: 9be7d864cf07 ("drm/tegra: Implement panel support") > > Cc: <stable@vger.kernel.org> > > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> > > --- > > drivers/gpu/drm/tegra/output.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > I'm not sure this warrants a backport, it's a very minor reference leak > so doesn't really have an impact on system stability or functionality. > > Since this patch is unrelated from the rest of the series, do you mind > if I pick this up into the drm/tegra tree? Oh, nevermind, I just noticed that patch 2 depends on this, so: Acked-by: Thierry Reding <treding@nvidia.com>
On Fri, 4 May 2018 11:50:16 +0200 Thierry Reding <thierry.reding@gmail.com> wrote: > On Thu, May 03, 2018 at 06:40:04PM +0200, Boris Brezillon wrote: > > of_node_put(panel) is not called when of_drm_find_panel(panel) returns > > NULL, thus leaking the reference we hold on panel. > > > > Fixes: 9be7d864cf07 ("drm/tegra: Implement panel support") > > Cc: <stable@vger.kernel.org> > > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> > > --- > > drivers/gpu/drm/tegra/output.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > I'm not sure this warrants a backport, it's a very minor reference leak > so doesn't really have an impact on system stability or functionality. > > Since this patch is unrelated from the rest of the series, do you mind > if I pick this up into the drm/tegra tree? Sure, and feel free to remove the Cc-stable and Fixes tag if you think they are not necessary.
diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c index ffe34bd0bb9d..676fd394836f 100644 --- a/drivers/gpu/drm/tegra/output.c +++ b/drivers/gpu/drm/tegra/output.c @@ -110,10 +110,9 @@ int tegra_output_probe(struct tegra_output *output) panel = of_parse_phandle(output->of_node, "nvidia,panel", 0); if (panel) { output->panel = of_drm_find_panel(panel); + of_node_put(panel); if (!output->panel) return -EPROBE_DEFER; - - of_node_put(panel); } output->edid = of_get_property(output->of_node, "nvidia,edid", &size);
of_node_put(panel) is not called when of_drm_find_panel(panel) returns NULL, thus leaking the reference we hold on panel. Fixes: 9be7d864cf07 ("drm/tegra: Implement panel support") Cc: <stable@vger.kernel.org> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> --- drivers/gpu/drm/tegra/output.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)