diff mbox

[v2,2/2] dt-bindings: Add Raydium RM67191 panel bindings

Message ID 1525357562-20810-3-git-send-email-robert.chiras@nxp.com (mailing list archive)
State New, archived
Headers show

Commit Message

Robert Chiras May 3, 2018, 2:26 p.m. UTC
Signed-off-by: Robert Chiras <robert.chiras@nxp.com>
---
 .../bindings/display/panel/raydium,rm67191.txt     | 38 ++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt

Comments

Rob Herring (Arm) May 7, 2018, 4:50 p.m. UTC | #1
On Thu, May 03, 2018 at 05:26:02PM +0300, Robert Chiras wrote:
> Signed-off-by: Robert Chiras <robert.chiras@nxp.com>
> ---
>  .../bindings/display/panel/raydium,rm67191.txt     | 38 ++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt
> new file mode 100644
> index 0000000..0fe6d4b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt
> @@ -0,0 +1,38 @@
> +Raydium RM67171 OLED LCD panel with MIPI-DSI protocol
> +
> +Required properties:
> +- compatible: 		"raydium,rm67191"
> +- reg:			virtual channel for MIPI-DSI protocol
> +			must be <0>
> +- dsi-lanes:		number of DSI lanes to be used
> +			must be <3> or <4>
> +- port: 		input port node with endpoint definition as
> +			defined in Documentation/devicetree/bindings/graph.txt;
> +			the input port should be connected to a MIPI-DSI device
> +			driver
> +
> +Optional properties:
> +- reset-gpio:		a GPIO spec for the RST_B GPIO pin
> +- pinctrl-0		phandle to the pin settings for the reset pin
> +- panel-width-mm:	physical panel width [mm]
> +- panel-height-mm:	physical panel height [mm]

width-mm and height-mm are the common property names.

> +
> +[1]: Documentation/devicetree/bindings/display/display-timing.txt

Footnote to what?
Robert Chiras May 8, 2018, 10:20 a.m. UTC | #2
On Lu, 2018-05-07 at 11:50 -0500, Rob Herring wrote:
> On Thu, May 03, 2018 at 05:26:02PM +0300, Robert Chiras wrote:

> > 

> > Signed-off-by: Robert Chiras <robert.chiras@nxp.com>

> > ---

> >  .../bindings/display/panel/raydium,rm67191.txt     | 38

> > ++++++++++++++++++++++

> >  1 file changed, 38 insertions(+)

> >  create mode 100644

> > Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt

> > 

> > diff --git

> > a/Documentation/devicetree/bindings/display/panel/raydium,rm67191.t

> > xt

> > b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.t

> > xt

> > new file mode 100644

> > index 0000000..0fe6d4b

> > --- /dev/null

> > +++

> > b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.t

> > xt

> > @@ -0,0 +1,38 @@

> > +Raydium RM67171 OLED LCD panel with MIPI-DSI protocol

> > +

> > +Required properties:

> > +- compatible: 		"raydium,rm67191"

> > +- reg:			virtual channel for MIPI-DSI

> > protocol

> > +			must be <0>

> > +- dsi-lanes:		number of DSI lanes to be used

> > +			must be <3> or <4>

> > +- port: 		input port node with endpoint definition

> > as

> > +			defined in

> > Documentation/devicetree/bindings/graph.txt;

> > +			the input port should be connected to a

> > MIPI-DSI device

> > +			driver

> > +

> > +Optional properties:

> > +- reset-gpio:		a GPIO spec for the RST_B GPIO pin

> > +- pinctrl-0		phandle to the pin settings for the

> > reset pin

> > +- panel-width-mm:	physical panel width [mm]

> > +- panel-height-mm:	physical panel height [mm]

> width-mm and height-mm are the common property names.

OK, I will change them accordingly.
> 

> > 

> > +

> > +[1]: Documentation/devicetree/bindings/display/display-timing.txt

> Footnote to what?

In the previous version it had an optional display-timing property. I
removed it in this version, but I forgot to remove the footnote. I will
remove this in the next version of the patch-set.
>
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt
new file mode 100644
index 0000000..0fe6d4b
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt
@@ -0,0 +1,38 @@ 
+Raydium RM67171 OLED LCD panel with MIPI-DSI protocol
+
+Required properties:
+- compatible: 		"raydium,rm67191"
+- reg:			virtual channel for MIPI-DSI protocol
+			must be <0>
+- dsi-lanes:		number of DSI lanes to be used
+			must be <3> or <4>
+- port: 		input port node with endpoint definition as
+			defined in Documentation/devicetree/bindings/graph.txt;
+			the input port should be connected to a MIPI-DSI device
+			driver
+
+Optional properties:
+- reset-gpio:		a GPIO spec for the RST_B GPIO pin
+- pinctrl-0		phandle to the pin settings for the reset pin
+- panel-width-mm:	physical panel width [mm]
+- panel-height-mm:	physical panel height [mm]
+
+[1]: Documentation/devicetree/bindings/display/display-timing.txt
+
+Example:
+
+	panel@0 {
+		compatible = "raydium,rm67191";
+		reg = <0>;
+		pinctrl-0 = <&pinctrl_mipi_dsi_0_1_en>;
+		reset-gpio = <&gpio1 7 GPIO_ACTIVE_HIGH>;
+		dsi-lanes = <4>;
+		panel-width-mm = <68>;
+		panel-height-mm = <121>;
+
+		port {
+			panel1_in: endpoint {
+				remote-endpoint = <&mipi1_out>;
+			};
+		};
+	};