diff mbox

[1/2] drm/dp: Add DP_DPCD_REV_XX to drm_dp_helper

Message ID 20180504221800.17830-1-matthew.s.atwood@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Matt Atwood May 4, 2018, 10:17 p.m. UTC 
From: Matt Atwood <matthew.s.atwood@intel.com>

As more differentation occurs between DP spec. Its useful to have these
as macros in a drm_dp_helper.

v2: DPCD_REV_XX to DP_DPCD_REV_XX

Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
---
 include/drm/drm_dp_helper.h | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Rodrigo Vivi May 8, 2018, 7:01 a.m. UTC | #1 
On Fri, May 04, 2018 at 03:17:59PM -0700, matthew.s.atwood@intel.com wrote:
> From: Matt Atwood <matthew.s.atwood@intel.com>
> 
> As more differentation occurs between DP spec. Its useful to have these
> as macros in a drm_dp_helper.
> 
> v2: DPCD_REV_XX to DP_DPCD_REV_XX
> 
> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  include/drm/drm_dp_helper.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 91c9bcd4196f..96dcef479ed6 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -64,6 +64,11 @@
>  /* AUX CH addresses */
>  /* DPCD */
>  #define DP_DPCD_REV                         0x000
> +# define DP_DPCD_REV_10                     0x10
> +# define DP_DPCD_REV_11                     0x11
> +# define DP_DPCD_REV_12                     0x12
> +# define DP_DPCD_REV_13                     0x13
> +# define DP_DPCD_REV_14                     0x14
>  
>  #define DP_MAX_LINK_RATE                    0x001
>  
> -- 
> 2.17.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Benson Leung May 22, 2018, 10:59 p.m. UTC | #2 
On Fri, May 04, 2018 at 03:17:59PM -0700, matthew.s.atwood@intel.com wrote:
> From: Matt Atwood <matthew.s.atwood@intel.com>
> 
> As more differentation occurs between DP spec. Its useful to have these
> as macros in a drm_dp_helper.
> 
> v2: DPCD_REV_XX to DP_DPCD_REV_XX
> 
> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>

Tested-by: Benson Leung <bleung@chromium.org> 

> ---
>  include/drm/drm_dp_helper.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 91c9bcd4196f..96dcef479ed6 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -64,6 +64,11 @@
>  /* AUX CH addresses */
>  /* DPCD */
>  #define DP_DPCD_REV                         0x000
> +# define DP_DPCD_REV_10                     0x10
> +# define DP_DPCD_REV_11                     0x11
> +# define DP_DPCD_REV_12                     0x12
> +# define DP_DPCD_REV_13                     0x13
> +# define DP_DPCD_REV_14                     0x14
>  
>  #define DP_MAX_LINK_RATE                    0x001
>  
> -- 
> 2.17.0
>
diff mbox

Patch

diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 91c9bcd4196f..96dcef479ed6 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -64,6 +64,11 @@ 
 /* AUX CH addresses */
 /* DPCD */
 #define DP_DPCD_REV                         0x000
+# define DP_DPCD_REV_10                     0x10
+# define DP_DPCD_REV_11                     0x11
+# define DP_DPCD_REV_12                     0x12
+# define DP_DPCD_REV_13                     0x13
+# define DP_DPCD_REV_14                     0x14
 
 #define DP_MAX_LINK_RATE                    0x001