diff mbox

drm/i915: Remove unused i915_flip tracepoints

Message ID 20180508151552.31024-1-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Chris Wilson May 8, 2018, 3:15 p.m. UTC
The i915_flip* tracepoints are no longer in use since the removal of CS
flip in commit 8b5d27b911d7 ("drm/i915: Remove intel_flip_work
infrastructure")

References: 8b5d27b911d7 ("drm/i915: Remove intel_flip_work infrastructure")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/i915/i915_trace.h | 36 -------------------------------
 1 file changed, 36 deletions(-)

Comments

Ville Syrjälä May 8, 2018, 3:35 p.m. UTC | #1
On Tue, May 08, 2018 at 04:15:52PM +0100, Chris Wilson wrote:
> The i915_flip* tracepoints are no longer in use since the removal of CS
> flip in commit 8b5d27b911d7 ("drm/i915: Remove intel_flip_work
> infrastructure")
> 
> References: 8b5d27b911d7 ("drm/i915: Remove intel_flip_work infrastructure")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/i915_trace.h | 36 -------------------------------
>  1 file changed, 36 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
> index 77ee5e53eb32..8cc3a256f29d 100644
> --- a/drivers/gpu/drm/i915/i915_trace.h
> +++ b/drivers/gpu/drm/i915/i915_trace.h
> @@ -834,42 +834,6 @@ DEFINE_EVENT(i915_request, i915_request_wait_end,
>  	    TP_ARGS(rq)
>  );
>  
> -TRACE_EVENT(i915_flip_request,
> -	    TP_PROTO(int plane, struct drm_i915_gem_object *obj),
> -
> -	    TP_ARGS(plane, obj),
> -
> -	    TP_STRUCT__entry(
> -		    __field(int, plane)
> -		    __field(struct drm_i915_gem_object *, obj)
> -		    ),
> -
> -	    TP_fast_assign(
> -		    __entry->plane = plane;
> -		    __entry->obj = obj;
> -		    ),
> -
> -	    TP_printk("plane=%d, obj=%p", __entry->plane, __entry->obj)
> -);
> -
> -TRACE_EVENT(i915_flip_complete,
> -	    TP_PROTO(int plane, struct drm_i915_gem_object *obj),
> -
> -	    TP_ARGS(plane, obj),
> -
> -	    TP_STRUCT__entry(
> -		    __field(int, plane)
> -		    __field(struct drm_i915_gem_object *, obj)
> -		    ),
> -
> -	    TP_fast_assign(
> -		    __entry->plane = plane;
> -		    __entry->obj = obj;
> -		    ),
> -
> -	    TP_printk("plane=%d, obj=%p", __entry->plane, __entry->obj)
> -);
> -
>  TRACE_EVENT_CONDITION(i915_reg_rw,
>  	TP_PROTO(bool write, i915_reg_t reg, u64 val, int len, bool trace),
>  
> -- 
> 2.17.0
Chris Wilson May 8, 2018, 8:50 p.m. UTC | #2
Quoting Ville Syrjälä (2018-05-08 16:35:18)
> On Tue, May 08, 2018 at 04:15:52PM +0100, Chris Wilson wrote:
> > The i915_flip* tracepoints are no longer in use since the removal of CS
> > flip in commit 8b5d27b911d7 ("drm/i915: Remove intel_flip_work
> > infrastructure")
> > 
> > References: 8b5d27b911d7 ("drm/i915: Remove intel_flip_work infrastructure")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Daniel Vetter <daniel.vetter@intel.com>
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Pushed, many thanks for the review.
-Chris
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
index 77ee5e53eb32..8cc3a256f29d 100644
--- a/drivers/gpu/drm/i915/i915_trace.h
+++ b/drivers/gpu/drm/i915/i915_trace.h
@@ -834,42 +834,6 @@  DEFINE_EVENT(i915_request, i915_request_wait_end,
 	    TP_ARGS(rq)
 );
 
-TRACE_EVENT(i915_flip_request,
-	    TP_PROTO(int plane, struct drm_i915_gem_object *obj),
-
-	    TP_ARGS(plane, obj),
-
-	    TP_STRUCT__entry(
-		    __field(int, plane)
-		    __field(struct drm_i915_gem_object *, obj)
-		    ),
-
-	    TP_fast_assign(
-		    __entry->plane = plane;
-		    __entry->obj = obj;
-		    ),
-
-	    TP_printk("plane=%d, obj=%p", __entry->plane, __entry->obj)
-);
-
-TRACE_EVENT(i915_flip_complete,
-	    TP_PROTO(int plane, struct drm_i915_gem_object *obj),
-
-	    TP_ARGS(plane, obj),
-
-	    TP_STRUCT__entry(
-		    __field(int, plane)
-		    __field(struct drm_i915_gem_object *, obj)
-		    ),
-
-	    TP_fast_assign(
-		    __entry->plane = plane;
-		    __entry->obj = obj;
-		    ),
-
-	    TP_printk("plane=%d, obj=%p", __entry->plane, __entry->obj)
-);
-
 TRACE_EVENT_CONDITION(i915_reg_rw,
 	TP_PROTO(bool write, i915_reg_t reg, u64 val, int len, bool trace),