diff mbox

ALSA: usb: mixer: volume quirk for CM102-A+/102S+

Message ID 20180508221338.6229-1-fedux@fedux.com.ar (mailing list archive)
State New, archived
Headers show

Commit Message

Federico Cuello May 8, 2018, 10:13 p.m. UTC
Currently it's not possible to set volume lower than 26% (it just mutes).

Also fixes this warning:

  Warning! Unlikely big volume range (=9472), cval->res is probably wrong.
  [13] FU [PCM Playback Volume] ch = 2, val = -9473/-1/1

, and volume works fine for full range.

Signed-off-by: Federico Cuello <fedux@fedux.com.ar>
---
 sound/usb/mixer.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Takashi Iwai May 13, 2018, 4:54 p.m. UTC | #1
On Wed, 09 May 2018 00:13:38 +0200,
Federico Cuello wrote:
> 
> Currently it's not possible to set volume lower than 26% (it just mutes).
> 
> Also fixes this warning:
> 
>   Warning! Unlikely big volume range (=9472), cval->res is probably wrong.
>   [13] FU [PCM Playback Volume] ch = 2, val = -9473/-1/1
> 
> , and volume works fine for full range.
> 
> Signed-off-by: Federico Cuello <fedux@fedux.com.ar>

Applied, thanks.


Takashi
diff mbox

Patch

diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
index 344d7b069d59..bb5ab7a7dfa5 100644
--- a/sound/usb/mixer.c
+++ b/sound/usb/mixer.c
@@ -967,6 +967,14 @@  static void volume_control_quirks(struct usb_mixer_elem_info *cval,
 		}
 		break;
 
+	case USB_ID(0x0d8c, 0x0103):
+		if (!strcmp(kctl->id.name, "PCM Playback Volume")) {
+			usb_audio_info(chip,
+				 "set volume quirk for CM102-A+/102S+\n");
+			cval->min = -256;
+		}
+		break;
+
 	case USB_ID(0x0471, 0x0101):
 	case USB_ID(0x0471, 0x0104):
 	case USB_ID(0x0471, 0x0105):