diff mbox

ARM: dts: socfpga: Fix NAND controller node compatible

Message ID 20180510125223.16056-1-marex@denx.de (mailing list archive)
State New, archived
Headers show

Commit Message

Marek Vasut May 10, 2018, 12:52 p.m. UTC
The compatible string for the Denali NAND controller is incorrect,
fix it by replacing it with one matching the DT bindings and the
driver.

Signed-off-by: Marek Vasut <marex@denx.de>
Fixes: d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")
Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: Dinh Nguyen <dinguyen@kernel.org>
---
 arch/arm/boot/dts/socfpga.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Steffen Trumtrar May 14, 2018, 7:11 a.m. UTC | #1
Marek Vasut <marex@denx.de> writes:

> The compatible string for the Denali NAND controller is 
> incorrect,
> fix it by replacing it with one matching the DT bindings and the
> driver.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Fixes: d837a80d19 ("ARM: dts: socfpga: add nand controller 
> nodes")
> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> Cc: Dinh Nguyen <dinguyen@kernel.org>
> ---
>  arch/arm/boot/dts/socfpga.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/socfpga.dtsi 
> b/arch/arm/boot/dts/socfpga.dtsi
> index 7e24dc8e82d4..d697f5062624 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -744,7 +744,7 @@
>  		nand0: nand@ff900000 {
>  			#address-cells = <0x1>;
>  			#size-cells = <0x1>;
> -			compatible = "denali,denali-nand-dt";
> +			compatible = "altr,socfpga-denali-nand";
>  			reg = <0xff900000 0x100000>,
>  			      <0xffb80000 0x10000>;
>  			reg-names = "nand_data", "denali_reg";

Ack. As the binding was changed after d837a80d19 this is obviously
correct.

@Dinh: Maybe you also want to cleanup the socfpga_arria10.dtsi? It 
has
both compatibles, but the "denali,denali-nand-dt" seems to be 
obsolete.

Thanks,
Steffen
Dinh Nguyen May 14, 2018, 3:11 p.m. UTC | #2
On 05/14/2018 02:11 AM, Steffen Trumtrar wrote:
> 
> Marek Vasut <marex@denx.de> writes:
> 
>> The compatible string for the Denali NAND controller is incorrect,
>> fix it by replacing it with one matching the DT bindings and the
>> driver.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Fixes: d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")
>> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>> Cc: Dinh Nguyen <dinguyen@kernel.org>
>> ---
>>  arch/arm/boot/dts/socfpga.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/socfpga.dtsi
>> b/arch/arm/boot/dts/socfpga.dtsi
>> index 7e24dc8e82d4..d697f5062624 100644
>> --- a/arch/arm/boot/dts/socfpga.dtsi
>> +++ b/arch/arm/boot/dts/socfpga.dtsi
>> @@ -744,7 +744,7 @@
>>          nand0: nand@ff900000 {
>>              #address-cells = <0x1>;
>>              #size-cells = <0x1>;
>> -            compatible = "denali,denali-nand-dt";
>> +            compatible = "altr,socfpga-denali-nand";
>>              reg = <0xff900000 0x100000>,
>>                    <0xffb80000 0x10000>;
>>              reg-names = "nand_data", "denali_reg";
> 
> Ack. As the binding was changed after d837a80d19 this is obviously
> correct.
> 
> @Dinh: Maybe you also want to cleanup the socfpga_arria10.dtsi? It has
> both compatibles, but the "denali,denali-nand-dt" seems to be obsolete.
> 

Patch applied and cc'd stable kernel.

Will clean up arria10.

Thanks,
Dinh
Dinh Nguyen May 14, 2018, 3:11 p.m. UTC | #3
On 05/14/2018 02:11 AM, Steffen Trumtrar wrote:
> 
> Marek Vasut <marex@denx.de> writes:
> 
>> The compatible string for the Denali NAND controller is incorrect,
>> fix it by replacing it with one matching the DT bindings and the
>> driver.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Fixes: d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")
>> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>> Cc: Dinh Nguyen <dinguyen@kernel.org>
>> ---
>>  arch/arm/boot/dts/socfpga.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/socfpga.dtsi
>> b/arch/arm/boot/dts/socfpga.dtsi
>> index 7e24dc8e82d4..d697f5062624 100644
>> --- a/arch/arm/boot/dts/socfpga.dtsi
>> +++ b/arch/arm/boot/dts/socfpga.dtsi
>> @@ -744,7 +744,7 @@
>>          nand0: nand@ff900000 {
>>              #address-cells = <0x1>;
>>              #size-cells = <0x1>;
>> -            compatible = "denali,denali-nand-dt";
>> +            compatible = "altr,socfpga-denali-nand";
>>              reg = <0xff900000 0x100000>,
>>                    <0xffb80000 0x10000>;
>>              reg-names = "nand_data", "denali_reg";
> 
> Ack. As the binding was changed after d837a80d19 this is obviously
> correct.
> 
> @Dinh: Maybe you also want to cleanup the socfpga_arria10.dtsi? It has
> both compatibles, but the "denali,denali-nand-dt" seems to be obsolete.
> 

Patch applied and cc'd stable kernel.

Will clean up arria10.

Thanks,
Dinh
Dinh Nguyen May 14, 2018, 3:11 p.m. UTC | #4
On 05/14/2018 02:11 AM, Steffen Trumtrar wrote:
> 
> Marek Vasut <marex@denx.de> writes:
> 
>> The compatible string for the Denali NAND controller is incorrect,
>> fix it by replacing it with one matching the DT bindings and the
>> driver.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Fixes: d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")
>> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>> Cc: Dinh Nguyen <dinguyen@kernel.org>
>> ---
>>  arch/arm/boot/dts/socfpga.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/socfpga.dtsi
>> b/arch/arm/boot/dts/socfpga.dtsi
>> index 7e24dc8e82d4..d697f5062624 100644
>> --- a/arch/arm/boot/dts/socfpga.dtsi
>> +++ b/arch/arm/boot/dts/socfpga.dtsi
>> @@ -744,7 +744,7 @@
>>          nand0: nand@ff900000 {
>>              #address-cells = <0x1>;
>>              #size-cells = <0x1>;
>> -            compatible = "denali,denali-nand-dt";
>> +            compatible = "altr,socfpga-denali-nand";
>>              reg = <0xff900000 0x100000>,
>>                    <0xffb80000 0x10000>;
>>              reg-names = "nand_data", "denali_reg";
> 
> Ack. As the binding was changed after d837a80d19 this is obviously
> correct.
> 
> @Dinh: Maybe you also want to cleanup the socfpga_arria10.dtsi? It has
> both compatibles, but the "denali,denali-nand-dt" seems to be obsolete.
> 

Patch applied and cc'd stable kernel.

Will clean up arria10.

Thanks,
Dinh
Dinh Nguyen May 14, 2018, 3:21 p.m. UTC | #5
On 05/14/2018 02:11 AM, Steffen Trumtrar wrote:
> 
> Marek Vasut <marex@denx.de> writes:
> 
>> The compatible string for the Denali NAND controller is incorrect,
>> fix it by replacing it with one matching the DT bindings and the
>> driver.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Fixes: d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")
>> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>> Cc: Dinh Nguyen <dinguyen@kernel.org>
>> ---
>>  arch/arm/boot/dts/socfpga.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/socfpga.dtsi
>> b/arch/arm/boot/dts/socfpga.dtsi
>> index 7e24dc8e82d4..d697f5062624 100644
>> --- a/arch/arm/boot/dts/socfpga.dtsi
>> +++ b/arch/arm/boot/dts/socfpga.dtsi
>> @@ -744,7 +744,7 @@
>>          nand0: nand@ff900000 {
>>              #address-cells = <0x1>;
>>              #size-cells = <0x1>;
>> -            compatible = "denali,denali-nand-dt";
>> +            compatible = "altr,socfpga-denali-nand";
>>              reg = <0xff900000 0x100000>,
>>                    <0xffb80000 0x10000>;
>>              reg-names = "nand_data", "denali_reg";
> 
> Ack. As the binding was changed after d837a80d19 this is obviously
> correct.
> 
> @Dinh: Maybe you also want to cleanup the socfpga_arria10.dtsi? It has
> both compatibles, but the "denali,denali-nand-dt" seems to be obsolete.
> 

Applied and cc'd stable.

Will fix up for Arria10.

Thanks

Dinh
Dinh Nguyen May 14, 2018, 3:21 p.m. UTC | #6
On 05/14/2018 02:11 AM, Steffen Trumtrar wrote:
> 
> Marek Vasut <marex@denx.de> writes:
> 
>> The compatible string for the Denali NAND controller is incorrect,
>> fix it by replacing it with one matching the DT bindings and the
>> driver.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Fixes: d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")
>> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>> Cc: Dinh Nguyen <dinguyen@kernel.org>
>> ---
>>  arch/arm/boot/dts/socfpga.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/socfpga.dtsi
>> b/arch/arm/boot/dts/socfpga.dtsi
>> index 7e24dc8e82d4..d697f5062624 100644
>> --- a/arch/arm/boot/dts/socfpga.dtsi
>> +++ b/arch/arm/boot/dts/socfpga.dtsi
>> @@ -744,7 +744,7 @@
>>          nand0: nand@ff900000 {
>>              #address-cells = <0x1>;
>>              #size-cells = <0x1>;
>> -            compatible = "denali,denali-nand-dt";
>> +            compatible = "altr,socfpga-denali-nand";
>>              reg = <0xff900000 0x100000>,
>>                    <0xffb80000 0x10000>;
>>              reg-names = "nand_data", "denali_reg";
> 
> Ack. As the binding was changed after d837a80d19 this is obviously
> correct.
> 
> @Dinh: Maybe you also want to cleanup the socfpga_arria10.dtsi? It has
> both compatibles, but the "denali,denali-nand-dt" seems to be obsolete.
> 

Applied and cc'd stable.

Will fix up for Arria10.

Thanks

Dinh
diff mbox

Patch

diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
index 7e24dc8e82d4..d697f5062624 100644
--- a/arch/arm/boot/dts/socfpga.dtsi
+++ b/arch/arm/boot/dts/socfpga.dtsi
@@ -744,7 +744,7 @@ 
 		nand0: nand@ff900000 {
 			#address-cells = <0x1>;
 			#size-cells = <0x1>;
-			compatible = "denali,denali-nand-dt";
+			compatible = "altr,socfpga-denali-nand";
 			reg = <0xff900000 0x100000>,
 			      <0xffb80000 0x10000>;
 			reg-names = "nand_data", "denali_reg";