| Message ID | 1526387370-17142-3-git-send-email-gilad@benyossef.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Herbert Xu |
| Headers | show |
Hi Gilad, On Tue, May 15, 2018 at 2:29 PM, Gilad Ben-Yossef <gilad@benyossef.com> wrote: > This patch adds the clock used by the CryptoCell 630p instance in the SoC. > > Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> Thanks for your patch! > --- a/drivers/clk/renesas/r8a7795-cpg-mssr.c > +++ b/drivers/clk/renesas/r8a7795-cpg-mssr.c > @@ -132,6 +132,7 @@ static struct mssr_mod_clk r8a7795_mod_clks[] __initdata = { > DEF_MOD("sys-dmac2", 217, R8A7795_CLK_S0D3), > DEF_MOD("sys-dmac1", 218, R8A7795_CLK_S0D3), > DEF_MOD("sys-dmac0", 219, R8A7795_CLK_S0D3), > + DEF_MOD("ccree", 229, R8A7795_CLK_S3D2), I don't know if "ccree" is the proper name for this clock, as there may be multiple instances. I also can't verify the parent clock. > DEF_MOD("cmt3", 300, R8A7795_CLK_R), > DEF_MOD("cmt2", 301, R8A7795_CLK_R), > DEF_MOD("cmt1", 302, R8A7795_CLK_R), Gr{oetje,eeting}s, Geert
On Tue, May 15, 2018 at 5:47 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Hi Gilad, > > On Tue, May 15, 2018 at 2:29 PM, Gilad Ben-Yossef <gilad@benyossef.com> wrote: >> This patch adds the clock used by the CryptoCell 630p instance in the SoC. >> >> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> > > Thanks for your patch! > >> --- a/drivers/clk/renesas/r8a7795-cpg-mssr.c >> +++ b/drivers/clk/renesas/r8a7795-cpg-mssr.c >> @@ -132,6 +132,7 @@ static struct mssr_mod_clk r8a7795_mod_clks[] __initdata = { >> DEF_MOD("sys-dmac2", 217, R8A7795_CLK_S0D3), >> DEF_MOD("sys-dmac1", 218, R8A7795_CLK_S0D3), >> DEF_MOD("sys-dmac0", 219, R8A7795_CLK_S0D3), >> + DEF_MOD("ccree", 229, R8A7795_CLK_S3D2), > > I don't know if "ccree" is the proper name for this clock, as there > may be multiple > instances. I'd be happy to rename it to anything else. Suggestions? > I also can't verify the parent clock. I'm afraid I can't really help. This is based on code snippet from Renesas. I verified it works but I am not an expert on the clock settings :-( > >> DEF_MOD("cmt3", 300, R8A7795_CLK_R), >> DEF_MOD("cmt2", 301, R8A7795_CLK_R), >> DEF_MOD("cmt1", 302, R8A7795_CLK_R), > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Gilad, On Thu, May 17, 2018 at 10:00 AM, Gilad Ben-Yossef <gilad@benyossef.com> wrote: > On Tue, May 15, 2018 at 5:47 PM, Geert Uytterhoeven > <geert@linux-m68k.org> wrote: >> On Tue, May 15, 2018 at 2:29 PM, Gilad Ben-Yossef <gilad@benyossef.com> wrote: >>> This patch adds the clock used by the CryptoCell 630p instance in the SoC. >>> >>> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> >> >> Thanks for your patch! >> >>> --- a/drivers/clk/renesas/r8a7795-cpg-mssr.c >>> +++ b/drivers/clk/renesas/r8a7795-cpg-mssr.c >>> @@ -132,6 +132,7 @@ static struct mssr_mod_clk r8a7795_mod_clks[] __initdata = { >>> DEF_MOD("sys-dmac2", 217, R8A7795_CLK_S0D3), >>> DEF_MOD("sys-dmac1", 218, R8A7795_CLK_S0D3), >>> DEF_MOD("sys-dmac0", 219, R8A7795_CLK_S0D3), >>> + DEF_MOD("ccree", 229, R8A7795_CLK_S3D2), >> >> I don't know if "ccree" is the proper name for this clock, as there >> may be multiple >> instances. > > I'd be happy to rename it to anything else. Suggestions? I believe it should be called "sceg-pub". >> I also can't verify the parent clock. > > I'm afraid I can't really help. This is based on code snippet from > Renesas. I verified it works but > I am not an expert on the clock settings :-( As your driver doesn't care about the clock rate, only about enabling/disabling the clock, the actual parent doesn't matter much. After some deeper diving into the datasheet, I believe the correct parent is the CR clock, which is unfortunately not yet supported by the R-Car H3 clock driver. I'll send a patch... Gr{oetje,eeting}s, Geert
diff --git a/drivers/clk/renesas/r8a7795-cpg-mssr.c b/drivers/clk/renesas/r8a7795-cpg-mssr.c index 775b0ce..642706a 100644 --- a/drivers/clk/renesas/r8a7795-cpg-mssr.c +++ b/drivers/clk/renesas/r8a7795-cpg-mssr.c @@ -132,6 +132,7 @@ static struct mssr_mod_clk r8a7795_mod_clks[] __initdata = { DEF_MOD("sys-dmac2", 217, R8A7795_CLK_S0D3), DEF_MOD("sys-dmac1", 218, R8A7795_CLK_S0D3), DEF_MOD("sys-dmac0", 219, R8A7795_CLK_S0D3), + DEF_MOD("ccree", 229, R8A7795_CLK_S3D2), DEF_MOD("cmt3", 300, R8A7795_CLK_R), DEF_MOD("cmt2", 301, R8A7795_CLK_R), DEF_MOD("cmt1", 302, R8A7795_CLK_R),
This patch adds the clock used by the CryptoCell 630p instance in the SoC. Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> --- drivers/clk/renesas/r8a7795-cpg-mssr.c | 1 + 1 file changed, 1 insertion(+)