| Message ID | 20180515121239.18192-3-a.hajda@samsung.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Tue, May 15, 2018 at 2:12 PM, Andrzej Hajda <a.hajda@samsung.com> wrote: > OF graph describes USB data lanes between USB-PHY and respective MUIC. > Since graph is present and DWC driver can use it to get extcon, obsolete > extcon property can be removed. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > .../dts/exynos/exynos5433-tm2-common.dtsi | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) As we discussed for v1 - since this was not split into two, I'll apply it once first patch hits mainline. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Krzysztof Kozlowski <krzk@kernel.org> writes: > On Tue, May 15, 2018 at 2:12 PM, Andrzej Hajda <a.hajda@samsung.com> wrote: >> OF graph describes USB data lanes between USB-PHY and respective MUIC. >> Since graph is present and DWC driver can use it to get extcon, obsolete >> extcon property can be removed. >> >> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >> --- >> .../dts/exynos/exynos5433-tm2-common.dtsi | 19 ++++++++++++++++++- >> 1 file changed, 18 insertions(+), 1 deletion(-) > > As we discussed for v1 - since this was not split into two, I'll apply > it once first patch hits mainline. I just took patch 1 to my tree, fyi
On Tue, May 15, 2018 at 02:12:39PM +0200, Andrzej Hajda wrote: > OF graph describes USB data lanes between USB-PHY and respective MUIC. > Since graph is present and DWC driver can use it to get extcon, obsolete > extcon property can be removed. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > .../dts/exynos/exynos5433-tm2-common.dtsi | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) dtc W=1 now complains with: === Warning (graph_child_address): /soc/hsi2c@14d90000/max77843@66/max77843-muic/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary === Do you plan to add more ports soon? Best regards, Krzysztof > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > index 03453b822093..042e5894a138 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > @@ -868,6 +868,18 @@ > }; > }; > }; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + muic_to_usb: endpoint { > + remote-endpoint = <&usb_to_muic>; > + }; > + }; > + }; > }; > > regulators { > @@ -1287,12 +1299,17 @@ > > &usbdrd_dwc3 { > dr_mode = "otg"; > - extcon = <&muic>; > }; > > &usbdrd30_phy { > vbus-supply = <&safeout1_reg>; > status = "okay"; > + > + port { > + usb_to_muic: endpoint { > + remote-endpoint = <&muic_to_usb>; > + }; > + }; > }; > > &xxti { > -- > 2.17.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 20.06.2018 20:28, Krzysztof Kozlowski wrote: > On Tue, May 15, 2018 at 02:12:39PM +0200, Andrzej Hajda wrote: >> OF graph describes USB data lanes between USB-PHY and respective MUIC. >> Since graph is present and DWC driver can use it to get extcon, obsolete >> extcon property can be removed. >> >> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >> --- >> .../dts/exynos/exynos5433-tm2-common.dtsi | 19 ++++++++++++++++++- >> 1 file changed, 18 insertions(+), 1 deletion(-) > dtc W=1 now complains with: > === > Warning (graph_child_address): > /soc/hsi2c@14d90000/max77843@66/max77843-muic/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary > === > > Do you plan to add more ports soon? There could be a link between UART and MUIC, it could be beneficial for the platform - there is no point to feed UART with data when UART output is muxed-out by MUIC. So I plan to investigate it but this is not on my short list :) Alternatively one can create graphs without using it atm. Regards Andrzej > > Best regards, > Krzysztof > >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> index 03453b822093..042e5894a138 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> @@ -868,6 +868,18 @@ >> }; >> }; >> }; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + muic_to_usb: endpoint { >> + remote-endpoint = <&usb_to_muic>; >> + }; >> + }; >> + }; >> }; >> >> regulators { >> @@ -1287,12 +1299,17 @@ >> >> &usbdrd_dwc3 { >> dr_mode = "otg"; >> - extcon = <&muic>; >> }; >> >> &usbdrd30_phy { >> vbus-supply = <&safeout1_reg>; >> status = "okay"; >> + >> + port { >> + usb_to_muic: endpoint { >> + remote-endpoint = <&muic_to_usb>; >> + }; >> + }; >> }; >> >> &xxti { >> -- >> 2.17.0 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 22 June 2018 at 12:39, Andrzej Hajda <a.hajda@samsung.com> wrote: > On 20.06.2018 20:28, Krzysztof Kozlowski wrote: >> On Tue, May 15, 2018 at 02:12:39PM +0200, Andrzej Hajda wrote: >>> OF graph describes USB data lanes between USB-PHY and respective MUIC. >>> Since graph is present and DWC driver can use it to get extcon, obsolete >>> extcon property can be removed. >>> >>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >>> --- >>> .../dts/exynos/exynos5433-tm2-common.dtsi | 19 ++++++++++++++++++- >>> 1 file changed, 18 insertions(+), 1 deletion(-) >> dtc W=1 now complains with: >> === >> Warning (graph_child_address): >> /soc/hsi2c@14d90000/max77843@66/max77843-muic/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary >> === >> >> Do you plan to add more ports soon? > > There could be a link between UART and MUIC, it could be beneficial for > the platform - there is no point to feed UART with data when UART output > is muxed-out by MUIC. > So I plan to investigate it but this is not on my short list :) > Alternatively one can create graphs without using it atm. In that case could you remove here the address/size-cells to fix the warning? I see that code uses -1 in of_graph_get_remote_node() so it should not depend on the reg number. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi index 03453b822093..042e5894a138 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi @@ -868,6 +868,18 @@ }; }; }; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + muic_to_usb: endpoint { + remote-endpoint = <&usb_to_muic>; + }; + }; + }; }; regulators { @@ -1287,12 +1299,17 @@ &usbdrd_dwc3 { dr_mode = "otg"; - extcon = <&muic>; }; &usbdrd30_phy { vbus-supply = <&safeout1_reg>; status = "okay"; + + port { + usb_to_muic: endpoint { + remote-endpoint = <&muic_to_usb>; + }; + }; }; &xxti {
OF graph describes USB data lanes between USB-PHY and respective MUIC. Since graph is present and DWC driver can use it to get extcon, obsolete extcon property can be removed. Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> --- .../dts/exynos/exynos5433-tm2-common.dtsi | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-)