| Message ID | 20180515113052.GA111532@lkp-ib04 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, May 15, 2018 at 07:30:52PM +0800, kbuild test robot wrote: > > Fixes: 58d8108f080c ("drm/vkms: Introduce basic VKMS driver") > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > --- > vkms_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c > index b1df08e..35517b09 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.c > +++ b/drivers/gpu/drm/vkms/vkms_drv.c > @@ -40,7 +40,7 @@ static void vkms_release(struct drm_device *dev) > drm_dev_fini(&vkms->drm); > } > > -struct drm_driver vkms_driver = { > +static struct drm_driver vkms_driver = { > .driver_features = DRIVER_MODESET | DRIVER_ATOMIC | DRIVER_GEM, > .release = vkms_release, > .fops = &vkms_driver_fops, Looks good to me. - Haneen
On Tue, May 15, 2018 at 07:30:52PM +0800, kbuild test robot wrote: > > Fixes: 58d8108f080c ("drm/vkms: Introduce basic VKMS driver") > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> One thing I noticed while applying this: Your author (as recorded in the From: line) and your s-o-b don't match. Now I know that you're behind 0day, so it's ok, but our script gets annoyed and I need to overrule it with an -f flag. Can you perhaps get the From: and S-o-b: lines into agreement so that a simple comparison works? Thanks, Daniel > --- > vkms_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c > index b1df08e..35517b09 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.c > +++ b/drivers/gpu/drm/vkms/vkms_drv.c > @@ -40,7 +40,7 @@ static void vkms_release(struct drm_device *dev) > drm_dev_fini(&vkms->drm); > } > > -struct drm_driver vkms_driver = { > +static struct drm_driver vkms_driver = { > .driver_features = DRIVER_MODESET | DRIVER_ATOMIC | DRIVER_GEM, > .release = vkms_release, > .fops = &vkms_driver_fops,
> Subject: Re: [kbuild-all] [RFC PATCH] drm/vkms: vkms_driver can be static > > On Tue, May 15, 2018 at 07:30:52PM +0800, kbuild test robot wrote: > > > > Fixes: 58d8108f080c ("drm/vkms: Introduce basic VKMS driver") > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > > One thing I noticed while applying this: Your author (as recorded in the > From: line) and your s-o-b don't match. Now I know that you're behind > 0day, so it's ok, but our script gets annoyed and I need to overrule it > with an -f flag. > > Can you perhaps get the From: and S-o-b: lines into agreement so that a > simple comparison works? thanks for input, we the bot team has decided to use uniform From with the address lkp recently, while the auto generated script is still using specific author's signed-off-by. > > Thanks, Daniel > > > --- > > vkms_drv.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c > b/drivers/gpu/drm/vkms/vkms_drv.c > > index b1df08e..35517b09 100644 > > --- a/drivers/gpu/drm/vkms/vkms_drv.c > > +++ b/drivers/gpu/drm/vkms/vkms_drv.c > > @@ -40,7 +40,7 @@ static void vkms_release(struct drm_device *dev) > > drm_dev_fini(&vkms->drm); > > } > > > > -struct drm_driver vkms_driver = { > > +static struct drm_driver vkms_driver = { > > .driver_features = DRIVER_MODESET | DRIVER_ATOMIC | > DRIVER_GEM, > > .release = vkms_release, > > .fops = &vkms_driver_fops, > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch > _______________________________________________ > kbuild-all mailing list > kbuild-all@lists.01.org > https://lists.01.org/mailman/listinfo/kbuild-all
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c index b1df08e..35517b09 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.c +++ b/drivers/gpu/drm/vkms/vkms_drv.c @@ -40,7 +40,7 @@ static void vkms_release(struct drm_device *dev) drm_dev_fini(&vkms->drm); } -struct drm_driver vkms_driver = { +static struct drm_driver vkms_driver = { .driver_features = DRIVER_MODESET | DRIVER_ATOMIC | DRIVER_GEM, .release = vkms_release, .fops = &vkms_driver_fops,
Fixes: 58d8108f080c ("drm/vkms: Introduce basic VKMS driver") Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- vkms_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)