Message ID | 20180517035411.3429-1-himanshu.madhani@cavium.com (mailing list archive) |
---|---|
State | Rejected |
Headers | show
Return-Path: <linux-scsi-owner@kernel.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6D8DC60353 for <patchwork-linux-scsi@patchwork.kernel.org>; Thu, 17 May 2018 03:54:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5E95228910 for <patchwork-linux-scsi@patchwork.kernel.org>; Thu, 17 May 2018 03:54:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 51C8728927; Thu, 17 May 2018 03:54:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 839D828910 for <patchwork-linux-scsi@patchwork.kernel.org>; Thu, 17 May 2018 03:54:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751520AbeEQDyV (ORCPT <rfc822;patchwork-linux-scsi@patchwork.kernel.org>); Wed, 16 May 2018 23:54:21 -0400 Received: from mail-co1nam03on0067.outbound.protection.outlook.com ([104.47.40.67]:47639 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751379AbeEQDyT (ORCPT <rfc822;linux-scsi@vger.kernel.org>); Wed, 16 May 2018 23:54:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u1HUOkZsaGGmMzCTevYR9AJ3rUyyefwJedVRfnfnY+U=; b=jDBrRFH9DYwe/6EqENxywI0WlC8RQJT6k1gqYYx8yEI80OF3F7S9UqlE2+5R6bzSHKlEMNRzrzfOH7usTsTcXI+XAS6UrnQmkVm2JvIhZtBpGqw1q9UY7y+gOpj4vwuBA294wwPSkvSvvDAAe5Vvwxoj/XfHCumLhmhzLhfPnvQ= Received: from DM6PR07CA0010.namprd07.prod.outlook.com (2603:10b6:5:94::23) by MW2PR07MB3913.namprd07.prod.outlook.com (2603:10b6:907:5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Thu, 17 May 2018 03:54:17 +0000 Received: from BL2FFO11FD024.protection.gbl (2a01:111:f400:7c09::124) by DM6PR07CA0010.outlook.office365.com (2603:10b6:5:94::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.776.11 via Frontend Transport; Thu, 17 May 2018 03:54:17 +0000 Authentication-Results: spf=pass (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=cavium.com; Received-SPF: Pass (protection.outlook.com: domain of cavium.com designates 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BL2FFO11FD024.mail.protection.outlook.com (10.173.161.103) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.735.16 via Frontend Transport; Thu, 17 May 2018 03:54:16 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 16 May 2018 20:54:11 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id w4H3sBqU003464; Wed, 16 May 2018 20:54:11 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id w4H3sBTs003463; Wed, 16 May 2018 20:54:11 -0700 From: Himanshu Madhani <himanshu.madhani@cavium.com> To: <James.Bottomley@HansenPartnership.com>, <martin.petersen@oracle.com> CC: <himanshu.madhani@cavium.com>, <linux-scsi@vger.kernel.org> Subject: [PATCH 1/1] qla2xxx: Allow SCSI-MQ to be enabled selectively Date: Wed, 16 May 2018 20:54:11 -0700 Message-ID: <20180517035411.3429-1-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(376002)(346002)(396003)(2980300002)(438002)(199004)(189003)(106002)(305945005)(5660300001)(42186006)(16586007)(36756003)(316002)(54906003)(1076002)(110136005)(51416003)(356003)(72206003)(478600001)(106466001)(87636003)(4326008)(50466002)(186003)(48376002)(126002)(2906002)(80596001)(50226002)(476003)(486006)(44832011)(2616005)(81156014)(26005)(86362001)(47776003)(69596002)(336012)(81166006)(8676002)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:MW2PR07MB3913; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Pass; LANG:en; PTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD024; 1:edmqx1OIu7IheovDQnz73OcmVKVSD04HEuHy93MT+xArNMOjno34z5OJJ2CAFX/2tJ0A74lMwvcy05L8bY0xVtAncR5f7asPdeyhZcMSvUN6xuDP3HUCaoI2jdRiZkrz X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4608076)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060); SRVR:MW2PR07MB3913; X-Microsoft-Exchange-Diagnostics: 1; MW2PR07MB3913; 3:RaWW9Rbkd1fcNCO9eCHiW2m1g2M8GE9dfkUPWz3NVdjD5RCVy7liiPPQO6tB5Efk/baAf1+0EaPlbp/lphJyrz5Xm3lIHhcfsqE+wJvUGXIo0pVQbVBTAZpEBi3Dmr7jwZ1WOrGniFpbNiE7Ty9W1+FOgn9veA4hpeMjTiIJP8xSi81Uc0/WIizf9LqEnuRmyYk5xmDdG2LScIUWFfYyEXZZ8ajleLpejQvXlUp0dDtu7KWRiUQ5BkrDlqhM2HGnRZsumJ8UexefDWyHMJVRk6wpiG7xUwWj4f0Eg/2aoov3gRtp/bU/jlTr1lZMSb9+kEsZK0dDxwdoNm61TPXwi1PANw6sDX+l6xHsWkVKxUk=; 25:dVkLNQuoJmrjr2FRf2G/kCN8A4xQn4KXUWXwCuoZFP+y2ucN7i8nktS3qYxuW2IKUGNb8Kn9aTHcpt/GcU4DZGv/5Qxxrztp/Ke5BAvLbHZ3ilLyO6LLQzv7ZBXAKQIDzPfQOXRE5pEY33o4KgpFPXNQs8sC3en4pMM1clzTBCgBtp/x6NXGFs41Acyp3CDtV/+281v8rp/5MCiy6pUPDhuiTNJOOgoX+J0D636q3OXCGMsJBdRvluZXVyTHwm4Hnj77vSJT6fs17CZJ9b0nEwZb/oceBd9r8uJArmDFPyWmOXv4xeuurJaCEvGBb1P7hG0yMeRTnVmm22AXZrdwPA== X-MS-TrafficTypeDiagnostic: MW2PR07MB3913: X-Microsoft-Exchange-Diagnostics: 1; MW2PR07MB3913; 31:pFgMeY2ZJl4o7mgP6hRUSWHz/XSGlR4o0d48zcKoOa8Bhn5Thfgj/6EiMZNBTuv6+CubrY/h9R+nHLcQ8Sb1T5RltjzucCIiEa+1xBs4iHJ7gp11WN2DJ1xgkIedOPfwAahEw89dzyscc8XCLikWeXmCkJFNAxHSmbuJ+bU7aUnEEj/qMvvagUITa5sd3KeMTONYx5XeQQ6MVg8GZ43yGh8fzRoWdAyD/OJrcbEZLqw=; 20:Fq/VaoqVBuGGsar/mIrSaPI2euOHaTt2OxGehGGxvYV4XpFh1uR7AGD39olRpQ0T0jLQn+1wbyCkJA3kzX/1j9WBc9lY5UA/xbDPbb/Ac/hZC+o9S0XKT8nJYawHEfqgQFA1osm3XphKN9WVvnqqUh5nHlxTlUDjEAohKbRvRU/AOlApVEhF7XfpLcUQcyNNbd6x6MB9vMBnJAUjPqdIIdWdcprh6yzyNMhGWd94Iyu2AA8EbbDmo3WppLm87um7D32OzAYFD6aL3D/yWAc8bCclTDCSWaaclpNoYtzOWCpVX5p0dJspawffNfTy8/zNGiCK4FxwFCbePlTEpaxmZvnj61Ts9jO14K36rrGnar/9uWR1+F0ZDK0B4UsqKvDnhqjxXDdPIDe5lo2HGnCk75JWPxs5bZAiHIq8pIH7k/qYLhw2Np3p6iF+x3jmvRBYIyjPUTVQVie8GXlw3nim7rs80yxJdhBcYZrZrz9R7YO/zalMue86fd1YZxwKHUC9 X-Microsoft-Antispam-PRVS: <MW2PR07MB3913927A0D067548816E9A4FF5910@MW2PR07MB3913.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3231254)(944501410)(52105095)(3002001)(93006095)(93004095)(149027)(150027)(6041310)(20161123560045)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:MW2PR07MB3913; BCL:0; PCL:0; RULEID:; SRVR:MW2PR07MB3913; X-Microsoft-Exchange-Diagnostics: 1; MW2PR07MB3913; 4:LxKobYj8No6gn3FZxMJJUNLZ6LNXAa3FaLRidE4Rj+CJwqvrKleYJzc7mrqyFHGkzv9czDz6tVPkYLdaBnfRdr0fA4zAtfyoSOSlO9TyxRx1Tzy+dzP3eltUTjj6ZkxnTmBkcqEUxJMgv8bcEPAv+kjKNo2vJBiAg9Mf2ehMEdwpUmgCAI16dSSIjL9xmoPfdi4zkKWqflc1DiRrjRsn+m53RBIM7gm2QZjzfxL4xDH+KGKgGeKtIOOrS6HT7HZUQs5reEqdCj5Xzf8r77iEQQ== X-Forefront-PRVS: 067553F396 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MW2PR07MB3913; 23:cSWj9/UHuueyvwVjIwgxGQdWTa9SaBVL1nx3o9Bqh?= =?us-ascii?Q?R15Z73E4aUa9GXnDpV5jlhCN0GYq+iy24EG+ZyZASAX8YGzdTdMd5TjtPUHi?= =?us-ascii?Q?DH49nZyqp9VL2/TLPlS/x7CxibcGDl4ao0xUTVO4OgMs/pz37QzDhhY+JxS5?= =?us-ascii?Q?/DhwVVt38pGRCFrS0tk6ahC68EUQsp8339nX41xeHcKbIRX/fdXmOYCRgpVw?= =?us-ascii?Q?RcKUo4v+KZaFyWmUi/ANlKtPIYOyJGUAPywEEbO/BUnkrjmxEYPglQXWKAJ2?= =?us-ascii?Q?qCnodtLJ9PqkyvQFwJHJ8dIXqOcmQCSg/K1DPWWKPGqBviNMToBY7+xroF9z?= =?us-ascii?Q?B9QFnhHJO+pIwQEwKB35JrV4bak+SqUoUsAuxZeblYl9uZtd1lEDdNfxo1bS?= =?us-ascii?Q?ZMzhxU6EeWkfCVRJUWeTXFf+ELM0d36dfNKFk00PrZ0FqEbIKhSPRxwJQT/8?= =?us-ascii?Q?0JttRf36iOhk8GLqk27KjrYF7EyJKRypPRm38KcUOj9qb4psRfIl8/IYvK5x?= =?us-ascii?Q?xicQxMee9k5AjgosCVpm+cwgiLmDP/UQhZdTZ5nc6sGtkanClbBj2in8jxjR?= =?us-ascii?Q?a0XrHh9YAJmxTRBZP9qc/MEa9K9PPOnUyxYnW8lEhhDj5iAnT0h9Ew6mOD9K?= =?us-ascii?Q?j84GkHuCfy/Aee1uUB5lcL3TQ6+nauxP8szrKBnnzLdY38HdhNH32K6QMqDp?= =?us-ascii?Q?wVG+f9L6f1JKJIpHo+IoPQhLSMN6uA0T60pmECibm+HGSsNLmjjw+a0ZjK/w?= =?us-ascii?Q?vZqyaw/4tOsdsa9FjjATwSU1anSFxYk1Xb4NTgcdRSlGDpjodYU8AQK3xFYh?= =?us-ascii?Q?IAPe9twLgIigtmlE6PxobqjHW5yUf7ySwLKPgVQm9LS31CHHQ/I82vr5VkNX?= =?us-ascii?Q?Rwsq66k7cBqHnoRGPlikunlgiVjSUOFuvd+yzQ2T3pMa46/J/wMBDH4aiqQw?= =?us-ascii?Q?+L/y8NWYEwhRhMmcmqJwvuXhSPiobUBf+Ja9tEaGeCqgp/h7LO8tx3foJ3Gh?= =?us-ascii?Q?0wLi68x+dxLRnYQDUjrHo4crnPZZi4lQILXFVa/WNP5IZst10MOzj/9n58Ss?= =?us-ascii?Q?0S7tcU=3D?= X-Microsoft-Antispam-Message-Info: 6rCeuOyaUeUW5i+FZgKEMTRx6ytcspUTd5QKe5oeIWPJMEhN1As44jx9OTwAw9tuDRjC7NSJMVnrb+5VjwIYQPC0DAGyPmehmRMz9fXlFfE4vYqcqcxJgAmuItsOCDYAQ5Gdll9mY3eKCBaHKfWy9QFtAXD4K6+zJHToQRcWJUzKZ1QORdX7DwveOdgm+cFR X-Microsoft-Exchange-Diagnostics: 1; MW2PR07MB3913; 6:SL++inP0EkS3ATZks2YaxbElZ3Ayj/0LJp507RIn2oQmzGru+78t/kyCd92HkAcyOXQmECSwOl5KxTwKgPn/tn6VJjwwWzkUH2jiZoSTmG50D/Ds78I5hEbOD0SnSqql5u3yMBUm5edzNZQ07u8tu+cD0yheO5SxqI5SLsO6AG/w4hUm2SEPggd4Yuc4Ro8DGiZQgVCgZj3rOIim2idSyl8i19gihQiTlH7QPt/nBJJ4QcmPIvKolfhTdywjv0czz99hpSActQFHTVDuiaJXbsgIaCjpKMCZrSa5vESjc7XOOty6fMioIr+y8v2fu1zcEPFraRziwlaMkMOARvcpzSAmQ7c/9y21FQMphL49Fkrfo7Kp1RLaEpoTfFPZbs43PKkbHB01jRKWptCAGa0WPguvlLopFQr1nQxHEouOTd6N7M30waXJ38qRsR/XoPIXeg5WkjWzx7DLWYnBSuAsDw==; 5:/HjIug0dqanmxYtDUhH7jbAPC8JHt+9PuDCahAhvic3WcHUalN12F620NoBCSMqb0qndo7tELS04xm0d27c6XpyRddHT1HVMC1/UyhGReSsOeqeFQ/4dN0v4GITSICY7Brw5u+QuEdO/S8xhfJwULm1a1slE3jIkSX5oaNWtnTg=; 24:238wMwvj/+GUeCIjR5V2IM3K4Lialw11UTIWg2aXcwt/eG/oajfiG356oSI9eRpMtsBjMLwbE4zL18RrGY/+PxEUceQD6acIlBajvlMvSQE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; MW2PR07MB3913; 7:IUcePmKCpAYWpKxUQmiW9IdJ6op/sDDjOzYacVioK3cOeweXviREMQAX8Ng4efENwOat1NZMQLTmou/xW2+XATn71Ogh5OoFHrpWN/y/a2BG3mxIOuEAefYfrOiAviWZmsDTO/eUda+NRJo1m8fsbaSRy7WMf7HVcdsbo5sEBYZVaa5FOpqx2/xrhgFD5C+9OyC8kFqLJK7LYNx6WjU1zcIjqELLj+ddcltadkc+D7+wDReFD1xO+y1bdkaA502i X-MS-Office365-Filtering-Correlation-Id: d616f095-6edd-4f49-5a58-08d5bba9dcbd X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2018 03:54:16.6625 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d616f095-6edd-4f49-5a58-08d5bba9dcbd X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR07MB3913 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: <linux-scsi.vger.kernel.org> X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
On Wed, May 16, 2018 at 08:54:11PM -0700, Himanshu Madhani wrote: > when ql2xmqsupport=1, use that value to selectively > enable SCSI-MQ NAK. This is not something that we should grow driver parameters for. Btw, should we look into enabling blk-mq by default again now that all the performance fixes went in and srttled down?
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 817c18a8e84d..f870e85be38f 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -4566,6 +4566,7 @@ struct scsi_qla_host *qla2x00_create_host(struct scsi_host_template *sht, return NULL; } + host->use_blk_mq = ql2xmqsupport ? true : false; /* Clear our data area */ vha = shost_priv(host); memset(vha, 0, sizeof(scsi_qla_host_t));
when ql2xmqsupport=1, use that value to selectively enable SCSI-MQ Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com> --- drivers/scsi/qla2xxx/qla_os.c | 1 + 1 file changed, 1 insertion(+)