| Message ID | 20180511005419.11199-1-dhinakaran.pandiyan@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 2018-05-10 at 17:54 -0700, Dhinakaran Pandiyan wrote: > Entry corresponding to 220 us setup time was missing. I am not aware > of > any specific bug this fixes, but this could potentially result in > enabling > PSR on a panel with a higher setup time requirement than supported by > the > hardware. It should be 'a lower setup time'. Sink sets 2h requesting 220us but source will only wait 165us. Other than that looks good: Reviewed-by: José Roberto de Souza <jose.souza@intel.com> > > I verified the value is present in eDP spec versions 1.3, 1.4 and > 1.4a. > > Fixes: 6608804b3d7f ("drm/dp: Add drm_dp_psr_setup_time()") > Cc: stable@vger.kernel.org > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Jose Roberto de Souza <jose.souza@intel.com> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> > --- > drivers/gpu/drm/drm_dp_helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/drm_dp_helper.c > b/drivers/gpu/drm/drm_dp_helper.c > index 36c7609a4bd5..a7ba602a43a8 100644 > --- a/drivers/gpu/drm/drm_dp_helper.c > +++ b/drivers/gpu/drm/drm_dp_helper.c > @@ -1159,6 +1159,7 @@ int drm_dp_psr_setup_time(const u8 > psr_cap[EDP_PSR_RECEIVER_CAP_SIZE]) > static const u16 psr_setup_time_us[] = { > PSR_SETUP_TIME(330), > PSR_SETUP_TIME(275), > + PSR_SETUP_TIME(220), > PSR_SETUP_TIME(165), > PSR_SETUP_TIME(110), > PSR_SETUP_TIME(55),
On Fri, 2018-05-11 at 18:03 +0000, Souza, Jose wrote: > On Thu, 2018-05-10 at 17:54 -0700, Dhinakaran Pandiyan wrote: > > > > Entry corresponding to 220 us setup time was missing. I am not > > aware > > of > > any specific bug this fixes, but this could potentially result in > > enabling > > PSR on a panel with a higher setup time requirement than supported > > by > > the > > hardware. > It should be 'a lower setup time'. > Sink sets 2h requesting 220us but source will only wait 165us. By hardware, I meant source :) We'll end up enabling PSR on a sink with a higher setup time requirement (220us) than supported by the source hardware (let's say 200 us) because we read the sink requirement as 165 us. > > Other than that looks good: > Reviewed-by: José Roberto de Souza <jose.souza@intel.com> > Thanks! I'll resend this along the other PSR patch you reviewed. > > > > > > I verified the value is present in eDP spec versions 1.3, 1.4 and > > 1.4a. > > > > Fixes: 6608804b3d7f ("drm/dp: Add drm_dp_psr_setup_time()") > > Cc: stable@vger.kernel.org > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Cc: Jose Roberto de Souza <jose.souza@intel.com> > > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> > > --- > > drivers/gpu/drm/drm_dp_helper.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/drm_dp_helper.c > > b/drivers/gpu/drm/drm_dp_helper.c > > index 36c7609a4bd5..a7ba602a43a8 100644 > > --- a/drivers/gpu/drm/drm_dp_helper.c > > +++ b/drivers/gpu/drm/drm_dp_helper.c > > @@ -1159,6 +1159,7 @@ int drm_dp_psr_setup_time(const u8 > > psr_cap[EDP_PSR_RECEIVER_CAP_SIZE]) > > static const u16 psr_setup_time_us[] = { > > PSR_SETUP_TIME(330), > > PSR_SETUP_TIME(275), > > + PSR_SETUP_TIME(220), > > PSR_SETUP_TIME(165), > > PSR_SETUP_TIME(110), > > PSR_SETUP_TIME(55),
On Thu, May 10, 2018 at 05:54:19PM -0700, Dhinakaran Pandiyan wrote: > Entry corresponding to 220 us setup time was missing. I am not aware of > any specific bug this fixes, but this could potentially result in enabling > PSR on a panel with a higher setup time requirement than supported by the > hardware. > > I verified the value is present in eDP spec versions 1.3, 1.4 and 1.4a. > > Fixes: 6608804b3d7f ("drm/dp: Add drm_dp_psr_setup_time()") > Cc: stable@vger.kernel.org > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Jose Roberto de Souza <jose.souza@intel.com> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> > --- > drivers/gpu/drm/drm_dp_helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c > index 36c7609a4bd5..a7ba602a43a8 100644 > --- a/drivers/gpu/drm/drm_dp_helper.c > +++ b/drivers/gpu/drm/drm_dp_helper.c > @@ -1159,6 +1159,7 @@ int drm_dp_psr_setup_time(const u8 psr_cap[EDP_PSR_RECEIVER_CAP_SIZE]) > static const u16 psr_setup_time_us[] = { > PSR_SETUP_TIME(330), > PSR_SETUP_TIME(275), > + PSR_SETUP_TIME(220), Verified the PSR set up time table in the eDP 1.4b spec Reviewed-by: Tarun Vyas <tarun.vyas@intel.com> > PSR_SETUP_TIME(165), > PSR_SETUP_TIME(110), > PSR_SETUP_TIME(55), > -- > 2.14.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 36c7609a4bd5..a7ba602a43a8 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b/drivers/gpu/drm/drm_dp_helper.c @@ -1159,6 +1159,7 @@ int drm_dp_psr_setup_time(const u8 psr_cap[EDP_PSR_RECEIVER_CAP_SIZE]) static const u16 psr_setup_time_us[] = { PSR_SETUP_TIME(330), PSR_SETUP_TIME(275), + PSR_SETUP_TIME(220), PSR_SETUP_TIME(165), PSR_SETUP_TIME(110), PSR_SETUP_TIME(55),
Entry corresponding to 220 us setup time was missing. I am not aware of any specific bug this fixes, but this could potentially result in enabling PSR on a panel with a higher setup time requirement than supported by the hardware. I verified the value is present in eDP spec versions 1.3, 1.4 and 1.4a. Fixes: 6608804b3d7f ("drm/dp: Add drm_dp_psr_setup_time()") Cc: stable@vger.kernel.org Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Jose Roberto de Souza <jose.souza@intel.com> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> --- drivers/gpu/drm/drm_dp_helper.c | 1 + 1 file changed, 1 insertion(+)